Re: [PATCH] app/testpmd: add flush multicast MAC address command

[Stephen Hemminger <stephen@networkplumber.org>]

On Wed, 2 Aug 2023 10:41:46 +0800
huangdengdui <huangdengdui@huawei.com> wrote:

> 在 2023/8/1 23:18, Stephen Hemminger 写道:
> > On Tue, 1 Aug 2023 10:43:04 +0800
> > Dengdui Huang <huangdengdui@huawei.com> wrote:
> >   
> >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> >> index 0d0723f659..2d9d925776 100644
> >> --- a/app/test-pmd/cmdline.c
> >> +++ b/app/test-pmd/cmdline.c
> >> @@ -494,6 +494,9 @@ static void cmd_help_long_parsed(void *parsed_result,
> >>  			"mac_addr remove (port_id) (XX:XX:XX:XX:XX:XX)\n"
> >>  			"    Remove a MAC address from port_id.\n\n"
> >>  
> >> +			"mcast_addr flush (port_id)\n"
> >> +			"    To flush the set of multicast addresses.\n\n"
> >> +
> >>  			"mac_addr set (port_id) (XX:XX:XX:XX:XX:XX)\n"
> >>  			"    Set the default MAC address for port_id.\n\n"  
> > 
> > Why out this in middle of the mac_addr commands? better to be in logical or alpha order.  
> Sorry Stephen, I made a mistake in my reply. It's already in logical order(mac_addr/mcast_addr add/remove---->other setting), the same order as in the doc.
> The order looks odd because the help command doesn't have a description of "multicast add/remove".Do you agree with this explanation?

The help is already a bit of a mess. It really needs to be split up more.

Lets add the new line after "set allmulti"?