From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
David Gow <davidgow@google.com>,
Daniel Latypov <dlatypov@google.com>,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
linux-pci@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Brendan Higgins <brendan.higgins@linux.dev>,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v4 1/4] kernel.h: Split out COUNT_ARGS() and CONCATENATE() to args.h
Date: Tue, 1 Aug 2023 16:11:39 -0500 [thread overview]
Message-ID: <20230801211139.GA51676@bhelgaas> (raw)
In-Reply-To: <20230718211147.18647-2-andriy.shevchenko@linux.intel.com>
On Wed, Jul 19, 2023 at 12:11:44AM +0300, Andy Shevchenko wrote:
> kernel.h is being used as a dump for all kinds of stuff for a long time.
> The COUNT_ARGS() and CONCATENATE() macros may be used in some places
> without need of the full kernel.h dependency train with it.
>
> Here is the attempt on cleaning it up by splitting out these macros().
>
> While at it, include new header where it's being used.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Bjorn Helgaas <bhelgaas@google.com> # PCI
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 0ff7500772e6..eeb2e6f6130f 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -23,7 +23,7 @@
> #ifndef LINUX_PCI_H
> #define LINUX_PCI_H
>
> -
> +#include <linux/args.h>
> #include <linux/mod_devicetable.h>
>
> #include <linux/types.h>
If there's not a reason otherwise, I'd put this in the main list
instead of the weirdly separated mod_devicetable.h.
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
David Gow <davidgow@google.com>,
Daniel Latypov <dlatypov@google.com>,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
linux-pci@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Brendan Higgins <brendan.higgins@linux.dev>,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v4 1/4] kernel.h: Split out COUNT_ARGS() and CONCATENATE() to args.h
Date: Tue, 1 Aug 2023 16:11:39 -0500 [thread overview]
Message-ID: <20230801211139.GA51676@bhelgaas> (raw)
In-Reply-To: <20230718211147.18647-2-andriy.shevchenko@linux.intel.com>
On Wed, Jul 19, 2023 at 12:11:44AM +0300, Andy Shevchenko wrote:
> kernel.h is being used as a dump for all kinds of stuff for a long time.
> The COUNT_ARGS() and CONCATENATE() macros may be used in some places
> without need of the full kernel.h dependency train with it.
>
> Here is the attempt on cleaning it up by splitting out these macros().
>
> While at it, include new header where it's being used.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Bjorn Helgaas <bhelgaas@google.com> # PCI
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 0ff7500772e6..eeb2e6f6130f 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -23,7 +23,7 @@
> #ifndef LINUX_PCI_H
> #define LINUX_PCI_H
>
> -
> +#include <linux/args.h>
> #include <linux/mod_devicetable.h>
>
> #include <linux/types.h>
If there's not a reason otherwise, I'd put this in the main list
instead of the weirdly separated mod_devicetable.h.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-01 21:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 21:11 [PATCH v4 0/4] kernel.h: Split out a couple of macros to args.h Andy Shevchenko
2023-07-18 21:11 ` Andy Shevchenko
2023-07-18 21:11 ` [PATCH v4 1/4] kernel.h: Split out COUNT_ARGS() and CONCATENATE() " Andy Shevchenko
2023-07-18 21:11 ` Andy Shevchenko
2023-07-19 6:15 ` David Gow
2023-07-19 6:15 ` David Gow
2023-08-01 21:11 ` Bjorn Helgaas [this message]
2023-08-01 21:11 ` Bjorn Helgaas
2023-08-02 3:18 ` Andy Shevchenko
2023-08-02 3:18 ` Andy Shevchenko
2023-07-18 21:11 ` [PATCH v4 2/4] x86/asm: Replace custom COUNT_ARGS() & CONCATENATE() implementations Andy Shevchenko
2023-07-18 21:11 ` Andy Shevchenko
2023-07-18 21:11 ` [PATCH v4 3/4] arm64: smccc: " Andy Shevchenko
2023-07-18 21:11 ` Andy Shevchenko
2023-07-18 21:11 ` [PATCH v4 4/4] genetlink: Replace custom CONCATENATE() implementation Andy Shevchenko
2023-07-18 21:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801211139.GA51676@bhelgaas \
--to=helgaas@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=brendan.higgins@linux.dev \
--cc=dave.hansen@linux.intel.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=hpa@zytor.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.