[Buildroot] [PATCH] package/less: install the lessecho command

[Buildroot] [PATCH] package/less: install the lessecho command

[carrier.nicolas0]

From: Nicolas Carrier <nicolas.carrier@nav-timing.safrangroup.com>

it is required by, for example the s command, allowing to write to a file
---
 package/less/less.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/less/less.mk b/package/less/less.mk
index 91ce08f4f0..ed9d8f0f90 100644
--- a/package/less/less.mk
+++ b/package/less/less.mk
@@ -13,6 +13,7 @@ LESS_DEPENDENCIES = ncurses
 
 define LESS_INSTALL_TARGET_CMDS
 	$(INSTALL) -m 0755 $(@D)/less $(TARGET_DIR)/usr/bin/less
+	$(INSTALL) -m 0755 $(@D)/lessecho $(TARGET_DIR)/usr/bin/lessecho
 endef
 
 $(eval $(autotools-package))
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/less: install the lessecho command

[Thomas Petazzoni via buildroot]

Hello Nicolas,

On Tue,  1 Aug 2023 11:37:35 +0200
carrier.nicolas0@gmail.com wrote:

> From: Nicolas Carrier <nicolas.carrier@nav-timing.safrangroup.com>
> 
> it is required by, for example the s command, allowing to write to a file

I think you should clarify that you're talking about the "s command"
inside less. Because I was thinking you were talking about a program
called "s".

I cannot apply your patch: we need your Signed-off-by line.

>  define LESS_INSTALL_TARGET_CMDS
>  	$(INSTALL) -m 0755 $(@D)/less $(TARGET_DIR)/usr/bin/less
> +	$(INSTALL) -m 0755 $(@D)/lessecho $(TARGET_DIR)/usr/bin/lessecho
>  endef

I think the best solution is in fact to drop LESS_INSTALL_TARGET_CMDS
entirely, so that "make install" is used instead. It installs the
following:

└── usr
    ├── bin
    │   ├── less
    │   ├── lessecho
    │   └── lesskey
    └── share
        └── man
            └── man1
                ├── less.1
                ├── lessecho.1
                └── lesskey.1

usr/share/man is going to be removed automatically by Buildroot at the
end of the build. So that leave us with usr/bin with less, lessecho and
lesskey. So I believe it makes more sense to let the default "make
install" do its job.

I would have fixed that myself when applying, but I need your
Signed-off-by in the patch to be able to proceed.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot