* [PATCH] mm/memcg: fix wrong function name above obj_cgroup_charge_zswap()
@ 2023-08-03 12:00 ` Miaohe Lin
0 siblings, 0 replies; 5+ messages in thread
From: Miaohe Lin @ 2023-08-03 12:00 UTC (permalink / raw)
To: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
hannes-druUgvl0LCNAfugRpC6u6w, mhocko-DgEjT+Ai2ygdnm+yROfE0A,
roman.gushchin-fxUVXftIFDnyG1zEObXtfA,
shakeelb-hpIqsD4AKlfQT0dZR+AlfA
Cc: muchun.song-fxUVXftIFDnyG1zEObXtfA,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg, cgroups-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linmiaohe-hv44wF8Li93QT0dZR+AlfA
The correct function name is obj_cgroup_may_zswap(). Correct the comment.
Signed-off-by: Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 1ff51d8df84a..a026058ac720 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -7786,7 +7786,7 @@ bool obj_cgroup_may_zswap(struct obj_cgroup *objcg)
* @objcg: the object cgroup
* @size: size of compressed object
*
- * This forces the charge after obj_cgroup_may_swap() allowed
+ * This forces the charge after obj_cgroup_may_zswap() allowed
* compression and storage in zwap for this cgroup to go ahead.
*/
void obj_cgroup_charge_zswap(struct obj_cgroup *objcg, size_t size)
--
2.33.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] mm/memcg: fix wrong function name above obj_cgroup_charge_zswap()
@ 2023-08-03 12:00 ` Miaohe Lin
0 siblings, 0 replies; 5+ messages in thread
From: Miaohe Lin @ 2023-08-03 12:00 UTC (permalink / raw)
To: akpm, hannes, mhocko, roman.gushchin, shakeelb
Cc: muchun.song, linux-mm, cgroups, linux-kernel, linmiaohe
The correct function name is obj_cgroup_may_zswap(). Correct the comment.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 1ff51d8df84a..a026058ac720 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -7786,7 +7786,7 @@ bool obj_cgroup_may_zswap(struct obj_cgroup *objcg)
* @objcg: the object cgroup
* @size: size of compressed object
*
- * This forces the charge after obj_cgroup_may_swap() allowed
+ * This forces the charge after obj_cgroup_may_zswap() allowed
* compression and storage in zwap for this cgroup to go ahead.
*/
void obj_cgroup_charge_zswap(struct obj_cgroup *objcg, size_t size)
--
2.33.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/memcg: fix wrong function name above obj_cgroup_charge_zswap()
2023-08-03 12:00 ` Miaohe Lin
(?)
@ 2023-08-03 14:08 ` Johannes Weiner
-1 siblings, 0 replies; 5+ messages in thread
From: Johannes Weiner @ 2023-08-03 14:08 UTC (permalink / raw)
To: Miaohe Lin
Cc: akpm, mhocko, roman.gushchin, shakeelb, muchun.song, linux-mm,
cgroups, linux-kernel
On Thu, Aug 03, 2023 at 08:00:21PM +0800, Miaohe Lin wrote:
> The correct function name is obj_cgroup_may_zswap(). Correct the comment.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20230803120021.762279-1-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] mm/memcg: fix wrong function name above obj_cgroup_charge_zswap()
2023-08-03 12:00 ` Miaohe Lin
@ 2023-08-04 6:37 ` Muchun Song
-1 siblings, 0 replies; 5+ messages in thread
From: Muchun Song @ 2023-08-04 6:37 UTC (permalink / raw)
To: Miaohe Lin
Cc: Andrew Morton, Johannes Weiner, Michal Hocko, Roman Gushchin,
Shakeel Butt, linux-mm-Bw31MaZKKs3YtjvyW6yDsg,
cgroups-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
> On Aug 3, 2023, at 20:00, Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
>
> The correct function name is obj_cgroup_may_zswap(). Correct the comment.
>
> Signed-off-by: Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Reviewed-by: Muchun Song <songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/memcg: fix wrong function name above obj_cgroup_charge_zswap()
@ 2023-08-04 6:37 ` Muchun Song
0 siblings, 0 replies; 5+ messages in thread
From: Muchun Song @ 2023-08-04 6:37 UTC (permalink / raw)
To: Miaohe Lin
Cc: Andrew Morton, Johannes Weiner, Michal Hocko, Roman Gushchin,
Shakeel Butt, linux-mm, cgroups, linux-kernel
> On Aug 3, 2023, at 20:00, Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> The correct function name is obj_cgroup_may_zswap(). Correct the comment.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-04 6:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-03 12:00 [PATCH] mm/memcg: fix wrong function name above obj_cgroup_charge_zswap() Miaohe Lin
2023-08-03 12:00 ` Miaohe Lin
2023-08-03 14:08 ` Johannes Weiner
[not found] ` <20230803120021.762279-1-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2023-08-04 6:37 ` Muchun Song
2023-08-04 6:37 ` Muchun Song
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.