From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cgroup: minor cleanup for cgroup_local_stat_show()
Date: Thu, 3 Aug 2023 10:27:58 -0400 [thread overview]
Message-ID: <20230803142758.GC219857@cmpxchg.org> (raw)
In-Reply-To: <20230803113123.577023-1-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Thu, Aug 03, 2023 at 07:31:23PM +0800, Miaohe Lin wrote:
> Make it under CONFIG_CGROUP_SCHED to rid of __maybe_unused annotation.
> Also put cgroup_tryget_css() inside CONFIG_CGROUP_SCHED as it's only
> called when CONFIG_CGROUP_SCHED. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Acked-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
> @@ -3686,8 +3686,9 @@ static int cpu_stat_show(struct seq_file *seq, void *v)
> return ret;
> }
>
> -static int __maybe_unused cgroup_local_stat_show(struct seq_file *seq,
> - struct cgroup *cgrp, int ssid)
> +#ifdef CONFIG_CGROUP_SCHED
> +static int cgroup_local_stat_show(struct seq_file *seq,
> + struct cgroup *cgrp, int ssid)
Andrew, this is based on "sched: add throttled time stat for throttled
children" in -next (coming in from -tip). Hence the routing through
you rather than the cgroup tree.
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: akpm@linux-foundation.org, tj@kernel.org,
lizefan.x@bytedance.com, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cgroup: minor cleanup for cgroup_local_stat_show()
Date: Thu, 3 Aug 2023 10:27:58 -0400 [thread overview]
Message-ID: <20230803142758.GC219857@cmpxchg.org> (raw)
In-Reply-To: <20230803113123.577023-1-linmiaohe@huawei.com>
On Thu, Aug 03, 2023 at 07:31:23PM +0800, Miaohe Lin wrote:
> Make it under CONFIG_CGROUP_SCHED to rid of __maybe_unused annotation.
> Also put cgroup_tryget_css() inside CONFIG_CGROUP_SCHED as it's only
> called when CONFIG_CGROUP_SCHED. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> @@ -3686,8 +3686,9 @@ static int cpu_stat_show(struct seq_file *seq, void *v)
> return ret;
> }
>
> -static int __maybe_unused cgroup_local_stat_show(struct seq_file *seq,
> - struct cgroup *cgrp, int ssid)
> +#ifdef CONFIG_CGROUP_SCHED
> +static int cgroup_local_stat_show(struct seq_file *seq,
> + struct cgroup *cgrp, int ssid)
Andrew, this is based on "sched: add throttled time stat for throttled
children" in -next (coming in from -tip). Hence the routing through
you rather than the cgroup tree.
next prev parent reply other threads:[~2023-08-03 14:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 11:31 [PATCH] cgroup: minor cleanup for cgroup_local_stat_show() Miaohe Lin
2023-08-03 11:31 ` Miaohe Lin
[not found] ` <20230803113123.577023-1-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2023-08-03 14:27 ` Johannes Weiner [this message]
2023-08-03 14:27 ` Johannes Weiner
[not found] ` <20230803142758.GC219857-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2023-08-03 17:05 ` Andrew Morton
2023-08-03 17:05 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2023-07-23 3:19 Miaohe Lin
2023-07-23 3:19 ` Miaohe Lin
[not found] ` <20230723031932.3152951-1-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2023-07-25 21:53 ` Tejun Heo
2023-07-25 21:53 ` Tejun Heo
[not found] ` <ZMBERCXR27X_gRAt-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2023-07-26 1:06 ` Miaohe Lin
2023-07-26 1:06 ` Miaohe Lin
[not found] ` <ec3df402-7681-3d0c-b9ce-d50eb7383b1e-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2023-07-27 11:50 ` Miaohe Lin
2023-07-27 11:50 ` Miaohe Lin
[not found] ` <719a19c4-3be5-2260-7349-b3f1bb774f4f-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2023-07-31 23:47 ` Tejun Heo
2023-07-31 23:47 ` Tejun Heo
[not found] ` <ZMhIFUsxEtA_B781-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2023-08-01 7:48 ` Miaohe Lin
2023-08-01 7:48 ` Miaohe Lin
[not found] ` <3ec1f5d9-4887-4583-a973-92298a9bc924-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2023-08-02 19:39 ` Tejun Heo
2023-08-02 19:39 ` Tejun Heo
[not found] ` <ZMqxCVOkU7pKK9OO-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2023-08-03 1:38 ` Miaohe Lin
2023-08-03 1:38 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803142758.GC219857@cmpxchg.org \
--to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.