From: "Theodore Ts'o" <tytso@mit.edu>
To: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Ryusuke Konishi <konishi.ryusuke@gmail.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 05/12] ext4: make the IS_EXT2_SB/IS_EXT3_SB checks more robust
Date: Fri, 4 Aug 2023 16:34:23 -0400 [thread overview]
Message-ID: <20230804203423.GC903325@mit.edu> (raw)
In-Reply-To: <20230802154131.2221419-6-hch@lst.de>
On Wed, Aug 02, 2023 at 05:41:24PM +0200, Christoph Hellwig wrote:
> Check for sb->s_type which is the right place to look at the file system
> type, not the holder, which is just an implementation detail in the VFS
> helpers.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Theodore Ts'o <tytso@mit.edu>
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Ts'o" <tytso@mit.edu>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
linux-nilfs@vger.kernel.org, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org,
"Darrick J. Wong" <djwong@kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, Chris Mason <clm@fb.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Al Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org,
Ryusuke Konishi <konishi.ryusuke@gmail.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 05/12] ext4: make the IS_EXT2_SB/IS_EXT3_SB checks more robust
Date: Fri, 4 Aug 2023 16:34:23 -0400 [thread overview]
Message-ID: <20230804203423.GC903325@mit.edu> (raw)
In-Reply-To: <20230802154131.2221419-6-hch@lst.de>
On Wed, Aug 02, 2023 at 05:41:24PM +0200, Christoph Hellwig wrote:
> Check for sb->s_type which is the right place to look at the file system
> type, not the holder, which is just an implementation detail in the VFS
> helpers.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Theodore Ts'o <tytso@mit.edu>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Ts'o" <tytso@mit.edu>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
linux-nilfs@vger.kernel.org, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org,
"Darrick J. Wong" <djwong@kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, Chris Mason <clm@fb.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Al Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org,
Ryusuke Konishi <konishi.ryusuke@gmail.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 05/12] ext4: make the IS_EXT2_SB/IS_EXT3_SB checks more robust
Date: Fri, 4 Aug 2023 16:34:23 -0400 [thread overview]
Message-ID: <20230804203423.GC903325@mit.edu> (raw)
In-Reply-To: <20230802154131.2221419-6-hch@lst.de>
On Wed, Aug 02, 2023 at 05:41:24PM +0200, Christoph Hellwig wrote:
> Check for sb->s_type which is the right place to look at the file system
> type, not the holder, which is just an implementation detail in the VFS
> helpers.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Theodore Ts'o <tytso@mit.edu>
next prev parent reply other threads:[~2023-08-04 20:35 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 15:41 more blkdev_get and holder work Christoph Hellwig
2023-08-02 15:41 ` [f2fs-dev] " Christoph Hellwig
2023-08-02 15:41 ` [PATCH 01/12] fs: export setup_bdev_super Christoph Hellwig
2023-08-02 15:41 ` Christoph Hellwig
2023-08-02 15:41 ` [f2fs-dev] " Christoph Hellwig
2023-08-03 18:04 ` Christian Brauner
2023-08-03 18:04 ` Christian Brauner
2023-08-03 18:04 ` [f2fs-dev] " Christian Brauner
2023-09-04 18:11 ` patchwork-bot+f2fs
2023-09-04 18:11 ` patchwork-bot+f2fs
2023-08-02 15:41 ` [PATCH 02/12] nilfs2: use setup_bdev_super to de-duplicate the mount code Christoph Hellwig
2023-08-02 15:41 ` [f2fs-dev] " Christoph Hellwig
2023-08-03 11:46 ` Jan Kara
2023-08-03 11:46 ` Jan Kara
2023-08-03 11:46 ` [f2fs-dev] " Jan Kara
2023-08-04 2:01 ` Ryusuke Konishi
2023-08-04 2:01 ` Ryusuke Konishi
2023-08-04 2:01 ` [f2fs-dev] " Ryusuke Konishi
2023-08-10 11:05 ` Jan Kara
2023-08-10 11:05 ` Jan Kara
2023-08-10 11:05 ` [f2fs-dev] " Jan Kara
2023-08-10 16:39 ` Ryusuke Konishi
2023-08-10 16:39 ` Ryusuke Konishi
2023-08-10 16:39 ` [f2fs-dev] " Ryusuke Konishi
2023-08-10 18:14 ` Jan Kara
2023-08-10 18:14 ` Jan Kara
2023-08-10 18:14 ` [f2fs-dev] " Jan Kara
2023-08-04 5:04 ` Ryusuke Konishi
2023-08-04 5:04 ` Ryusuke Konishi
2023-08-04 5:04 ` [f2fs-dev] " Ryusuke Konishi
2023-08-02 15:41 ` [PATCH 03/12] btrfs: always open the device read-only in btrfs_scan_one_device Christoph Hellwig
2023-08-02 15:41 ` Christoph Hellwig
2023-08-02 15:41 ` [f2fs-dev] " Christoph Hellwig
2023-08-02 15:41 ` [PATCH 04/12] btrfs: open block devices after superblock creation Christoph Hellwig
2023-08-02 15:41 ` [f2fs-dev] " Christoph Hellwig
2023-08-02 15:41 ` [PATCH 05/12] ext4: make the IS_EXT2_SB/IS_EXT3_SB checks more robust Christoph Hellwig
2023-08-02 15:41 ` [f2fs-dev] " Christoph Hellwig
2023-08-03 11:21 ` Jan Kara
2023-08-03 11:21 ` Jan Kara
2023-08-03 11:21 ` [f2fs-dev] " Jan Kara
2023-08-03 18:10 ` Christian Brauner
2023-08-03 18:10 ` Christian Brauner
2023-08-03 18:10 ` [f2fs-dev] " Christian Brauner
2023-08-04 20:34 ` Theodore Ts'o [this message]
2023-08-04 20:34 ` Theodore Ts'o
2023-08-04 20:34 ` [f2fs-dev] " Theodore Ts'o
2023-08-02 15:41 ` [PATCH 06/12] fs: use the super_block as holder when mounting file systems Christoph Hellwig
2023-08-02 15:41 ` Christoph Hellwig
2023-08-02 15:41 ` [f2fs-dev] " Christoph Hellwig
2023-08-03 11:51 ` Jan Kara
2023-08-03 11:51 ` Jan Kara
2023-08-03 11:51 ` [f2fs-dev] " Jan Kara
2023-08-03 13:33 ` Jan Kara
2023-08-03 13:33 ` Jan Kara
2023-08-03 13:33 ` [f2fs-dev] " Jan Kara
2023-08-05 8:36 ` Christoph Hellwig
2023-08-05 8:36 ` Christoph Hellwig
2023-08-05 8:36 ` [f2fs-dev] " Christoph Hellwig
2023-08-03 18:11 ` Christian Brauner
2023-08-03 18:11 ` Christian Brauner
2023-08-03 18:11 ` [f2fs-dev] " Christian Brauner
2023-08-02 15:41 ` [PATCH 07/12] fs: stop using get_super in fs_mark_dead Christoph Hellwig
2023-08-02 15:41 ` Christoph Hellwig
2023-08-02 15:41 ` [f2fs-dev] " Christoph Hellwig
2023-08-03 13:12 ` Jan Kara
2023-08-03 13:12 ` Jan Kara
2023-08-03 13:12 ` [f2fs-dev] " Jan Kara
2023-08-03 18:15 ` Christian Brauner
2023-08-03 18:15 ` [f2fs-dev] " Christian Brauner
2023-08-02 15:41 ` [PATCH 08/12] fs: export fs_holder_ops Christoph Hellwig
2023-08-02 15:41 ` Christoph Hellwig
2023-08-02 15:41 ` [f2fs-dev] " Christoph Hellwig
2023-08-03 13:16 ` Jan Kara
2023-08-03 13:16 ` Jan Kara
2023-08-03 13:16 ` [f2fs-dev] " Jan Kara
2023-08-03 18:15 ` Christian Brauner
2023-08-03 18:15 ` [f2fs-dev] " Christian Brauner
2023-08-02 15:41 ` [PATCH 09/12] ext4: drop s_umount over opening the log device Christoph Hellwig
2023-08-02 15:41 ` Christoph Hellwig
2023-08-02 15:41 ` [f2fs-dev] " Christoph Hellwig
2023-08-03 13:25 ` Jan Kara
2023-08-03 13:25 ` Jan Kara
2023-08-03 13:25 ` [f2fs-dev] " Jan Kara
2023-08-03 18:16 ` Christian Brauner
2023-08-03 18:16 ` Christian Brauner
2023-08-03 18:16 ` [f2fs-dev] " Christian Brauner
2023-08-04 20:34 ` Theodore Ts'o
2023-08-04 20:34 ` Theodore Ts'o
2023-08-04 20:34 ` [f2fs-dev] " Theodore Ts'o
2023-08-02 15:41 ` [PATCH 10/12] ext4: use fs_holder_ops for " Christoph Hellwig
2023-08-02 15:41 ` Christoph Hellwig
2023-08-02 15:41 ` [f2fs-dev] " Christoph Hellwig
2023-08-03 13:26 ` Jan Kara
2023-08-03 13:26 ` [f2fs-dev] " Jan Kara
2023-08-02 15:41 ` [PATCH 11/12] xfs: drop s_umount over opening the log and RT devices Christoph Hellwig
2023-08-02 15:41 ` Christoph Hellwig
2023-08-02 15:41 ` [f2fs-dev] " Christoph Hellwig
2023-08-02 16:32 ` Darrick J. Wong
2023-08-02 16:32 ` Darrick J. Wong
2023-08-02 16:32 ` [f2fs-dev] " Darrick J. Wong
2023-08-05 8:32 ` Christoph Hellwig
2023-08-05 8:32 ` Christoph Hellwig
2023-08-05 8:32 ` [f2fs-dev] " Christoph Hellwig
2023-08-05 10:39 ` Christian Brauner
2023-08-05 10:39 ` [f2fs-dev] " Christian Brauner
2023-08-05 16:19 ` Darrick J. Wong
2023-08-05 16:19 ` [f2fs-dev] " Darrick J. Wong
2023-08-05 17:13 ` Christian Brauner
2023-08-05 17:13 ` [f2fs-dev] " Christian Brauner
2023-08-02 15:41 ` [PATCH 12/12] xfs use fs_holder_ops for " Christoph Hellwig
2023-08-02 15:41 ` Christoph Hellwig
2023-08-02 15:41 ` [f2fs-dev] " Christoph Hellwig
2023-08-02 16:33 ` Darrick J. Wong
2023-08-02 16:33 ` [f2fs-dev] " Darrick J. Wong
2023-08-14 10:58 ` Carlos Maiolino
2023-08-14 10:58 ` Carlos Maiolino
2023-08-14 10:58 ` [f2fs-dev] " Carlos Maiolino
2023-08-14 11:05 ` Carlos Maiolino
2023-08-14 11:05 ` Carlos Maiolino
2023-08-14 11:05 ` [f2fs-dev] " Carlos Maiolino
2023-08-04 15:39 ` more blkdev_get and holder work Christian Brauner
2023-08-04 15:39 ` [f2fs-dev] " Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804203423.GC903325@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=clm@fb.com \
--cc=djwong@kernel.org \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=josef@toxicpanda.com \
--cc=konishi.ryusuke@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.