* [PATCH] wifi: rt2x00: correct MAC_SYS_CTRL register RX mask in R-Calibration
@ 2023-08-05 9:17 Shiji Yang
2023-08-05 17:39 ` Stanislaw Gruszka
2023-08-21 16:13 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Shiji Yang @ 2023-08-05 9:17 UTC (permalink / raw)
To: linux-wireless; +Cc: Kalle Valo, Stanislaw Gruszka, Helmut Schaa, Shiji Yang
For MAC_SYS_CTRL register, Bit[2] controls MAC_TX_EN and Bit[3]
controls MAC_RX_EN (Bit index starts from 0). Therefore, 0x08 is
the correct mask for RX.
Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
index ff891353c..28d7b4ea4 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
@@ -8583,7 +8583,7 @@ static void rt2800_r_calibration(struct rt2x00_dev *rt2x00dev)
rt2x00_warn(rt2x00dev, "Wait MAC Tx Status to MAX !!!\n");
maccfg = rt2800_register_read(rt2x00dev, MAC_SYS_CTRL);
- maccfg &= (~0x04);
+ maccfg &= (~0x08);
rt2800_register_write(rt2x00dev, MAC_SYS_CTRL, maccfg);
if (unlikely(rt2800_wait_bbp_rf_ready(rt2x00dev, MAC_STATUS_CFG_BBP_RF_BUSY_RX)))
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: rt2x00: correct MAC_SYS_CTRL register RX mask in R-Calibration
2023-08-05 9:17 [PATCH] wifi: rt2x00: correct MAC_SYS_CTRL register RX mask in R-Calibration Shiji Yang
@ 2023-08-05 17:39 ` Stanislaw Gruszka
2023-08-21 16:13 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Stanislaw Gruszka @ 2023-08-05 17:39 UTC (permalink / raw)
To: Shiji Yang; +Cc: linux-wireless, Kalle Valo, Helmut Schaa
On Sat, Aug 05, 2023 at 05:17:28PM +0800, Shiji Yang wrote:
> For MAC_SYS_CTRL register, Bit[2] controls MAC_TX_EN and Bit[3]
> controls MAC_RX_EN (Bit index starts from 0). Therefore, 0x08 is
> the correct mask for RX.
>
> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
> ---
> drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> index ff891353c..28d7b4ea4 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> @@ -8583,7 +8583,7 @@ static void rt2800_r_calibration(struct rt2x00_dev *rt2x00dev)
> rt2x00_warn(rt2x00dev, "Wait MAC Tx Status to MAX !!!\n");
>
> maccfg = rt2800_register_read(rt2x00dev, MAC_SYS_CTRL);
> - maccfg &= (~0x04);
> + maccfg &= (~0x08);
> rt2800_register_write(rt2x00dev, MAC_SYS_CTRL, maccfg);
>
> if (unlikely(rt2800_wait_bbp_rf_ready(rt2x00dev, MAC_STATUS_CFG_BBP_RF_BUSY_RX)))
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: rt2x00: correct MAC_SYS_CTRL register RX mask in R-Calibration
2023-08-05 9:17 [PATCH] wifi: rt2x00: correct MAC_SYS_CTRL register RX mask in R-Calibration Shiji Yang
2023-08-05 17:39 ` Stanislaw Gruszka
@ 2023-08-21 16:13 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-08-21 16:13 UTC (permalink / raw)
To: Shiji Yang; +Cc: linux-wireless, Stanislaw Gruszka, Helmut Schaa, Shiji Yang
Shiji Yang <yangshiji66@outlook.com> wrote:
> For MAC_SYS_CTRL register, Bit[2] controls MAC_TX_EN and Bit[3]
> controls MAC_RX_EN (Bit index starts from 0). Therefore, 0x08 is
> the correct mask for RX.
>
> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
> Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Patch applied to wireless-next.git, thanks.
186f2432741f wifi: rt2x00: correct MAC_SYS_CTRL register RX mask in R-Calibration
--
https://patchwork.kernel.org/project/linux-wireless/patch/TYAP286MB03150B571B67B896A504AC34BC0EA@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-21 16:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-05 9:17 [PATCH] wifi: rt2x00: correct MAC_SYS_CTRL register RX mask in R-Calibration Shiji Yang
2023-08-05 17:39 ` Stanislaw Gruszka
2023-08-21 16:13 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.