All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com,
	alexander.stein@ew.tq-group.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V5 3/9] firmware: imx: scu: drop return value check
Date: Mon, 7 Aug 2023 10:33:54 +0800	[thread overview]
Message-ID: <20230807023354.GL151430@dragon> (raw)
In-Reply-To: <20230731090449.2845997-4-peng.fan@oss.nxp.com>

On Mon, Jul 31, 2023 at 05:04:43PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> For IMX_SC_MISC_FUNC_UNIQUE_ID, the scfw has a return value,
> and the imx-scu always return 0. So drop the return value check.

imx_scu_call_rpc() could fail for a few reason.  Are we not want to
check those possible failures?

Shawn

> 
> BTW, also initialize msg to 0.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/firmware/imx/imx-scu-soc.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/firmware/imx/imx-scu-soc.c b/drivers/firmware/imx/imx-scu-soc.c
> index 2f32353de2c9..ef9103987e76 100644
> --- a/drivers/firmware/imx/imx-scu-soc.c
> +++ b/drivers/firmware/imx/imx-scu-soc.c
> @@ -33,20 +33,15 @@ struct imx_sc_msg_misc_get_soc_uid {
>  
>  static int imx_scu_soc_uid(u64 *soc_uid)
>  {
> -	struct imx_sc_msg_misc_get_soc_uid msg;
> +	struct imx_sc_msg_misc_get_soc_uid msg = { 0 };
>  	struct imx_sc_rpc_msg *hdr = &msg.hdr;
> -	int ret;
>  
>  	hdr->ver = IMX_SC_RPC_VERSION;
>  	hdr->svc = IMX_SC_RPC_SVC_MISC;
>  	hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID;
>  	hdr->size = 1;
>  
> -	ret = imx_scu_call_rpc(imx_sc_soc_ipc_handle, &msg, true);
> -	if (ret) {
> -		pr_err("%s: get soc uid failed, ret %d\n", __func__, ret);
> -		return ret;
> -	}
> +	imx_scu_call_rpc(imx_sc_soc_ipc_handle, &msg, true);
>  
>  	*soc_uid = msg.uid_high;
>  	*soc_uid <<= 32;
> -- 
> 2.37.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com,
	alexander.stein@ew.tq-group.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V5 3/9] firmware: imx: scu: drop return value check
Date: Mon, 7 Aug 2023 10:33:54 +0800	[thread overview]
Message-ID: <20230807023354.GL151430@dragon> (raw)
In-Reply-To: <20230731090449.2845997-4-peng.fan@oss.nxp.com>

On Mon, Jul 31, 2023 at 05:04:43PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> For IMX_SC_MISC_FUNC_UNIQUE_ID, the scfw has a return value,
> and the imx-scu always return 0. So drop the return value check.

imx_scu_call_rpc() could fail for a few reason.  Are we not want to
check those possible failures?

Shawn

> 
> BTW, also initialize msg to 0.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/firmware/imx/imx-scu-soc.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/firmware/imx/imx-scu-soc.c b/drivers/firmware/imx/imx-scu-soc.c
> index 2f32353de2c9..ef9103987e76 100644
> --- a/drivers/firmware/imx/imx-scu-soc.c
> +++ b/drivers/firmware/imx/imx-scu-soc.c
> @@ -33,20 +33,15 @@ struct imx_sc_msg_misc_get_soc_uid {
>  
>  static int imx_scu_soc_uid(u64 *soc_uid)
>  {
> -	struct imx_sc_msg_misc_get_soc_uid msg;
> +	struct imx_sc_msg_misc_get_soc_uid msg = { 0 };
>  	struct imx_sc_rpc_msg *hdr = &msg.hdr;
> -	int ret;
>  
>  	hdr->ver = IMX_SC_RPC_VERSION;
>  	hdr->svc = IMX_SC_RPC_SVC_MISC;
>  	hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID;
>  	hdr->size = 1;
>  
> -	ret = imx_scu_call_rpc(imx_sc_soc_ipc_handle, &msg, true);
> -	if (ret) {
> -		pr_err("%s: get soc uid failed, ret %d\n", __func__, ret);
> -		return ret;
> -	}
> +	imx_scu_call_rpc(imx_sc_soc_ipc_handle, &msg, true);
>  
>  	*soc_uid = msg.uid_high;
>  	*soc_uid <<= 32;
> -- 
> 2.37.1
> 

  reply	other threads:[~2023-08-07  2:34 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31  9:04 [PATCH V5 0/9] firmware: imx: scu/scu-irq: misc update Peng Fan (OSS)
2023-07-31  9:04 ` Peng Fan (OSS)
2023-07-31  9:04 ` [PATCH V5 1/9] firmware: imx: scu: change init level to subsys_initcall_sync Peng Fan (OSS)
2023-07-31  9:04   ` Peng Fan (OSS)
2023-07-31  9:04 ` [PATCH V5 2/9] firmware: imx: scu: increase RPC timeout Peng Fan (OSS)
2023-07-31  9:04   ` Peng Fan (OSS)
2023-08-07  2:27   ` Shawn Guo
2023-08-07  2:27     ` Shawn Guo
2023-07-31  9:04 ` [PATCH V5 3/9] firmware: imx: scu: drop return value check Peng Fan (OSS)
2023-07-31  9:04   ` Peng Fan (OSS)
2023-08-07  2:33   ` Shawn Guo [this message]
2023-08-07  2:33     ` Shawn Guo
2023-08-07  3:00     ` Peng Fan
2023-08-07  3:00       ` Peng Fan
2023-07-31  9:04 ` [PATCH V5 4/9] firmware: imx: scu: use soc name for soc_id Peng Fan (OSS)
2023-07-31  9:04   ` Peng Fan (OSS)
2023-08-07  2:51   ` Shawn Guo
2023-08-07  2:51     ` Shawn Guo
2023-07-31  9:04 ` [PATCH V5 5/9] firmware: imx: scu: use EOPNOTSUPP Peng Fan (OSS)
2023-07-31  9:04   ` Peng Fan (OSS)
2023-08-07  2:54   ` Shawn Guo
2023-08-07  2:54     ` Shawn Guo
2023-08-07  2:57     ` Peng Fan
2023-08-07  2:57       ` Peng Fan
2023-08-07  3:14       ` Shawn Guo
2023-08-07  3:14         ` Shawn Guo
2023-07-31  9:04 ` [PATCH V5 6/9] firmware: imx: scu-irq: fix RCU complains after M4 partition reset Peng Fan (OSS)
2023-07-31  9:04   ` Peng Fan (OSS)
2023-08-07  3:13   ` Shawn Guo
2023-08-07  3:13     ` Shawn Guo
2023-08-07  3:28     ` Peng Fan
2023-08-07  3:28       ` Peng Fan
2023-07-31  9:04 ` [PATCH V5 7/9] firmware: imx: scu-irq: export imx_scu_irq_get_status Peng Fan (OSS)
2023-07-31  9:04   ` Peng Fan (OSS)
2023-08-07  3:17   ` Shawn Guo
2023-08-07  3:17     ` Shawn Guo
2023-07-31  9:04 ` [PATCH V5 8/9] firmware: imx: scu-irq: enlarge the IMX_SC_IRQ_NUM_GROUP Peng Fan (OSS)
2023-07-31  9:04   ` Peng Fan (OSS)
2023-07-31  9:04 ` [PATCH V5 9/9] firmware: imx: scu-irq: support identifying SCU wakeup source from sysfs Peng Fan (OSS)
2023-07-31  9:04   ` Peng Fan (OSS)
2023-08-07  3:47   ` Shawn Guo
2023-08-07  3:47     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230807023354.GL151430@dragon \
    --to=shawnguo@kernel.org \
    --cc=aisheng.dong@nxp.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.