From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Bernd Kuhls <bernd@kuhls.net>,
Romain Naour <romain.naour@gmail.com>,
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/libheif: let's use BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730
Date: Mon, 7 Aug 2023 23:35:14 +0200 [thread overview]
Message-ID: <20230807233514.23a6f538@windsurf> (raw)
In-Reply-To: <20230806215127.283714-2-giulio.benetti@benettiengineering.com>
On Sun, 6 Aug 2023 23:51:27 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Let's use binutils bug define instead of architecture checking in packages.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/kodi-imagedecoder-heif/Config.in | 4 ++--
> package/libheif/Config.in | 4 +---
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/package/kodi-imagedecoder-heif/Config.in b/package/kodi-imagedecoder-heif/Config.in
> index 7cf2d1ef6e..d0950385a0 100644
> --- a/package/kodi-imagedecoder-heif/Config.in
> +++ b/package/kodi-imagedecoder-heif/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_KODI_IMAGEDECODER_HEIF
> bool "kodi-imagedecoder-heif"
> depends on BR2_INSTALL_LIBSTDCPP # libde265, libheif, tinyxml2
> depends on BR2_TOOLCHAIN_HAS_THREADS # libde265
> - depends on !BR2_m68k_cf # libheif
> + depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 # libheif
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # libheif
> select BR2_PACKAGE_LIBDE265
> select BR2_PACKAGE_LIBHEIF
> @@ -13,6 +13,6 @@ config BR2_PACKAGE_KODI_IMAGEDECODER_HEIF
> https://github.com/xbmc/imagedecoder.heif
>
> comment "kodi-imagedecoder-heif needs a toolchain w/ C++, threads, gcc >= 4.8"
> - depends on !BR2_m68k_cf # libheif
> + depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 # libheif
> depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
> !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> diff --git a/package/libheif/Config.in b/package/libheif/Config.in
> index d0ea72430e..1310205c41 100644
> --- a/package/libheif/Config.in
> +++ b/package/libheif/Config.in
> @@ -1,8 +1,6 @@
> config BR2_PACKAGE_LIBHEIF
> bool "libheif"
> - # avoid build error
> - # Internal error in emit_expr_encoded at dw2gencfi.c:215
> - depends on !BR2_m68k_cf
> + depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
> help
You forgot to update the Config.in comment dependency in
libheif/Config.in. Fixed that and applied to master. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-07 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-06 21:51 [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 Giulio Benetti
2023-08-06 21:51 ` [Buildroot] [PATCH 2/2] package/libheif: let's use BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 Giulio Benetti
2023-08-07 21:35 ` Thomas Petazzoni via buildroot [this message]
2023-08-07 21:34 ` [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807233514.23a6f538@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=giulio.benetti@benettiengineering.com \
--cc=romain.naour@gmail.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.