* [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730
@ 2023-08-06 21:51 Giulio Benetti
2023-08-06 21:51 ` [Buildroot] [PATCH 2/2] package/libheif: let's use BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 Giulio Benetti
2023-08-07 21:34 ` [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 Thomas Petazzoni via buildroot
0 siblings, 2 replies; 4+ messages in thread
From: Giulio Benetti @ 2023-08-06 21:51 UTC (permalink / raw)
To: buildroot
Cc: Bernd Kuhls, Romain Naour, Giulio Benetti,
Thomas De Schampheleire, Thomas Petazzoni
libheif package fails to build for the M68K architecture due to a binutils
bug that leads to:
Internal error in emit_expr_encoded at dw2gencfi.c:215
Let's add binutils bug to avoid to deal with architectures in packages
when a binutils bug arises. Let's instead deal directly with binutils
bug number.
It's been reported upstream:
https://sourceware.org/bugzilla/show_bug.cgi?id=30730
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
toolchain/Config.in | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/toolchain/Config.in b/toolchain/Config.in
index 328cd023d1..7c5b52720d 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -77,6 +77,12 @@ config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
bool
default y if BR2_nios2
+# https://sourceware.org/bugzilla/show_bug.cgi?id=30730
+# Affect toolchains built with binutils 2.40, still not fixed.
+config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730
+ bool
+ default y if BR2_m68k_cf
+
# Atomic types can be:
# - never lock-free
# - sometimes lock-free
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] package/libheif: let's use BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730
2023-08-06 21:51 [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 Giulio Benetti
@ 2023-08-06 21:51 ` Giulio Benetti
2023-08-07 21:35 ` Thomas Petazzoni via buildroot
2023-08-07 21:34 ` [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 Thomas Petazzoni via buildroot
1 sibling, 1 reply; 4+ messages in thread
From: Giulio Benetti @ 2023-08-06 21:51 UTC (permalink / raw)
To: buildroot
Cc: Bernd Kuhls, Romain Naour, Giulio Benetti,
Thomas De Schampheleire, Thomas Petazzoni
Let's use binutils bug define instead of architecture checking in packages.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/kodi-imagedecoder-heif/Config.in | 4 ++--
package/libheif/Config.in | 4 +---
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/package/kodi-imagedecoder-heif/Config.in b/package/kodi-imagedecoder-heif/Config.in
index 7cf2d1ef6e..d0950385a0 100644
--- a/package/kodi-imagedecoder-heif/Config.in
+++ b/package/kodi-imagedecoder-heif/Config.in
@@ -2,7 +2,7 @@ config BR2_PACKAGE_KODI_IMAGEDECODER_HEIF
bool "kodi-imagedecoder-heif"
depends on BR2_INSTALL_LIBSTDCPP # libde265, libheif, tinyxml2
depends on BR2_TOOLCHAIN_HAS_THREADS # libde265
- depends on !BR2_m68k_cf # libheif
+ depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 # libheif
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # libheif
select BR2_PACKAGE_LIBDE265
select BR2_PACKAGE_LIBHEIF
@@ -13,6 +13,6 @@ config BR2_PACKAGE_KODI_IMAGEDECODER_HEIF
https://github.com/xbmc/imagedecoder.heif
comment "kodi-imagedecoder-heif needs a toolchain w/ C++, threads, gcc >= 4.8"
- depends on !BR2_m68k_cf # libheif
+ depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 # libheif
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
diff --git a/package/libheif/Config.in b/package/libheif/Config.in
index d0ea72430e..1310205c41 100644
--- a/package/libheif/Config.in
+++ b/package/libheif/Config.in
@@ -1,8 +1,6 @@
config BR2_PACKAGE_LIBHEIF
bool "libheif"
- # avoid build error
- # Internal error in emit_expr_encoded at dw2gencfi.c:215
- depends on !BR2_m68k_cf
+ depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
help
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/libheif: let's use BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730
2023-08-06 21:51 ` [Buildroot] [PATCH 2/2] package/libheif: let's use BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 Giulio Benetti
@ 2023-08-07 21:35 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-07 21:35 UTC (permalink / raw)
To: Giulio Benetti
Cc: Bernd Kuhls, Romain Naour, Thomas De Schampheleire, buildroot
On Sun, 6 Aug 2023 23:51:27 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Let's use binutils bug define instead of architecture checking in packages.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/kodi-imagedecoder-heif/Config.in | 4 ++--
> package/libheif/Config.in | 4 +---
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/package/kodi-imagedecoder-heif/Config.in b/package/kodi-imagedecoder-heif/Config.in
> index 7cf2d1ef6e..d0950385a0 100644
> --- a/package/kodi-imagedecoder-heif/Config.in
> +++ b/package/kodi-imagedecoder-heif/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_KODI_IMAGEDECODER_HEIF
> bool "kodi-imagedecoder-heif"
> depends on BR2_INSTALL_LIBSTDCPP # libde265, libheif, tinyxml2
> depends on BR2_TOOLCHAIN_HAS_THREADS # libde265
> - depends on !BR2_m68k_cf # libheif
> + depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 # libheif
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # libheif
> select BR2_PACKAGE_LIBDE265
> select BR2_PACKAGE_LIBHEIF
> @@ -13,6 +13,6 @@ config BR2_PACKAGE_KODI_IMAGEDECODER_HEIF
> https://github.com/xbmc/imagedecoder.heif
>
> comment "kodi-imagedecoder-heif needs a toolchain w/ C++, threads, gcc >= 4.8"
> - depends on !BR2_m68k_cf # libheif
> + depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 # libheif
> depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
> !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> diff --git a/package/libheif/Config.in b/package/libheif/Config.in
> index d0ea72430e..1310205c41 100644
> --- a/package/libheif/Config.in
> +++ b/package/libheif/Config.in
> @@ -1,8 +1,6 @@
> config BR2_PACKAGE_LIBHEIF
> bool "libheif"
> - # avoid build error
> - # Internal error in emit_expr_encoded at dw2gencfi.c:215
> - depends on !BR2_m68k_cf
> + depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
> help
You forgot to update the Config.in comment dependency in
libheif/Config.in. Fixed that and applied to master. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730
2023-08-06 21:51 [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 Giulio Benetti
2023-08-06 21:51 ` [Buildroot] [PATCH 2/2] package/libheif: let's use BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 Giulio Benetti
@ 2023-08-07 21:34 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-07 21:34 UTC (permalink / raw)
To: Giulio Benetti
Cc: Bernd Kuhls, Romain Naour, Thomas De Schampheleire, buildroot
On Sun, 6 Aug 2023 23:51:26 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> libheif package fails to build for the M68K architecture due to a binutils
> bug that leads to:
> Internal error in emit_expr_encoded at dw2gencfi.c:215
>
> Let's add binutils bug to avoid to deal with architectures in packages
> when a binutils bug arises. Let's instead deal directly with binutils
> bug number.
>
> It's been reported upstream:
> https://sourceware.org/bugzilla/show_bug.cgi?id=30730
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> toolchain/Config.in | 6 ++++++
> 1 file changed, 6 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-07 21:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-06 21:51 [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 Giulio Benetti
2023-08-06 21:51 ` [Buildroot] [PATCH 2/2] package/libheif: let's use BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 Giulio Benetti
2023-08-07 21:35 ` Thomas Petazzoni via buildroot
2023-08-07 21:34 ` [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_30730 Thomas Petazzoni via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
