From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: Jiri Pirko <jiri@resnulli.us>,
Bart Van Assche <bvanassche@acm.org>,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-arm-kernel@lists.infradead.org,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Simon Horman <simon.horman@corigine.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-clk@vger.kernel.org, Milena Olech <milena.olech@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 2/9] dpll: spec: Add Netlink spec in YAML
Date: Tue, 8 Aug 2023 13:03:27 -0700 [thread overview]
Message-ID: <20230808130327.5638d15b@kernel.org> (raw)
In-Reply-To: <a7e2f7e1-e36a-2c79-46c3-874550d24575@linux.dev>
On Mon, 7 Aug 2023 22:25:25 +0100 Vadim Fedorenko wrote:
> Well, in my case after rebasing on latest net-next I got just part of
> your diff:
>
> diff --git a/drivers/dpll/dpll_nl.c b/drivers/dpll/dpll_nl.c
> index ff3f55f0ca94..638e21a9a06d 100644
> --- a/drivers/dpll/dpll_nl.c
> +++ b/drivers/dpll/dpll_nl.c
> @@ -17,7 +17,6 @@ const struct nla_policy
> dpll_pin_parent_device_nl_policy[DPLL_A_PIN_STATE + 1] =
> [DPLL_A_PIN_PRIO] = { .type = NLA_U32, },
> [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3),
> };
> -
Uh, missing cw.nl() somewhere. Will add.
> const struct nla_policy dpll_pin_parent_pin_nl_policy[DPLL_A_PIN_STATE
> + 1] = {
> [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3),
> [DPLL_A_PIN_ID] = { .type = NLA_U32, },
>
>
> The "/* private: */" comment was added to the generator after Simon's
> comment. But I'll include this part into the next version.
We only added private for enum masks, I'll send a patch for nlattrs.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: Jiri Pirko <jiri@resnulli.us>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Milena Olech <milena.olech@intel.com>,
Michal Michalik <michal.michalik@intel.com>,
linux-arm-kernel@lists.infradead.org, poros@redhat.com,
mschmidt@redhat.com, netdev@vger.kernel.org,
linux-clk@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
intel-wired-lan@lists.osuosl.org,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH net-next v2 2/9] dpll: spec: Add Netlink spec in YAML
Date: Tue, 8 Aug 2023 13:03:27 -0700 [thread overview]
Message-ID: <20230808130327.5638d15b@kernel.org> (raw)
In-Reply-To: <a7e2f7e1-e36a-2c79-46c3-874550d24575@linux.dev>
On Mon, 7 Aug 2023 22:25:25 +0100 Vadim Fedorenko wrote:
> Well, in my case after rebasing on latest net-next I got just part of
> your diff:
>
> diff --git a/drivers/dpll/dpll_nl.c b/drivers/dpll/dpll_nl.c
> index ff3f55f0ca94..638e21a9a06d 100644
> --- a/drivers/dpll/dpll_nl.c
> +++ b/drivers/dpll/dpll_nl.c
> @@ -17,7 +17,6 @@ const struct nla_policy
> dpll_pin_parent_device_nl_policy[DPLL_A_PIN_STATE + 1] =
> [DPLL_A_PIN_PRIO] = { .type = NLA_U32, },
> [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3),
> };
> -
Uh, missing cw.nl() somewhere. Will add.
> const struct nla_policy dpll_pin_parent_pin_nl_policy[DPLL_A_PIN_STATE
> + 1] = {
> [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3),
> [DPLL_A_PIN_ID] = { .type = NLA_U32, },
>
>
> The "/* private: */" comment was added to the generator after Simon's
> comment. But I'll include this part into the next version.
We only added private for enum masks, I'll send a patch for nlattrs.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: Jiri Pirko <jiri@resnulli.us>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Milena Olech <milena.olech@intel.com>,
Michal Michalik <michal.michalik@intel.com>,
linux-arm-kernel@lists.infradead.org, poros@redhat.com,
mschmidt@redhat.com, netdev@vger.kernel.org,
linux-clk@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
intel-wired-lan@lists.osuosl.org,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH net-next v2 2/9] dpll: spec: Add Netlink spec in YAML
Date: Tue, 8 Aug 2023 13:03:27 -0700 [thread overview]
Message-ID: <20230808130327.5638d15b@kernel.org> (raw)
In-Reply-To: <a7e2f7e1-e36a-2c79-46c3-874550d24575@linux.dev>
On Mon, 7 Aug 2023 22:25:25 +0100 Vadim Fedorenko wrote:
> Well, in my case after rebasing on latest net-next I got just part of
> your diff:
>
> diff --git a/drivers/dpll/dpll_nl.c b/drivers/dpll/dpll_nl.c
> index ff3f55f0ca94..638e21a9a06d 100644
> --- a/drivers/dpll/dpll_nl.c
> +++ b/drivers/dpll/dpll_nl.c
> @@ -17,7 +17,6 @@ const struct nla_policy
> dpll_pin_parent_device_nl_policy[DPLL_A_PIN_STATE + 1] =
> [DPLL_A_PIN_PRIO] = { .type = NLA_U32, },
> [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3),
> };
> -
Uh, missing cw.nl() somewhere. Will add.
> const struct nla_policy dpll_pin_parent_pin_nl_policy[DPLL_A_PIN_STATE
> + 1] = {
> [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3),
> [DPLL_A_PIN_ID] = { .type = NLA_U32, },
>
>
> The "/* private: */" comment was added to the generator after Simon's
> comment. But I'll include this part into the next version.
We only added private for enum masks, I'll send a patch for nlattrs.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-08 20:03 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 19:04 [Intel-wired-lan] [PATCH net-next v2 0/9] Create common DPLL configuration API Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-04 19:04 ` [Intel-wired-lan] [PATCH net-next v2 1/9] dpll: documentation on DPLL subsystem interface Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-04 19:04 ` [Intel-wired-lan] [PATCH net-next v2 2/9] dpll: spec: Add Netlink spec in YAML Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-07 7:56 ` [Intel-wired-lan] " Jiri Pirko
2023-08-07 7:56 ` Jiri Pirko
2023-08-07 7:56 ` Jiri Pirko
2023-08-07 21:25 ` [Intel-wired-lan] " Vadim Fedorenko
2023-08-07 21:25 ` Vadim Fedorenko
2023-08-07 21:25 ` Vadim Fedorenko
2023-08-08 20:03 ` Jakub Kicinski [this message]
2023-08-08 20:03 ` Jakub Kicinski
2023-08-08 20:03 ` Jakub Kicinski
2023-08-08 20:06 ` [Intel-wired-lan] " Jakub Kicinski
2023-08-08 20:06 ` Jakub Kicinski
2023-08-08 20:06 ` Jakub Kicinski
2023-08-08 20:51 ` [Intel-wired-lan] " Vadim Fedorenko
2023-08-08 20:51 ` Vadim Fedorenko
2023-08-08 20:51 ` Vadim Fedorenko
2023-08-04 19:04 ` [Intel-wired-lan] [PATCH net-next v2 3/9] dpll: core: Add DPLL framework base functions Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-07 8:13 ` [Intel-wired-lan] " Jiri Pirko
2023-08-07 8:13 ` Jiri Pirko
2023-08-07 8:13 ` Jiri Pirko
2023-08-04 19:04 ` [Intel-wired-lan] [PATCH net-next v2 4/9] dpll: netlink: " Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-07 8:11 ` [Intel-wired-lan] " Jiri Pirko
2023-08-07 8:11 ` Jiri Pirko
2023-08-07 8:11 ` Jiri Pirko
2023-08-04 19:04 ` [Intel-wired-lan] [PATCH net-next v2 5/9] netdev: expose DPLL pin handle for netdevice Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-04 19:04 ` [Intel-wired-lan] [PATCH net-next v2 6/9] ice: add admin commands to access cgu configuration Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-06 17:31 ` [Intel-wired-lan] " Simon Horman
2023-08-06 17:31 ` Simon Horman
2023-08-06 17:31 ` Simon Horman
2023-08-07 23:08 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-08-07 23:08 ` Kubalewski, Arkadiusz
2023-08-07 23:08 ` Kubalewski, Arkadiusz
2023-08-04 19:04 ` [Intel-wired-lan] [PATCH net-next v2 7/9] ice: implement dpll interface to control cgu Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-07 7:07 ` [Intel-wired-lan] " Jiri Pirko
2023-08-07 7:07 ` Jiri Pirko
2023-08-07 7:07 ` Jiri Pirko
2023-08-07 23:06 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-08-07 23:06 ` Kubalewski, Arkadiusz
2023-08-07 23:06 ` Kubalewski, Arkadiusz
2023-08-04 19:04 ` [Intel-wired-lan] [PATCH net-next v2 8/9] ptp_ocp: implement DPLL ops Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-06 17:13 ` [Intel-wired-lan] " Simon Horman
2023-08-06 17:13 ` Simon Horman
2023-08-06 17:13 ` Simon Horman
2023-08-07 21:42 ` [Intel-wired-lan] " Vadim Fedorenko
2023-08-07 21:42 ` Vadim Fedorenko
2023-08-07 21:42 ` Vadim Fedorenko
2023-08-04 19:04 ` [Intel-wired-lan] [PATCH net-next v2 9/9] mlx5: Implement SyncE support using DPLL infrastructure Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
2023-08-04 19:04 ` Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808130327.5638d15b@kernel.org \
--to=kuba@kernel.org \
--cc=bvanassche@acm.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=jonathan.lemon@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=milena.olech@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.