From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Luke Lu <luke.lu@libre.computer>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Da Xue <da@libre.computer>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: meson-g12a: do post init to fix broken usb after resumption
Date: Tue, 8 Aug 2023 10:17:08 +0200 [thread overview]
Message-ID: <2023080852-estranged-limpness-aafb@gregkh> (raw)
In-Reply-To: <CAAzmgs5U=BNzNNeskUMe_YEken1-CmzssRFPDCmsmar9SQo+WQ@mail.gmail.com>
On Tue, Aug 08, 2023 at 06:09:45AM +0000, Luke Lu wrote:
> HI Greg:
>
> On Tue, Aug 8, 2023 at 4:56 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Aug 08, 2023 at 03:25:10AM +0000, Luke Lu wrote:
> > > Device connected to usb otg port of GXL-based boards can not be
> > > recognised after resumption, doesn't recover even if disconnect and
> > > reconnect the device. dmesg shows it disconnects during resumption.
> > >
> > > [ 41.492911] usb 1-2: USB disconnect, device number 3
> > > [ 41.499346] usb 1-2: unregistering device
> > > [ 41.511939] usb 1-2: unregistering interface 1-2:1.0
> > >
> > > Calling usb_post_init() will fix this issue, and it's tested and
> > > verified on libretech's aml-s905x-cc board.
> > >
> > > Signed-off-by: Luke Lu <luke.lu@libre.computer>
> >
> > What commit id does this fix?
> Using "git blame" to explore the history, found dwc3_meson_g12a_resume() was
> introduced along with the file of drivers/usb/dwc3/dwc3-meson-g12a.c.
> as Da Xue pointed out, the suspend/resume was never tested in GXL based SoC,
> so it's broken since the beginning..
>
> For the Fixes tag, I think it's proper to use "5b0ba0caaf3a: (usb:
> dwc3: meson-g12a: refactor usb init)"
> since the usb_post_init() function was introduced in this commit and
> this patch will depend on it.
>
> > Should it also go to stable kernels?
> >
> Yes, It would be great if the patch can go to stable tree, thanks for
> suggesting this
> I have it tested on 6.1-lts tree.
>
> Btw, I would wait for a few days for more comments and CC to stable in
> next v2 if no objection.
No worries, I'll drop this from my review queue and wait for a v2.
thanks,
greg k-h
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Luke Lu <luke.lu@libre.computer>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Da Xue <da@libre.computer>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: meson-g12a: do post init to fix broken usb after resumption
Date: Tue, 8 Aug 2023 10:17:08 +0200 [thread overview]
Message-ID: <2023080852-estranged-limpness-aafb@gregkh> (raw)
In-Reply-To: <CAAzmgs5U=BNzNNeskUMe_YEken1-CmzssRFPDCmsmar9SQo+WQ@mail.gmail.com>
On Tue, Aug 08, 2023 at 06:09:45AM +0000, Luke Lu wrote:
> HI Greg:
>
> On Tue, Aug 8, 2023 at 4:56 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Aug 08, 2023 at 03:25:10AM +0000, Luke Lu wrote:
> > > Device connected to usb otg port of GXL-based boards can not be
> > > recognised after resumption, doesn't recover even if disconnect and
> > > reconnect the device. dmesg shows it disconnects during resumption.
> > >
> > > [ 41.492911] usb 1-2: USB disconnect, device number 3
> > > [ 41.499346] usb 1-2: unregistering device
> > > [ 41.511939] usb 1-2: unregistering interface 1-2:1.0
> > >
> > > Calling usb_post_init() will fix this issue, and it's tested and
> > > verified on libretech's aml-s905x-cc board.
> > >
> > > Signed-off-by: Luke Lu <luke.lu@libre.computer>
> >
> > What commit id does this fix?
> Using "git blame" to explore the history, found dwc3_meson_g12a_resume() was
> introduced along with the file of drivers/usb/dwc3/dwc3-meson-g12a.c.
> as Da Xue pointed out, the suspend/resume was never tested in GXL based SoC,
> so it's broken since the beginning..
>
> For the Fixes tag, I think it's proper to use "5b0ba0caaf3a: (usb:
> dwc3: meson-g12a: refactor usb init)"
> since the usb_post_init() function was introduced in this commit and
> this patch will depend on it.
>
> > Should it also go to stable kernels?
> >
> Yes, It would be great if the patch can go to stable tree, thanks for
> suggesting this
> I have it tested on 6.1-lts tree.
>
> Btw, I would wait for a few days for more comments and CC to stable in
> next v2 if no objection.
No worries, I'll drop this from my review queue and wait for a v2.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Luke Lu <luke.lu@libre.computer>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Da Xue <da@libre.computer>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: meson-g12a: do post init to fix broken usb after resumption
Date: Tue, 8 Aug 2023 10:17:08 +0200 [thread overview]
Message-ID: <2023080852-estranged-limpness-aafb@gregkh> (raw)
In-Reply-To: <CAAzmgs5U=BNzNNeskUMe_YEken1-CmzssRFPDCmsmar9SQo+WQ@mail.gmail.com>
On Tue, Aug 08, 2023 at 06:09:45AM +0000, Luke Lu wrote:
> HI Greg:
>
> On Tue, Aug 8, 2023 at 4:56 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Aug 08, 2023 at 03:25:10AM +0000, Luke Lu wrote:
> > > Device connected to usb otg port of GXL-based boards can not be
> > > recognised after resumption, doesn't recover even if disconnect and
> > > reconnect the device. dmesg shows it disconnects during resumption.
> > >
> > > [ 41.492911] usb 1-2: USB disconnect, device number 3
> > > [ 41.499346] usb 1-2: unregistering device
> > > [ 41.511939] usb 1-2: unregistering interface 1-2:1.0
> > >
> > > Calling usb_post_init() will fix this issue, and it's tested and
> > > verified on libretech's aml-s905x-cc board.
> > >
> > > Signed-off-by: Luke Lu <luke.lu@libre.computer>
> >
> > What commit id does this fix?
> Using "git blame" to explore the history, found dwc3_meson_g12a_resume() was
> introduced along with the file of drivers/usb/dwc3/dwc3-meson-g12a.c.
> as Da Xue pointed out, the suspend/resume was never tested in GXL based SoC,
> so it's broken since the beginning..
>
> For the Fixes tag, I think it's proper to use "5b0ba0caaf3a: (usb:
> dwc3: meson-g12a: refactor usb init)"
> since the usb_post_init() function was introduced in this commit and
> this patch will depend on it.
>
> > Should it also go to stable kernels?
> >
> Yes, It would be great if the patch can go to stable tree, thanks for
> suggesting this
> I have it tested on 6.1-lts tree.
>
> Btw, I would wait for a few days for more comments and CC to stable in
> next v2 if no objection.
No worries, I'll drop this from my review queue and wait for a v2.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-08 8:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 3:25 [PATCH] usb: dwc3: meson-g12a: do post init to fix broken usb after resumption Luke Lu
2023-08-08 3:25 ` Luke Lu
2023-08-08 3:25 ` Luke Lu
2023-08-08 4:56 ` Greg Kroah-Hartman
2023-08-08 4:56 ` Greg Kroah-Hartman
2023-08-08 4:56 ` Greg Kroah-Hartman
2023-08-08 5:33 ` Da Xue
2023-08-08 5:33 ` Da Xue
2023-08-08 5:33 ` Da Xue
2023-08-08 6:10 ` Greg Kroah-Hartman
2023-08-08 6:10 ` Greg Kroah-Hartman
2023-08-08 6:10 ` Greg Kroah-Hartman
2023-08-08 6:09 ` Luke Lu
2023-08-08 6:09 ` Luke Lu
2023-08-08 6:09 ` Luke Lu
2023-08-08 8:17 ` Greg Kroah-Hartman [this message]
2023-08-08 8:17 ` Greg Kroah-Hartman
2023-08-08 8:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023080852-estranged-limpness-aafb@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=da@libre.computer \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luke.lu@libre.computer \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.