[linux-next:master 8194/8441] drivers/block/ublk_drv.c:445 ublk_setup_iod_zoned() warn: signedness bug returning '(-95)'

[linux-next:master 8194/8441] drivers/block/ublk_drv.c:445 ublk_setup_iod_zoned() warn: signedness bug returning '(-95)'

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Andreas Hindborg <a.hindborg@samsung.com>
CC: Jens Axboe <axboe@kernel.dk>
CC: Ming Lei <ming.lei@redhat.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   21ef7b1e17d039053edaeaf41142423810572741
commit: 29802d7ca33bc0a75c9da2a143eeed4f9e99fca4 [8194/8441] ublk: enable zoned storage support
:::::: branch date: 12 hours ago
:::::: commit date: 20 hours ago
config: s390-randconfig-m041-20230809 (https://download.01.org/0day-ci/archive/20230810/202308100201.TCRhgdvN-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230810/202308100201.TCRhgdvN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202308100201.TCRhgdvN-lkp@intel.com/

New smatch warnings:
drivers/block/ublk_drv.c:445 ublk_setup_iod_zoned() warn: signedness bug returning '(-95)'

Old smatch warnings:
drivers/block/ublk_drv.c:963 ublk_setup_iod() warn: signedness bug returning '(-5)'
drivers/block/ublk_drv.c:1404 ublk_commit_completion() warn: variable dereferenced before check 'req' (see line 1401)

vim +445 drivers/block/ublk_drv.c

29802d7ca33bc0 Andreas Hindborg 2023-08-04  441  
29802d7ca33bc0 Andreas Hindborg 2023-08-04  442  static blk_status_t ublk_setup_iod_zoned(struct ublk_queue *ubq,
29802d7ca33bc0 Andreas Hindborg 2023-08-04  443  					 struct request *req)
29802d7ca33bc0 Andreas Hindborg 2023-08-04  444  {
29802d7ca33bc0 Andreas Hindborg 2023-08-04 @445  	return -EOPNOTSUPP;
29802d7ca33bc0 Andreas Hindborg 2023-08-04  446  }
29802d7ca33bc0 Andreas Hindborg 2023-08-04  447  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[linux-next:master 8194/8441] drivers/block/ublk_drv.c:445 ublk_setup_iod_zoned() warn: signedness bug returning '(-95)'

[Dan Carpenter]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   21ef7b1e17d039053edaeaf41142423810572741
commit: 29802d7ca33bc0a75c9da2a143eeed4f9e99fca4 [8194/8441] ublk: enable zoned storage support
config: s390-randconfig-m041-20230809 (https://download.01.org/0day-ci/archive/20230810/202308100201.TCRhgdvN-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230810/202308100201.TCRhgdvN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202308100201.TCRhgdvN-lkp@intel.com/

New smatch warnings:
drivers/block/ublk_drv.c:445 ublk_setup_iod_zoned() warn: signedness bug returning '(-95)'

Old smatch warnings:
drivers/block/ublk_drv.c:963 ublk_setup_iod() warn: signedness bug returning '(-5)'
drivers/block/ublk_drv.c:1404 ublk_commit_completion() warn: variable dereferenced before check 'req' (see line 1401)

vim +445 drivers/block/ublk_drv.c

29802d7ca33bc0 Andreas Hindborg 2023-08-04  442  static blk_status_t ublk_setup_iod_zoned(struct ublk_queue *ubq,
29802d7ca33bc0 Andreas Hindborg 2023-08-04  443  					 struct request *req)
29802d7ca33bc0 Andreas Hindborg 2023-08-04  444  {
29802d7ca33bc0 Andreas Hindborg 2023-08-04 @445  	return -EOPNOTSUPP;

blk_status_t can either be a u32 or a u8 but for this warning to trigger
it must be a u8 in this case.

29802d7ca33bc0 Andreas Hindborg 2023-08-04  446  }

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki