From: Rob Herring <robh@kernel.org>
To: Aleksandr Shubin <privatesub2@gmail.com>
Cc: "Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Heiko Stuebner" <heiko.stuebner@vrull.eu>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-riscv@lists.infradead.org,
"Thierry Reding" <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, "Chen-Yu Tsai" <wens@csie.org>,
devicetree@vger.kernel.org,
"Paul Walmsley" <paul.walmsley@sifive.com>,
linux-arm-kernel@lists.infradead.org,
"Albert Ou" <aou@eecs.berkeley.edu>,
linux-sunxi@lists.linux.dev,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
linux-kernel@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v4 1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller
Date: Thu, 10 Aug 2023 15:20:54 -0600 [thread overview]
Message-ID: <20230810212054.GA1207489-robh@kernel.org> (raw)
In-Reply-To: <169168449014.480213.11243622755862466051.robh@kernel.org>
On Thu, Aug 10, 2023 at 10:21:30AM -0600, Rob Herring wrote:
>
> On Thu, 10 Aug 2023 17:54:26 +0300, Aleksandr Shubin wrote:
> > Allwinner's D1, T113-S3 and R329 SoCs have a new pwm
> > controller witch is different from the previous pwm-sun4i.
> >
> > The D1 and T113 are identical in terms of peripherals,
> > they differ only in the architecture of the CPU core, and
> > even share the majority of their DT. Because of that,
> > using the same compatible makes sense.
> > The R329 is a different SoC though, and should have
> > a different compatible string added, especially as there
> > is a difference in the number of channels.
> >
> > D1 and T113s SoCs have one PWM controller with 8 channels.
> > R329 SoC has two PWM controllers in both power domains, one of
> > them has 9 channels (CPUX one) and the other has 6 (CPUS one).
> >
> > Add a device tree binding for them.
> >
> > Signed-off-by: Aleksandr Shubin <privatesub2@gmail.com>
> > ---
> > .../bindings/pwm/allwinner,sun20i-pwm.yaml | 86 +++++++++++++++++++
> > 1 file changed, 86 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/pwm/allwinner,sun20i-pwm.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
>
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230810145443.1053387-2-privatesub2@gmail.com
The bot was having an issue. This can be ignored.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Aleksandr Shubin <privatesub2@gmail.com>
Cc: linux-pwm@vger.kernel.org, "Conor Dooley" <conor+dt@kernel.org>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Samuel Holland" <samuel@sholland.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-kernel@vger.kernel.org,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
linux-arm-kernel@lists.infradead.org,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org,
"Heiko Stuebner" <heiko.stuebner@vrull.eu>,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller
Date: Thu, 10 Aug 2023 15:20:54 -0600 [thread overview]
Message-ID: <20230810212054.GA1207489-robh@kernel.org> (raw)
In-Reply-To: <169168449014.480213.11243622755862466051.robh@kernel.org>
On Thu, Aug 10, 2023 at 10:21:30AM -0600, Rob Herring wrote:
>
> On Thu, 10 Aug 2023 17:54:26 +0300, Aleksandr Shubin wrote:
> > Allwinner's D1, T113-S3 and R329 SoCs have a new pwm
> > controller witch is different from the previous pwm-sun4i.
> >
> > The D1 and T113 are identical in terms of peripherals,
> > they differ only in the architecture of the CPU core, and
> > even share the majority of their DT. Because of that,
> > using the same compatible makes sense.
> > The R329 is a different SoC though, and should have
> > a different compatible string added, especially as there
> > is a difference in the number of channels.
> >
> > D1 and T113s SoCs have one PWM controller with 8 channels.
> > R329 SoC has two PWM controllers in both power domains, one of
> > them has 9 channels (CPUX one) and the other has 6 (CPUS one).
> >
> > Add a device tree binding for them.
> >
> > Signed-off-by: Aleksandr Shubin <privatesub2@gmail.com>
> > ---
> > .../bindings/pwm/allwinner,sun20i-pwm.yaml | 86 +++++++++++++++++++
> > 1 file changed, 86 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/pwm/allwinner,sun20i-pwm.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
>
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230810145443.1053387-2-privatesub2@gmail.com
The bot was having an issue. This can be ignored.
Rob
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Aleksandr Shubin <privatesub2@gmail.com>
Cc: "Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Heiko Stuebner" <heiko.stuebner@vrull.eu>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-riscv@lists.infradead.org,
"Thierry Reding" <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, "Chen-Yu Tsai" <wens@csie.org>,
devicetree@vger.kernel.org,
"Paul Walmsley" <paul.walmsley@sifive.com>,
linux-arm-kernel@lists.infradead.org,
"Albert Ou" <aou@eecs.berkeley.edu>,
linux-sunxi@lists.linux.dev,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
linux-kernel@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v4 1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller
Date: Thu, 10 Aug 2023 15:20:54 -0600 [thread overview]
Message-ID: <20230810212054.GA1207489-robh@kernel.org> (raw)
In-Reply-To: <169168449014.480213.11243622755862466051.robh@kernel.org>
On Thu, Aug 10, 2023 at 10:21:30AM -0600, Rob Herring wrote:
>
> On Thu, 10 Aug 2023 17:54:26 +0300, Aleksandr Shubin wrote:
> > Allwinner's D1, T113-S3 and R329 SoCs have a new pwm
> > controller witch is different from the previous pwm-sun4i.
> >
> > The D1 and T113 are identical in terms of peripherals,
> > they differ only in the architecture of the CPU core, and
> > even share the majority of their DT. Because of that,
> > using the same compatible makes sense.
> > The R329 is a different SoC though, and should have
> > a different compatible string added, especially as there
> > is a difference in the number of channels.
> >
> > D1 and T113s SoCs have one PWM controller with 8 channels.
> > R329 SoC has two PWM controllers in both power domains, one of
> > them has 9 channels (CPUX one) and the other has 6 (CPUS one).
> >
> > Add a device tree binding for them.
> >
> > Signed-off-by: Aleksandr Shubin <privatesub2@gmail.com>
> > ---
> > .../bindings/pwm/allwinner,sun20i-pwm.yaml | 86 +++++++++++++++++++
> > 1 file changed, 86 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/pwm/allwinner,sun20i-pwm.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
>
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230810145443.1053387-2-privatesub2@gmail.com
The bot was having an issue. This can be ignored.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-10 21:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 14:54 [PATCH v4 0/3] Add support for Allwinner PWM on D1/T113s/R329 SoCs Aleksandr Shubin
2023-08-10 14:54 ` Aleksandr Shubin
2023-08-10 14:54 ` Aleksandr Shubin
2023-08-10 14:54 ` [PATCH v4 1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller Aleksandr Shubin
2023-08-10 14:54 ` Aleksandr Shubin
2023-08-10 14:54 ` Aleksandr Shubin
2023-08-10 16:12 ` Conor Dooley
2023-08-10 16:12 ` Conor Dooley
2023-08-10 16:12 ` Conor Dooley
2023-08-10 16:21 ` Rob Herring
2023-08-10 16:21 ` Rob Herring
2023-08-10 16:21 ` Rob Herring
2023-08-10 21:20 ` Rob Herring [this message]
2023-08-10 21:20 ` Rob Herring
2023-08-10 21:20 ` Rob Herring
2023-08-10 14:54 ` [PATCH v4 2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support Aleksandr Shubin
2023-08-10 14:54 ` Aleksandr Shubin
2023-08-10 14:54 ` Aleksandr Shubin
2023-08-12 14:46 ` kernel test robot
2023-08-12 14:46 ` kernel test robot
2023-08-12 14:46 ` kernel test robot
2023-08-10 14:54 ` [PATCH v4 3/3] riscv: dts: allwinner: d1: Add pwm node Aleksandr Shubin
2023-08-10 14:54 ` Aleksandr Shubin
2023-08-10 14:54 ` Aleksandr Shubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810212054.GA1207489-robh@kernel.org \
--to=robh@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko.stuebner@vrull.eu \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=privatesub2@gmail.com \
--cc=samuel@sholland.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.