All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriel Krisman Bertazi <krisman@suse.de>
To: viro@zeniv.linux.org.uk, brauner@kernel.org, tytso@mit.edu,
	ebiggers@kernel.org, jaegeuk@kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	Gabriel Krisman Bertazi <krisman@suse.de>
Subject: [PATCH v5 02/10] ecryptfs: Reject casefold directory inodes
Date: Fri, 11 Aug 2023 20:41:38 -0400	[thread overview]
Message-ID: <20230812004146.30980-3-krisman@suse.de> (raw)
In-Reply-To: <20230812004146.30980-1-krisman@suse.de>

Even though it seems to be able to resolve some names of
case-insensitive directories, the lack of d_hash and d_compare means we
end up with a broken state in the d_cache.  Considering it was never a
goal to support these two together, and we are preparing to use
d_revalidate in case-insensitive filesystems, which would make the
combination even more broken, reject any attempt to get a casefolded
inode from ecryptfs.

Signed-off-by: Gabriel Krisman Bertazi <krisman@suse.de>
---
 fs/ecryptfs/inode.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
index 83274915ba6d..1305dc49df78 100644
--- a/fs/ecryptfs/inode.c
+++ b/fs/ecryptfs/inode.c
@@ -78,6 +78,14 @@ static struct inode *__ecryptfs_get_inode(struct inode *lower_inode,
 
 	if (lower_inode->i_sb != ecryptfs_superblock_to_lower(sb))
 		return ERR_PTR(-EXDEV);
+
+	/* Reject dealing with casefold directories. */
+	if (S_ISDIR(lower_inode->i_mode) && dir_is_casefolded(lower_inode)) {
+		pr_err_ratelimited("%s: Can't handle casefolded directory.\n",
+				   __func__);
+		return ERR_PTR(-EREMOTE);
+	}
+
 	if (!igrab(lower_inode))
 		return ERR_PTR(-ESTALE);
 	inode = iget5_locked(sb, (unsigned long)lower_inode,
-- 
2.41.0


WARNING: multiple messages have this Message-ID (diff)
From: Gabriel Krisman Bertazi <krisman@suse.de>
To: viro@zeniv.linux.org.uk, brauner@kernel.org, tytso@mit.edu,
	ebiggers@kernel.org, jaegeuk@kernel.org
Cc: linux-fsdevel@vger.kernel.org,
	Gabriel Krisman Bertazi <krisman@suse.de>,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH v5 02/10] ecryptfs: Reject casefold directory inodes
Date: Fri, 11 Aug 2023 20:41:38 -0400	[thread overview]
Message-ID: <20230812004146.30980-3-krisman@suse.de> (raw)
In-Reply-To: <20230812004146.30980-1-krisman@suse.de>

Even though it seems to be able to resolve some names of
case-insensitive directories, the lack of d_hash and d_compare means we
end up with a broken state in the d_cache.  Considering it was never a
goal to support these two together, and we are preparing to use
d_revalidate in case-insensitive filesystems, which would make the
combination even more broken, reject any attempt to get a casefolded
inode from ecryptfs.

Signed-off-by: Gabriel Krisman Bertazi <krisman@suse.de>
---
 fs/ecryptfs/inode.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
index 83274915ba6d..1305dc49df78 100644
--- a/fs/ecryptfs/inode.c
+++ b/fs/ecryptfs/inode.c
@@ -78,6 +78,14 @@ static struct inode *__ecryptfs_get_inode(struct inode *lower_inode,
 
 	if (lower_inode->i_sb != ecryptfs_superblock_to_lower(sb))
 		return ERR_PTR(-EXDEV);
+
+	/* Reject dealing with casefold directories. */
+	if (S_ISDIR(lower_inode->i_mode) && dir_is_casefolded(lower_inode)) {
+		pr_err_ratelimited("%s: Can't handle casefolded directory.\n",
+				   __func__);
+		return ERR_PTR(-EREMOTE);
+	}
+
 	if (!igrab(lower_inode))
 		return ERR_PTR(-ESTALE);
 	inode = iget5_locked(sb, (unsigned long)lower_inode,
-- 
2.41.0



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2023-08-12  0:42 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-12  0:41 [PATCH v5 00/10] Support negative dentries on case-insensitive ext4 and f2fs Gabriel Krisman Bertazi
2023-08-12  0:41 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-12  0:41 ` [PATCH v5 01/10] fs: Expose helper to check if a directory needs casefolding Gabriel Krisman Bertazi
2023-08-12  0:41   ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-12  1:59   ` Eric Biggers
2023-08-12  1:59     ` [f2fs-dev] " Eric Biggers
2023-08-12 23:06     ` Theodore Ts'o
2023-08-12 23:06       ` [f2fs-dev] " Theodore Ts'o
2023-08-13  0:12       ` Eric Biggers
2023-08-13  0:12         ` [f2fs-dev] " Eric Biggers
2023-08-13  3:08       ` Matthew Wilcox
2023-08-13  3:08         ` [f2fs-dev] " Matthew Wilcox
2023-08-13  4:30         ` Eric Biggers
2023-08-13  4:30           ` [f2fs-dev] " Eric Biggers
2023-08-14 11:38           ` Theodore Ts'o
2023-08-14 11:38             ` [f2fs-dev] " Theodore Ts'o
2023-08-14 17:22             ` Eric Biggers
2023-08-14 17:22               ` [f2fs-dev] " Eric Biggers
2023-08-15  3:59               ` Theodore Ts'o
2023-08-15  3:59                 ` [f2fs-dev] " Theodore Ts'o
2023-08-14 15:02     ` Gabriel Krisman Bertazi
2023-08-14 15:02       ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-14 19:14       ` Eric Biggers
2023-08-14 19:14         ` [f2fs-dev] " Eric Biggers
2023-08-14 19:26         ` Gabriel Krisman Bertazi
2023-08-14 19:26           ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-12  0:41 ` Gabriel Krisman Bertazi [this message]
2023-08-12  0:41   ` [f2fs-dev] [PATCH v5 02/10] ecryptfs: Reject casefold directory inodes Gabriel Krisman Bertazi
2023-08-12  0:41 ` [PATCH v5 03/10] 9p: Split ->weak_revalidate from ->revalidate Gabriel Krisman Bertazi
2023-08-12  0:41   ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-12  0:41 ` [PATCH v5 04/10] fs: Expose name under lookup to d_revalidate hooks Gabriel Krisman Bertazi
2023-08-12  0:41   ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-12  2:15   ` Eric Biggers
2023-08-12  2:15     ` [f2fs-dev] " Eric Biggers
2023-08-17  7:00   ` kernel test robot
2023-08-17  7:00     ` [f2fs-dev] " kernel test robot
2023-08-17  9:12   ` kernel test robot
2023-08-17  9:12     ` [f2fs-dev] " kernel test robot
2023-08-12  0:41 ` [PATCH v5 05/10] fs: Add DCACHE_CASEFOLDED_NAME flag Gabriel Krisman Bertazi
2023-08-12  0:41   ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-12  2:17   ` Eric Biggers
2023-08-12  2:17     ` [f2fs-dev] " Eric Biggers
2023-08-14 15:03     ` Gabriel Krisman Bertazi
2023-08-14 15:03       ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-12  9:33   ` kernel test robot
2023-08-12  0:41 ` [PATCH v5 06/10] libfs: Validate negative dentries in case-insensitive directories Gabriel Krisman Bertazi
2023-08-12  0:41   ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-12  2:41   ` Eric Biggers
2023-08-12  2:41     ` [f2fs-dev] " Eric Biggers
2023-08-14 14:50     ` Gabriel Krisman Bertazi
2023-08-14 14:50       ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-14 18:42       ` Eric Biggers
2023-08-14 18:42         ` [f2fs-dev] " Eric Biggers
2023-08-14 19:21         ` Gabriel Krisman Bertazi
2023-08-14 19:21           ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-14 19:26           ` Eric Biggers
2023-08-14 19:26             ` [f2fs-dev] " Eric Biggers
2023-08-12  0:41 ` [PATCH v5 07/10] libfs: Chain encryption checks after case-insensitive revalidation Gabriel Krisman Bertazi
2023-08-12  0:41   ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-12  0:41 ` [PATCH v5 08/10] libfs: Merge encrypted_ci_dentry_ops and ci_dentry_ops Gabriel Krisman Bertazi
2023-08-12  0:41   ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-12  0:41 ` [PATCH v5 09/10] ext4: Enable negative dentries on case-insensitive lookup Gabriel Krisman Bertazi
2023-08-12  0:41   ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-12  0:41 ` [PATCH v5 10/10] f2fs: " Gabriel Krisman Bertazi
2023-08-12  0:41   ` [f2fs-dev] " Gabriel Krisman Bertazi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230812004146.30980-3-krisman@suse.de \
    --to=krisman@suse.de \
    --cc=brauner@kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.