* [PATCH v9 1/2] dt-bindings: serial: amlogic,meson-uart: Add compatible string for T7 @ 2023-08-14 8:01 ` Lucas Tanure 0 siblings, 0 replies; 15+ messages in thread From: Lucas Tanure @ 2023-08-14 8:01 UTC (permalink / raw) To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao Cc: Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial, Lucas Tanure, Krzysztof Kozlowski Amlogic T7 SoCs uses the same UART controller as S4 SoCs and G12A. There is no need for an extra compatible line in the driver, but add T7 compatible line for documentation. Signed-off-by: Lucas Tanure <tanure@linux.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Since v8: - Fix issues with git send-mail command line Since v7: - Send to the correct maintainers .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml index f1ae8c4934d9..2e189e548327 100644 --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml @@ -52,6 +52,10 @@ properties: items: - const: amlogic,meson-g12a-uart - const: amlogic,meson-gx-uart + - description: UART controller on S4 compatible SoCs + items: + - const: amlogic,t7-uart + - const: amlogic,meson-s4-uart reg: maxItems: 1 -- 2.41.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v9 1/2] dt-bindings: serial: amlogic,meson-uart: Add compatible string for T7 @ 2023-08-14 8:01 ` Lucas Tanure 0 siblings, 0 replies; 15+ messages in thread From: Lucas Tanure @ 2023-08-14 8:01 UTC (permalink / raw) To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao Cc: Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial, Lucas Tanure, Krzysztof Kozlowski Amlogic T7 SoCs uses the same UART controller as S4 SoCs and G12A. There is no need for an extra compatible line in the driver, but add T7 compatible line for documentation. Signed-off-by: Lucas Tanure <tanure@linux.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Since v8: - Fix issues with git send-mail command line Since v7: - Send to the correct maintainers .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml index f1ae8c4934d9..2e189e548327 100644 --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml @@ -52,6 +52,10 @@ properties: items: - const: amlogic,meson-g12a-uart - const: amlogic,meson-gx-uart + - description: UART controller on S4 compatible SoCs + items: + - const: amlogic,t7-uart + - const: amlogic,meson-s4-uart reg: maxItems: 1 -- 2.41.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v9 1/2] dt-bindings: serial: amlogic,meson-uart: Add compatible string for T7 @ 2023-08-14 8:01 ` Lucas Tanure 0 siblings, 0 replies; 15+ messages in thread From: Lucas Tanure @ 2023-08-14 8:01 UTC (permalink / raw) To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao Cc: Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial, Lucas Tanure, Krzysztof Kozlowski Amlogic T7 SoCs uses the same UART controller as S4 SoCs and G12A. There is no need for an extra compatible line in the driver, but add T7 compatible line for documentation. Signed-off-by: Lucas Tanure <tanure@linux.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Since v8: - Fix issues with git send-mail command line Since v7: - Send to the correct maintainers .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml index f1ae8c4934d9..2e189e548327 100644 --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml @@ -52,6 +52,10 @@ properties: items: - const: amlogic,meson-g12a-uart - const: amlogic,meson-gx-uart + - description: UART controller on S4 compatible SoCs + items: + - const: amlogic,t7-uart + - const: amlogic,meson-s4-uart reg: maxItems: 1 -- 2.41.0 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC 2023-08-14 8:01 ` Lucas Tanure (?) @ 2023-08-14 8:01 ` Lucas Tanure -1 siblings, 0 replies; 15+ messages in thread From: Lucas Tanure @ 2023-08-14 8:01 UTC (permalink / raw) To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao Cc: Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial, Lucas Tanure The new Amlogic T7 SoC does not have a always-on uart, so add OF_EARLYCON_DECLARE for it. Signed-off-by: Lucas Tanure <tanure@linux.com> Acked-by: Neil Armstrong <neil.armstrong@linaro.org> --- Since v8: - Fix issues with git send-mail command line Since v7: - Send to the correct maintainers drivers/tty/serial/meson_uart.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c index 790d910dafa5..c4f61d82fb72 100644 --- a/drivers/tty/serial/meson_uart.c +++ b/drivers/tty/serial/meson_uart.c @@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup); +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart", + meson_serial_early_console_setup); #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname) #else -- 2.41.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC @ 2023-08-14 8:01 ` Lucas Tanure 0 siblings, 0 replies; 15+ messages in thread From: Lucas Tanure @ 2023-08-14 8:01 UTC (permalink / raw) To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao Cc: Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial, Lucas Tanure The new Amlogic T7 SoC does not have a always-on uart, so add OF_EARLYCON_DECLARE for it. Signed-off-by: Lucas Tanure <tanure@linux.com> Acked-by: Neil Armstrong <neil.armstrong@linaro.org> --- Since v8: - Fix issues with git send-mail command line Since v7: - Send to the correct maintainers drivers/tty/serial/meson_uart.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c index 790d910dafa5..c4f61d82fb72 100644 --- a/drivers/tty/serial/meson_uart.c +++ b/drivers/tty/serial/meson_uart.c @@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup); +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart", + meson_serial_early_console_setup); #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname) #else -- 2.41.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC @ 2023-08-14 8:01 ` Lucas Tanure 0 siblings, 0 replies; 15+ messages in thread From: Lucas Tanure @ 2023-08-14 8:01 UTC (permalink / raw) To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao Cc: Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial, Lucas Tanure The new Amlogic T7 SoC does not have a always-on uart, so add OF_EARLYCON_DECLARE for it. Signed-off-by: Lucas Tanure <tanure@linux.com> Acked-by: Neil Armstrong <neil.armstrong@linaro.org> --- Since v8: - Fix issues with git send-mail command line Since v7: - Send to the correct maintainers drivers/tty/serial/meson_uart.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c index 790d910dafa5..c4f61d82fb72 100644 --- a/drivers/tty/serial/meson_uart.c +++ b/drivers/tty/serial/meson_uart.c @@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup); +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart", + meson_serial_early_console_setup); #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname) #else -- 2.41.0 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC 2023-08-14 8:01 ` Lucas Tanure (?) @ 2023-08-23 8:29 ` Dmitry Rokosov -1 siblings, 0 replies; 15+ messages in thread From: Dmitry Rokosov @ 2023-08-23 8:29 UTC (permalink / raw) To: Lucas Tanure Cc: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao, Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial Hello Lucas, Thank you for the patch! Please find my small comment below. On Mon, Aug 14, 2023 at 09:01:28AM +0100, Lucas Tanure wrote: > The new Amlogic T7 SoC does not have a always-on uart, > so add OF_EARLYCON_DECLARE for it. > > Signed-off-by: Lucas Tanure <tanure@linux.com> > Acked-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > Since v8: > - Fix issues with git send-mail command line > Since v7: > - Send to the correct maintainers > > drivers/tty/serial/meson_uart.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > index 790d910dafa5..c4f61d82fb72 100644 > --- a/drivers/tty/serial/meson_uart.c > +++ b/drivers/tty/serial/meson_uart.c > @@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt > > OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", > meson_serial_early_console_setup); > +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart", > + meson_serial_early_console_setup); > > #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname) > #else I suppose you need to add a separate meson_t7_uart_data to switch the T7 UART to a regular TTY devname 'ttyS'. For the new Amlogic SoCs, we have agreed to use 'ttyS' instead of 'ttyAML'. Please refer to the already applied patch series at [1] and the IRC discussion at [2]. Links: [1] https://lore.kernel.org/all/20230705181833.16137-1-ddrokosov@sberdevices.ru/ [2] https://libera.irclog.whitequark.org/linux-amlogic/2023-07-03 -- Thank you, Dmitry _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC @ 2023-08-23 8:29 ` Dmitry Rokosov 0 siblings, 0 replies; 15+ messages in thread From: Dmitry Rokosov @ 2023-08-23 8:29 UTC (permalink / raw) To: Lucas Tanure Cc: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao, Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial Hello Lucas, Thank you for the patch! Please find my small comment below. On Mon, Aug 14, 2023 at 09:01:28AM +0100, Lucas Tanure wrote: > The new Amlogic T7 SoC does not have a always-on uart, > so add OF_EARLYCON_DECLARE for it. > > Signed-off-by: Lucas Tanure <tanure@linux.com> > Acked-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > Since v8: > - Fix issues with git send-mail command line > Since v7: > - Send to the correct maintainers > > drivers/tty/serial/meson_uart.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > index 790d910dafa5..c4f61d82fb72 100644 > --- a/drivers/tty/serial/meson_uart.c > +++ b/drivers/tty/serial/meson_uart.c > @@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt > > OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", > meson_serial_early_console_setup); > +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart", > + meson_serial_early_console_setup); > > #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname) > #else I suppose you need to add a separate meson_t7_uart_data to switch the T7 UART to a regular TTY devname 'ttyS'. For the new Amlogic SoCs, we have agreed to use 'ttyS' instead of 'ttyAML'. Please refer to the already applied patch series at [1] and the IRC discussion at [2]. Links: [1] https://lore.kernel.org/all/20230705181833.16137-1-ddrokosov@sberdevices.ru/ [2] https://libera.irclog.whitequark.org/linux-amlogic/2023-07-03 -- Thank you, Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC @ 2023-08-23 8:29 ` Dmitry Rokosov 0 siblings, 0 replies; 15+ messages in thread From: Dmitry Rokosov @ 2023-08-23 8:29 UTC (permalink / raw) To: Lucas Tanure Cc: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao, Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial Hello Lucas, Thank you for the patch! Please find my small comment below. On Mon, Aug 14, 2023 at 09:01:28AM +0100, Lucas Tanure wrote: > The new Amlogic T7 SoC does not have a always-on uart, > so add OF_EARLYCON_DECLARE for it. > > Signed-off-by: Lucas Tanure <tanure@linux.com> > Acked-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > Since v8: > - Fix issues with git send-mail command line > Since v7: > - Send to the correct maintainers > > drivers/tty/serial/meson_uart.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > index 790d910dafa5..c4f61d82fb72 100644 > --- a/drivers/tty/serial/meson_uart.c > +++ b/drivers/tty/serial/meson_uart.c > @@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt > > OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", > meson_serial_early_console_setup); > +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart", > + meson_serial_early_console_setup); > > #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname) > #else I suppose you need to add a separate meson_t7_uart_data to switch the T7 UART to a regular TTY devname 'ttyS'. For the new Amlogic SoCs, we have agreed to use 'ttyS' instead of 'ttyAML'. Please refer to the already applied patch series at [1] and the IRC discussion at [2]. Links: [1] https://lore.kernel.org/all/20230705181833.16137-1-ddrokosov@sberdevices.ru/ [2] https://libera.irclog.whitequark.org/linux-amlogic/2023-07-03 -- Thank you, Dmitry ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC 2023-08-23 8:29 ` Dmitry Rokosov (?) @ 2023-08-26 18:07 ` Lucas Tanure -1 siblings, 0 replies; 15+ messages in thread From: Lucas Tanure @ 2023-08-26 18:07 UTC (permalink / raw) To: Dmitry Rokosov Cc: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao, Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial On 23-08-2023 09:29, Dmitry Rokosov wrote: > Hello Lucas, > > Thank you for the patch! Please find my small comment below. > > On Mon, Aug 14, 2023 at 09:01:28AM +0100, Lucas Tanure wrote: >> The new Amlogic T7 SoC does not have a always-on uart, >> so add OF_EARLYCON_DECLARE for it. >> >> Signed-off-by: Lucas Tanure <tanure@linux.com> >> Acked-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> Since v8: >> - Fix issues with git send-mail command line >> Since v7: >> - Send to the correct maintainers >> >> drivers/tty/serial/meson_uart.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c >> index 790d910dafa5..c4f61d82fb72 100644 >> --- a/drivers/tty/serial/meson_uart.c >> +++ b/drivers/tty/serial/meson_uart.c >> @@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt >> >> OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", >> meson_serial_early_console_setup); >> +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart", >> + meson_serial_early_console_setup); >> >> #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname) >> #else > > I suppose you need to add a separate meson_t7_uart_data to switch the T7 > UART to a regular TTY devname 'ttyS'. For the new Amlogic SoCs, we have > agreed to use 'ttyS' instead of 'ttyAML'. Please refer to the already > applied patch series at [1] and the IRC discussion at [2]. > > Links: > [1] https://lore.kernel.org/all/20230705181833.16137-1-ddrokosov@sberdevices.ru/ > [2] https://libera.irclog.whitequark.org/linux-amlogic/2023-07-03 > I asked Greg to drop this patch as is not need anymore. T7 will use S4 TTY/UART code. _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC @ 2023-08-26 18:07 ` Lucas Tanure 0 siblings, 0 replies; 15+ messages in thread From: Lucas Tanure @ 2023-08-26 18:07 UTC (permalink / raw) To: Dmitry Rokosov Cc: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao, Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial On 23-08-2023 09:29, Dmitry Rokosov wrote: > Hello Lucas, > > Thank you for the patch! Please find my small comment below. > > On Mon, Aug 14, 2023 at 09:01:28AM +0100, Lucas Tanure wrote: >> The new Amlogic T7 SoC does not have a always-on uart, >> so add OF_EARLYCON_DECLARE for it. >> >> Signed-off-by: Lucas Tanure <tanure@linux.com> >> Acked-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> Since v8: >> - Fix issues with git send-mail command line >> Since v7: >> - Send to the correct maintainers >> >> drivers/tty/serial/meson_uart.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c >> index 790d910dafa5..c4f61d82fb72 100644 >> --- a/drivers/tty/serial/meson_uart.c >> +++ b/drivers/tty/serial/meson_uart.c >> @@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt >> >> OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", >> meson_serial_early_console_setup); >> +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart", >> + meson_serial_early_console_setup); >> >> #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname) >> #else > > I suppose you need to add a separate meson_t7_uart_data to switch the T7 > UART to a regular TTY devname 'ttyS'. For the new Amlogic SoCs, we have > agreed to use 'ttyS' instead of 'ttyAML'. Please refer to the already > applied patch series at [1] and the IRC discussion at [2]. > > Links: > [1] https://lore.kernel.org/all/20230705181833.16137-1-ddrokosov@sberdevices.ru/ > [2] https://libera.irclog.whitequark.org/linux-amlogic/2023-07-03 > I asked Greg to drop this patch as is not need anymore. T7 will use S4 TTY/UART code. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC @ 2023-08-26 18:07 ` Lucas Tanure 0 siblings, 0 replies; 15+ messages in thread From: Lucas Tanure @ 2023-08-26 18:07 UTC (permalink / raw) To: Dmitry Rokosov Cc: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao, Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial On 23-08-2023 09:29, Dmitry Rokosov wrote: > Hello Lucas, > > Thank you for the patch! Please find my small comment below. > > On Mon, Aug 14, 2023 at 09:01:28AM +0100, Lucas Tanure wrote: >> The new Amlogic T7 SoC does not have a always-on uart, >> so add OF_EARLYCON_DECLARE for it. >> >> Signed-off-by: Lucas Tanure <tanure@linux.com> >> Acked-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> Since v8: >> - Fix issues with git send-mail command line >> Since v7: >> - Send to the correct maintainers >> >> drivers/tty/serial/meson_uart.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c >> index 790d910dafa5..c4f61d82fb72 100644 >> --- a/drivers/tty/serial/meson_uart.c >> +++ b/drivers/tty/serial/meson_uart.c >> @@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt >> >> OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", >> meson_serial_early_console_setup); >> +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart", >> + meson_serial_early_console_setup); >> >> #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname) >> #else > > I suppose you need to add a separate meson_t7_uart_data to switch the T7 > UART to a regular TTY devname 'ttyS'. For the new Amlogic SoCs, we have > agreed to use 'ttyS' instead of 'ttyAML'. Please refer to the already > applied patch series at [1] and the IRC discussion at [2]. > > Links: > [1] https://lore.kernel.org/all/20230705181833.16137-1-ddrokosov@sberdevices.ru/ > [2] https://libera.irclog.whitequark.org/linux-amlogic/2023-07-03 > I asked Greg to drop this patch as is not need anymore. T7 will use S4 TTY/UART code. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC 2023-08-26 18:07 ` Lucas Tanure (?) @ 2023-08-26 19:59 ` Greg Kroah-Hartman -1 siblings, 0 replies; 15+ messages in thread From: Greg Kroah-Hartman @ 2023-08-26 19:59 UTC (permalink / raw) To: Lucas Tanure Cc: Dmitry Rokosov, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao, Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial On Sat, Aug 26, 2023 at 07:07:18PM +0100, Lucas Tanure wrote: > On 23-08-2023 09:29, Dmitry Rokosov wrote: > > Hello Lucas, > > > > Thank you for the patch! Please find my small comment below. > > > > On Mon, Aug 14, 2023 at 09:01:28AM +0100, Lucas Tanure wrote: > > > The new Amlogic T7 SoC does not have a always-on uart, > > > so add OF_EARLYCON_DECLARE for it. > > > > > > Signed-off-by: Lucas Tanure <tanure@linux.com> > > > Acked-by: Neil Armstrong <neil.armstrong@linaro.org> > > > --- > > > Since v8: > > > - Fix issues with git send-mail command line > > > Since v7: > > > - Send to the correct maintainers > > > > > > drivers/tty/serial/meson_uart.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > > > index 790d910dafa5..c4f61d82fb72 100644 > > > --- a/drivers/tty/serial/meson_uart.c > > > +++ b/drivers/tty/serial/meson_uart.c > > > @@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt > > > OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", > > > meson_serial_early_console_setup); > > > +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart", > > > + meson_serial_early_console_setup); > > > #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname) > > > #else > > > > I suppose you need to add a separate meson_t7_uart_data to switch the T7 > > UART to a regular TTY devname 'ttyS'. For the new Amlogic SoCs, we have > > agreed to use 'ttyS' instead of 'ttyAML'. Please refer to the already > > applied patch series at [1] and the IRC discussion at [2]. > > > > Links: > > [1] https://lore.kernel.org/all/20230705181833.16137-1-ddrokosov@sberdevices.ru/ > > [2] https://libera.irclog.whitequark.org/linux-amlogic/2023-07-03 > > > I asked Greg to drop this patch as is not need anymore. > T7 will use S4 TTY/UART code. I can't drop it, I need a revert :( _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC @ 2023-08-26 19:59 ` Greg Kroah-Hartman 0 siblings, 0 replies; 15+ messages in thread From: Greg Kroah-Hartman @ 2023-08-26 19:59 UTC (permalink / raw) To: Lucas Tanure Cc: Dmitry Rokosov, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao, Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial On Sat, Aug 26, 2023 at 07:07:18PM +0100, Lucas Tanure wrote: > On 23-08-2023 09:29, Dmitry Rokosov wrote: > > Hello Lucas, > > > > Thank you for the patch! Please find my small comment below. > > > > On Mon, Aug 14, 2023 at 09:01:28AM +0100, Lucas Tanure wrote: > > > The new Amlogic T7 SoC does not have a always-on uart, > > > so add OF_EARLYCON_DECLARE for it. > > > > > > Signed-off-by: Lucas Tanure <tanure@linux.com> > > > Acked-by: Neil Armstrong <neil.armstrong@linaro.org> > > > --- > > > Since v8: > > > - Fix issues with git send-mail command line > > > Since v7: > > > - Send to the correct maintainers > > > > > > drivers/tty/serial/meson_uart.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > > > index 790d910dafa5..c4f61d82fb72 100644 > > > --- a/drivers/tty/serial/meson_uart.c > > > +++ b/drivers/tty/serial/meson_uart.c > > > @@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt > > > OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", > > > meson_serial_early_console_setup); > > > +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart", > > > + meson_serial_early_console_setup); > > > #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname) > > > #else > > > > I suppose you need to add a separate meson_t7_uart_data to switch the T7 > > UART to a regular TTY devname 'ttyS'. For the new Amlogic SoCs, we have > > agreed to use 'ttyS' instead of 'ttyAML'. Please refer to the already > > applied patch series at [1] and the IRC discussion at [2]. > > > > Links: > > [1] https://lore.kernel.org/all/20230705181833.16137-1-ddrokosov@sberdevices.ru/ > > [2] https://libera.irclog.whitequark.org/linux-amlogic/2023-07-03 > > > I asked Greg to drop this patch as is not need anymore. > T7 will use S4 TTY/UART code. I can't drop it, I need a revert :( _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC @ 2023-08-26 19:59 ` Greg Kroah-Hartman 0 siblings, 0 replies; 15+ messages in thread From: Greg Kroah-Hartman @ 2023-08-26 19:59 UTC (permalink / raw) To: Lucas Tanure Cc: Dmitry Rokosov, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jerome Brunet, Kevin Hilman, Xianwei Zhao, Nick, devicetree, linux-kernel, linux-amlogic, linux-arm-kernel, linux-serial On Sat, Aug 26, 2023 at 07:07:18PM +0100, Lucas Tanure wrote: > On 23-08-2023 09:29, Dmitry Rokosov wrote: > > Hello Lucas, > > > > Thank you for the patch! Please find my small comment below. > > > > On Mon, Aug 14, 2023 at 09:01:28AM +0100, Lucas Tanure wrote: > > > The new Amlogic T7 SoC does not have a always-on uart, > > > so add OF_EARLYCON_DECLARE for it. > > > > > > Signed-off-by: Lucas Tanure <tanure@linux.com> > > > Acked-by: Neil Armstrong <neil.armstrong@linaro.org> > > > --- > > > Since v8: > > > - Fix issues with git send-mail command line > > > Since v7: > > > - Send to the correct maintainers > > > > > > drivers/tty/serial/meson_uart.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > > > index 790d910dafa5..c4f61d82fb72 100644 > > > --- a/drivers/tty/serial/meson_uart.c > > > +++ b/drivers/tty/serial/meson_uart.c > > > @@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt > > > OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", > > > meson_serial_early_console_setup); > > > +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart", > > > + meson_serial_early_console_setup); > > > #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname) > > > #else > > > > I suppose you need to add a separate meson_t7_uart_data to switch the T7 > > UART to a regular TTY devname 'ttyS'. For the new Amlogic SoCs, we have > > agreed to use 'ttyS' instead of 'ttyAML'. Please refer to the already > > applied patch series at [1] and the IRC discussion at [2]. > > > > Links: > > [1] https://lore.kernel.org/all/20230705181833.16137-1-ddrokosov@sberdevices.ru/ > > [2] https://libera.irclog.whitequark.org/linux-amlogic/2023-07-03 > > > I asked Greg to drop this patch as is not need anymore. > T7 will use S4 TTY/UART code. I can't drop it, I need a revert :( ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2023-08-26 20:00 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-08-14 8:01 [PATCH v9 1/2] dt-bindings: serial: amlogic,meson-uart: Add compatible string for T7 Lucas Tanure 2023-08-14 8:01 ` Lucas Tanure 2023-08-14 8:01 ` Lucas Tanure 2023-08-14 8:01 ` [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC Lucas Tanure 2023-08-14 8:01 ` Lucas Tanure 2023-08-14 8:01 ` Lucas Tanure 2023-08-23 8:29 ` Dmitry Rokosov 2023-08-23 8:29 ` Dmitry Rokosov 2023-08-23 8:29 ` Dmitry Rokosov 2023-08-26 18:07 ` Lucas Tanure 2023-08-26 18:07 ` Lucas Tanure 2023-08-26 18:07 ` Lucas Tanure 2023-08-26 19:59 ` Greg Kroah-Hartman 2023-08-26 19:59 ` Greg Kroah-Hartman 2023-08-26 19:59 ` Greg Kroah-Hartman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.