[broonie-ci:v2_20230808_kuninori_morimoto_gx_asoc_merge_dai_call_back_functions_into_ops 56/179] sound/soc/codecs/aw88261.c:1246 aw88261_i2c_probe() warn: passing zero to 'dev_err_probe'

[broonie-ci:v2_20230808_kuninori_morimoto_gx_asoc_merge_dai_call_back_functions_into_ops 56/179] sound/soc/codecs/aw88261.c:1246 aw88261_i2c_probe() warn: passing zero to 'dev_err_probe'

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Weidong Wang <wangweidong.a@awinic.com>
CC: Mark Brown <broonie@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git v2_20230808_kuninori_morimoto_gx_asoc_merge_dai_call_back_functions_into_ops
head:   8e1eb11cd4579decc8e928be2face7c43f2a9c67
commit: 028a2ae256916eeae1040049d2d0129535ace60e [56/179] ASoC: codecs: Add aw88261 amplifier driver
:::::: branch date: 8 hours ago
:::::: commit date: 7 days ago
config: nios2-randconfig-m031-20230814 (https://download.01.org/0day-ci/archive/20230815/202308150315.CvOTIOKm-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230815/202308150315.CvOTIOKm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202308150315.CvOTIOKm-lkp@intel.com/

New smatch warnings:
sound/soc/codecs/aw88261.c:1246 aw88261_i2c_probe() warn: passing zero to 'dev_err_probe'

Old smatch warnings:
sound/soc/codecs/aw88261.c:660 aw88261_reg_update() error: uninitialized symbol 'ret'.

vim +/dev_err_probe +1246 sound/soc/codecs/aw88261.c

028a2ae256916e Weidong Wang 2023-08-04  1238  
028a2ae256916e Weidong Wang 2023-08-04  1239  static int aw88261_i2c_probe(struct i2c_client *i2c)
028a2ae256916e Weidong Wang 2023-08-04  1240  {
028a2ae256916e Weidong Wang 2023-08-04  1241  	struct aw88261 *aw88261;
028a2ae256916e Weidong Wang 2023-08-04  1242  	int ret;
028a2ae256916e Weidong Wang 2023-08-04  1243  
028a2ae256916e Weidong Wang 2023-08-04  1244  	ret = i2c_check_functionality(i2c->adapter, I2C_FUNC_I2C);
028a2ae256916e Weidong Wang 2023-08-04  1245  	if (!ret)
028a2ae256916e Weidong Wang 2023-08-04 @1246  		return dev_err_probe(&i2c->dev, ret, "check_functionality failed");
028a2ae256916e Weidong Wang 2023-08-04  1247  
028a2ae256916e Weidong Wang 2023-08-04  1248  	aw88261 = devm_kzalloc(&i2c->dev, sizeof(*aw88261), GFP_KERNEL);
028a2ae256916e Weidong Wang 2023-08-04  1249  	if (!aw88261)
028a2ae256916e Weidong Wang 2023-08-04  1250  		return -ENOMEM;
028a2ae256916e Weidong Wang 2023-08-04  1251  
028a2ae256916e Weidong Wang 2023-08-04  1252  	mutex_init(&aw88261->lock);
028a2ae256916e Weidong Wang 2023-08-04  1253  
028a2ae256916e Weidong Wang 2023-08-04  1254  	i2c_set_clientdata(i2c, aw88261);
028a2ae256916e Weidong Wang 2023-08-04  1255  
028a2ae256916e Weidong Wang 2023-08-04  1256  	aw88261->reset_gpio = devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_LOW);
028a2ae256916e Weidong Wang 2023-08-04  1257  	if (IS_ERR(aw88261->reset_gpio))
028a2ae256916e Weidong Wang 2023-08-04  1258  		dev_info(&i2c->dev, "reset gpio not defined\n");
028a2ae256916e Weidong Wang 2023-08-04  1259  	else
028a2ae256916e Weidong Wang 2023-08-04  1260  		aw88261_hw_reset(aw88261);
028a2ae256916e Weidong Wang 2023-08-04  1261  
028a2ae256916e Weidong Wang 2023-08-04  1262  	aw88261->regmap = devm_regmap_init_i2c(i2c, &aw88261_remap_config);
028a2ae256916e Weidong Wang 2023-08-04  1263  	if (IS_ERR(aw88261->regmap)) {
028a2ae256916e Weidong Wang 2023-08-04  1264  		ret = PTR_ERR(aw88261->regmap);
028a2ae256916e Weidong Wang 2023-08-04  1265  		return dev_err_probe(&i2c->dev, ret, "failed to init regmap: %d\n", ret);
028a2ae256916e Weidong Wang 2023-08-04  1266  	}
028a2ae256916e Weidong Wang 2023-08-04  1267  
028a2ae256916e Weidong Wang 2023-08-04  1268  	/* aw pa init */
028a2ae256916e Weidong Wang 2023-08-04  1269  	ret = aw88261_init(&aw88261, i2c, aw88261->regmap);
028a2ae256916e Weidong Wang 2023-08-04  1270  	if (ret)
028a2ae256916e Weidong Wang 2023-08-04  1271  		return ret;
028a2ae256916e Weidong Wang 2023-08-04  1272  
028a2ae256916e Weidong Wang 2023-08-04  1273  	ret = devm_snd_soc_register_component(&i2c->dev,
028a2ae256916e Weidong Wang 2023-08-04  1274  			&soc_codec_dev_aw88261,
028a2ae256916e Weidong Wang 2023-08-04  1275  			aw88261_dai, ARRAY_SIZE(aw88261_dai));
028a2ae256916e Weidong Wang 2023-08-04  1276  	if (ret)
028a2ae256916e Weidong Wang 2023-08-04  1277  		dev_err(&i2c->dev, "failed to register aw88261: %d", ret);
028a2ae256916e Weidong Wang 2023-08-04  1278  
028a2ae256916e Weidong Wang 2023-08-04  1279  	return ret;
028a2ae256916e Weidong Wang 2023-08-04  1280  }
028a2ae256916e Weidong Wang 2023-08-04  1281  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki