From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
linux-kbuild@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
linux-s390@vger.kernel.org, Stefan Haberland <sth@linux.ibm.com>,
Jan Hoeppner <hoeppner@linux.ibm.com>,
Christian Brauner <brauner@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: linux-next-2023-0815: s390/block/dasd: build error
Date: Wed, 16 Aug 2023 17:14:39 +1000 [thread overview]
Message-ID: <20230816170934.71a5e306@oak.ozlabs.ibm.com> (raw)
In-Reply-To: <95b176a2-3670-1e89-c8f6-86b094eebc4c@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
Hi Randy,
On Tue, 15 Aug 2023 22:34:19 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> I have spent some time on this but I don't see where the problem is.
>
> ERROR: modpost: "bdev_mark_dead" [drivers/s390/block/dasd_mod.ko] undefined!
>
> CONFIG_BLOCK=y, bdev.o is built and contains the missing symbol.
>
> Full randconfig file is attached.
>
> Hopefully I'm just overlooking something.
In your config, CONFIG_DASD=m which means "#ifdef CONFIG_DASD" will
fail since CONFIG_DASD_MODULE is defined instead ... so maybe it should
be "#if IS_ENABLED(CONFIG_DASD)" in block/bdev.c. This also fails an
s390 allmodconfig build (obviously).
So this is caused by commit
381f678306ce ("block: consolidate __invalidate_device and fsync_bdev")
from the vfs-brauner branch in linux-next.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-08-16 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 5:34 linux-next-2023-0815: s390/block/dasd: build error Randy Dunlap
2023-08-16 7:03 ` Sven Schnelle
2023-08-16 7:14 ` Stephen Rothwell [this message]
2023-08-16 8:11 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816170934.71a5e306@oak.ozlabs.ibm.com \
--to=sfr@canb.auug.org.au \
--cc=brauner@kernel.org \
--cc=hch@lst.de \
--cc=hoeppner@linux.ibm.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sth@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.