All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Schnelle <svens@linux.ibm.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
	linux-kbuild@vger.kernel.org,
	Masahiro Yamada <masahiroy@kernel.org>,
	linux-s390@vger.kernel.org, Stefan Haberland <sth@linux.ibm.com>,
	Jan Hoeppner <hoeppner@linux.ibm.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: linux-next-2023-0815: s390/block/dasd: build error
Date: Wed, 16 Aug 2023 09:03:54 +0200	[thread overview]
Message-ID: <yt9d350jbh9h.fsf@linux.ibm.com> (raw)
In-Reply-To: <95b176a2-3670-1e89-c8f6-86b094eebc4c@infradead.org> (Randy Dunlap's message of "Tue, 15 Aug 2023 22:34:19 -0700")

Randy Dunlap <rdunlap@infradead.org> writes:

> I have spent some time on this but I don't see where the problem is.
>
> ERROR: modpost: "bdev_mark_dead" [drivers/s390/block/dasd_mod.ko] undefined!
>
> CONFIG_BLOCK=y, bdev.o is built and contains the missing symbol.
>
> Full randconfig file is attached.
>
> Hopefully I'm just overlooking something.

The EXPORT_SYMBOL_GPL is surrounded by #ifdef CONFIG_DASD, but i think
it should be '#ifdef CONFIG_DASD_MODULE'. This was introduced by

381f678306ce ("block: consolidate __invalidate_device and fsync_bdev")

There was already a thread about this:

https://www.spinics.net/lists/linux-btrfs/msg138633.html

regards,
Sven

  reply	other threads:[~2023-08-16  7:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16  5:34 linux-next-2023-0815: s390/block/dasd: build error Randy Dunlap
2023-08-16  7:03 ` Sven Schnelle [this message]
2023-08-16  7:14 ` Stephen Rothwell
2023-08-16  8:11   ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yt9d350jbh9h.fsf@linux.ibm.com \
    --to=svens@linux.ibm.com \
    --cc=hch@lst.de \
    --cc=hoeppner@linux.ibm.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sth@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.