From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Li Zetao <lizetao1@huawei.com>
Cc: <alexandre.torgue@foss.st.com>,
<angelogioacchino.delregno@collabora.com>,
<christophe.kerello@foss.st.com>, <christophe.leroy@csgroup.eu>,
<dmitry.torokhov@gmail.com>, <frank.li@vivo.com>,
<geert+renesas@glider.be>, <heiko@sntech.de>,
<jernej.skrabec@gmail.com>, <jinpu.wang@ionos.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-mtd@lists.infradead.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-sunxi@lists.linux.dev>,
<martin.blumenstingl@googlemail.com>, <matthias.bgg@gmail.com>,
<mcoquelin.stm32@gmail.com>, <michael@walle.cc>,
<michal.simek@amd.com>, <nicolas.ferre@microchip.com>,
<paul@crapouillou.net>, <philmd@linaro.org>,
<pratyush@kernel.org>, <richard@nod.at>, <robh@kernel.org>,
<rogerq@kernel.org>, <samuel@sholland.org>, <stefan@agner.ch>,
<tudor.ambarus@linaro.org>, <u.kleine-koenig@pengutronix.de>,
<vigneshr@ti.com>, <vz@mleia.com>, <wens@csie.org>,
<yangyingliang@huawei.com>
Subject: Re: [PATCH -next v2 02/12] mtd: rawnand: arasan: Use helper function devm_clk_get_enabled()
Date: Fri, 18 Aug 2023 10:12:42 +0200 [thread overview]
Message-ID: <20230818101242.12f54b5d@xps-13> (raw)
In-Reply-To: <20230818101004.4f2cd343@xps-13>
miquel.raynal@bootlin.com wrote on Fri, 18 Aug 2023 10:10:04 +0200:
> Hi Li,
>
> lizetao1@huawei.com wrote on Fri, 18 Aug 2023 15:46:32 +0800:
>
> > Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared
> > and enabled clocks"), devm_clk_get() and clk_prepare_enable() can now be
>
> > replaced by devm_clk_get_enabled() when driver enable (and possibly
>
> For all the commit logs: the driver enables (and possibly prepares)
>
> > prepare) the clocks for the whole lifetime of the device. Moreover, it is
> > no longer necessary to unprepare and disable the clock explicitly, so drop
>
> For all the commit logs: the clocks
>
> The ",so drop the label xxx" is not needed I believe.
>
> > the label "disable_bus_clk" and "disable_controller_clk".
Actually it does not bother, just keep it.
> > Signed-off-by: Li Zetao <lizetao1@huawei.com>
> > ---
>
> Thanks,
> Miquèl
Thanks,
Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Li Zetao <lizetao1@huawei.com>
Cc: <alexandre.torgue@foss.st.com>,
<angelogioacchino.delregno@collabora.com>,
<christophe.kerello@foss.st.com>, <christophe.leroy@csgroup.eu>,
<dmitry.torokhov@gmail.com>, <frank.li@vivo.com>,
<geert+renesas@glider.be>, <heiko@sntech.de>,
<jernej.skrabec@gmail.com>, <jinpu.wang@ionos.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-mtd@lists.infradead.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-sunxi@lists.linux.dev>,
<martin.blumenstingl@googlemail.com>, <matthias.bgg@gmail.com>,
<mcoquelin.stm32@gmail.com>, <michael@walle.cc>,
<michal.simek@amd.com>, <nicolas.ferre@microchip.com>,
<paul@crapouillou.net>, <philmd@linaro.org>,
<pratyush@kernel.org>, <richard@nod.at>, <robh@kernel.org>,
<rogerq@kernel.org>, <samuel@sholland.org>, <stefan@agner.ch>,
<tudor.ambarus@linaro.org>, <u.kleine-koenig@pengutronix.de>,
<vigneshr@ti.com>, <vz@mleia.com>, <wens@csie.org>,
<yangyingliang@huawei.com>
Subject: Re: [PATCH -next v2 02/12] mtd: rawnand: arasan: Use helper function devm_clk_get_enabled()
Date: Fri, 18 Aug 2023 10:12:42 +0200 [thread overview]
Message-ID: <20230818101242.12f54b5d@xps-13> (raw)
In-Reply-To: <20230818101004.4f2cd343@xps-13>
miquel.raynal@bootlin.com wrote on Fri, 18 Aug 2023 10:10:04 +0200:
> Hi Li,
>
> lizetao1@huawei.com wrote on Fri, 18 Aug 2023 15:46:32 +0800:
>
> > Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared
> > and enabled clocks"), devm_clk_get() and clk_prepare_enable() can now be
>
> > replaced by devm_clk_get_enabled() when driver enable (and possibly
>
> For all the commit logs: the driver enables (and possibly prepares)
>
> > prepare) the clocks for the whole lifetime of the device. Moreover, it is
> > no longer necessary to unprepare and disable the clock explicitly, so drop
>
> For all the commit logs: the clocks
>
> The ",so drop the label xxx" is not needed I believe.
>
> > the label "disable_bus_clk" and "disable_controller_clk".
Actually it does not bother, just keep it.
> > Signed-off-by: Li Zetao <lizetao1@huawei.com>
> > ---
>
> Thanks,
> Miquèl
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Li Zetao <lizetao1@huawei.com>
Cc: heiko@sntech.de, geert+renesas@glider.be,
alexandre.torgue@foss.st.com, stefan@agner.ch,
paul@crapouillou.net, linux-mtd@lists.infradead.org,
jernej.skrabec@gmail.com, jinpu.wang@ionos.com,
linux-stm32@st-md-mailman.stormreply.com, vigneshr@ti.com,
robh@kernel.org, samuel@sholland.org, richard@nod.at,
wens@csie.org, christophe.leroy@csgroup.eu,
tudor.ambarus@linaro.org, u.kleine-koenig@pengutronix.de,
linux-sunxi@lists.linux.dev, frank.li@vivo.com,
martin.blumenstingl@googlemail.com, yangyingliang@huawei.com,
vz@mleia.com, rogerq@kernel.org,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
michal.simek@amd.com, linux-arm-kernel@lists.infradead.org,
angelogioacchino.delregno@collabora.com, philmd@linaro.org,
christophe.kerello@foss.st.com, dmitry.torokhov@gmail.com,
michael@walle.cc, mcoquelin.stm32@gmail.com, pratyush@kernel.org
Subject: Re: [PATCH -next v2 02/12] mtd: rawnand: arasan: Use helper function devm_clk_get_enabled()
Date: Fri, 18 Aug 2023 10:12:42 +0200 [thread overview]
Message-ID: <20230818101242.12f54b5d@xps-13> (raw)
In-Reply-To: <20230818101004.4f2cd343@xps-13>
miquel.raynal@bootlin.com wrote on Fri, 18 Aug 2023 10:10:04 +0200:
> Hi Li,
>
> lizetao1@huawei.com wrote on Fri, 18 Aug 2023 15:46:32 +0800:
>
> > Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared
> > and enabled clocks"), devm_clk_get() and clk_prepare_enable() can now be
>
> > replaced by devm_clk_get_enabled() when driver enable (and possibly
>
> For all the commit logs: the driver enables (and possibly prepares)
>
> > prepare) the clocks for the whole lifetime of the device. Moreover, it is
> > no longer necessary to unprepare and disable the clock explicitly, so drop
>
> For all the commit logs: the clocks
>
> The ",so drop the label xxx" is not needed I believe.
>
> > the label "disable_bus_clk" and "disable_controller_clk".
Actually it does not bother, just keep it.
> > Signed-off-by: Li Zetao <lizetao1@huawei.com>
> > ---
>
> Thanks,
> Miquèl
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-18 8:13 UTC|newest]
Thread overview: 174+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 2:44 [PATCH -next 00/11] mtd: Use devm_clk_get_enabled() to simplify the drivers Li Zetao
2023-08-17 2:44 ` Li Zetao
2023-08-17 2:44 ` Li Zetao
2023-08-17 2:44 ` [PATCH -next 01/11] mtd: spear_smi: Use helper function devm_clk_get_enabled() Li Zetao
2023-08-17 2:44 ` Li Zetao
2023-08-17 2:44 ` Li Zetao
2023-08-17 2:45 ` [PATCH -next 02/11] mtd: rawnand: arasan: " Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` [PATCH -next 03/11] mtd: rawnand: fsmc: " Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 8:31 ` Miquel Raynal
2023-08-17 8:31 ` Miquel Raynal
2023-08-17 8:31 ` Miquel Raynal
2023-08-17 2:45 ` [PATCH -next 04/11] mtd: rawnand: intel: " Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` [PATCH -next 05/11] mtd: rawnand: lpc32xx_slc: " Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` [PATCH -next 06/11] mtd: rawnand: mpc5121: " Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` [PATCH -next 07/11] mtd: rawnand: mtk: " Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 8:34 ` Miquel Raynal
2023-08-17 8:34 ` Miquel Raynal
2023-08-17 8:34 ` Miquel Raynal
2023-08-17 2:45 ` [PATCH -next 08/11] mtd: rawnand: stm32_fmc2: " Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` [PATCH -next 09/11] mtd: rawnand: sunxi: " Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` [PATCH -next 10/11] mtd: rawnand: vf610_nfc: " Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` [PATCH -next 11/11] mtd: spi-nor: " Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 2:45 ` Li Zetao
2023-08-17 8:37 ` Miquel Raynal
2023-08-17 8:37 ` Miquel Raynal
2023-08-17 8:37 ` Miquel Raynal
2023-08-18 7:46 ` [PATCH -next v2 00/12] mtd: Use devm_clk_get_*() helper function to simplify the drivers Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` [PATCH -next v2 01/12] mtd: spear_smi: Use helper function devm_clk_get_enabled() Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` [PATCH -next v2 02/12] mtd: rawnand: arasan: " Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 8:10 ` Miquel Raynal
2023-08-18 8:10 ` Miquel Raynal
2023-08-18 8:10 ` Miquel Raynal
2023-08-18 8:12 ` Miquel Raynal [this message]
2023-08-18 8:12 ` Miquel Raynal
2023-08-18 8:12 ` Miquel Raynal
2023-08-21 3:17 ` [PATCH -next v3 00/12] mtd: Use devm_clk_get_*() helper function to simplify the drivers Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` [PATCH -next v3 01/12] mtd: spear_smi: Use helper function devm_clk_get_enabled() Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 3:17 ` [PATCH -next v3 02/12] mtd: rawnand: arasan: " Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 7:58 ` Miquel Raynal
2023-08-21 7:58 ` Miquel Raynal
2023-08-21 7:58 ` Miquel Raynal
2023-08-21 3:17 ` [PATCH -next v3 03/12] mtd: rawnand: fsmc: " Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 7:58 ` Miquel Raynal
2023-08-21 7:58 ` Miquel Raynal
2023-08-21 7:58 ` Miquel Raynal
2023-08-21 3:17 ` [PATCH -next v3 04/12] mtd: rawnand: intel: " Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 7:58 ` Miquel Raynal
2023-08-21 7:58 ` Miquel Raynal
2023-08-21 7:58 ` Miquel Raynal
2023-08-21 3:17 ` [PATCH -next v3 05/12] mtd: rawnand: lpc32xx_slc: " Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 3:17 ` [PATCH -next v3 06/12] mtd: rawnand: mpc5121: " Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 3:17 ` [PATCH -next v3 07/12] mtd: rawnand: mtk: " Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 3:17 ` [PATCH -next v3 08/12] mtd: rawnand: stm32_fmc2: " Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 3:17 ` [PATCH -next v3 09/12] mtd: rawnand: sunxi: " Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 3:17 ` [PATCH -next v3 10/12] mtd: rawnand: vf610_nfc: " Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` [PATCH -next v3 11/12] mtd: spi-nor: nxp-spifi: " Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 7:38 ` Miquel Raynal
2023-08-21 7:38 ` Miquel Raynal
2023-08-21 7:38 ` Miquel Raynal
2023-08-21 7:54 ` Miquel Raynal
2023-08-21 7:54 ` Miquel Raynal
2023-08-21 7:54 ` Miquel Raynal
2023-08-21 3:17 ` [PATCH -next v3 12/12] mtd: rawnand: orion: Use helper function devm_clk_get_optional_enabled() Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 3:17 ` Li Zetao
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 7:57 ` Miquel Raynal
2023-08-21 7:57 ` Miquel Raynal
2023-08-18 7:46 ` [PATCH -next v2 03/12] mtd: rawnand: fsmc: Use helper function devm_clk_get_enabled() Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 8:11 ` Miquel Raynal
2023-08-18 8:11 ` Miquel Raynal
2023-08-18 8:11 ` Miquel Raynal
2023-08-18 7:46 ` [PATCH -next v2 04/12] mtd: rawnand: intel: " Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` [PATCH -next v2 05/12] mtd: rawnand: lpc32xx_slc: " Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` [PATCH -next v2 06/12] mtd: rawnand: mpc5121: " Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` [PATCH -next v2 07/12] mtd: rawnand: mtk: " Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` [PATCH -next v2 08/12] mtd: rawnand: stm32_fmc2: " Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` [PATCH -next v2 09/12] mtd: rawnand: sunxi: " Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` [PATCH -next v2 10/12] mtd: rawnand: vf610_nfc: " Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` [PATCH -next v2 11/12] mtd: spi-nor: nxp-spifi: " Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 10:19 ` Tudor Ambarus
2023-08-18 10:19 ` Tudor Ambarus
2023-08-18 10:19 ` Tudor Ambarus
2023-08-18 7:46 ` [PATCH -next v2 12/12] mtd: rawnand: orion: Use helper function devm_clk_get_optional_enabled() Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 7:46 ` Li Zetao
2023-08-18 10:28 ` (subset) [PATCH -next v2 00/12] mtd: Use devm_clk_get_*() helper function to simplify the drivers Tudor Ambarus
2023-08-18 10:28 ` Tudor Ambarus
2023-08-18 10:28 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818101242.12f54b5d@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=christophe.kerello@foss.st.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dmitry.torokhov@gmail.com \
--cc=frank.li@vivo.com \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=jinpu.wang@ionos.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=lizetao1@huawei.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael@walle.cc \
--cc=michal.simek@amd.com \
--cc=nicolas.ferre@microchip.com \
--cc=paul@crapouillou.net \
--cc=philmd@linaro.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=samuel@sholland.org \
--cc=stefan@agner.ch \
--cc=tudor.ambarus@linaro.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vigneshr@ti.com \
--cc=vz@mleia.com \
--cc=wens@csie.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.