[Buildroot] [PATCH 1/1] package/crun: fix linking with libargp

[Buildroot] [PATCH 1/1] package/crun: fix linking with libargp

[Bernd Kuhls]

Fixes:
http://autobuild.buildroot.net/results/45f/45ff44284565c8e7deecfdc93995ec0ae4e89e2c/

The bug existed since the dependency to argp-standalone was added with
commit 0d9f268424558c37cd9538596358a537cd2f882d. The oldest build error
I could find occured on Nov, 9th, 2022:
http://autobuild.buildroot.net/results/ebe/ebea5d76c615d8509f87238d449e66da214fed73/

Please note that using $LIBS does not fix the problem.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/crun/crun.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/crun/crun.mk b/package/crun/crun.mk
index 15438a44b3..9d904ccf1b 100644
--- a/package/crun/crun.mk
+++ b/package/crun/crun.mk
@@ -17,6 +17,7 @@ CRUN_CONF_OPTS = --disable-embedded-yajl
 
 ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
 CRUN_DEPENDENCIES += argp-standalone
+CRUN_CONF_ENV += LDFLAGS=$(TARGET_NLS_LIBS)
 endif
 
 ifeq ($(BR2_PACKAGE_LIBCAP),y)
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/crun: fix linking with libargp

[Thomas Petazzoni via buildroot]

Hello Bernd,

On Sun, 20 Aug 2023 17:26:39 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Fixes:
> http://autobuild.buildroot.net/results/45f/45ff44284565c8e7deecfdc93995ec0ae4e89e2c/
> 
> The bug existed since the dependency to argp-standalone was added with
> commit 0d9f268424558c37cd9538596358a537cd2f882d. The oldest build error
> I could find occured on Nov, 9th, 2022:
> http://autobuild.buildroot.net/results/ebe/ebea5d76c615d8509f87238d449e66da214fed73/
> 
> Please note that using $LIBS does not fix the problem.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/crun/crun.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/crun/crun.mk b/package/crun/crun.mk
> index 15438a44b3..9d904ccf1b 100644
> --- a/package/crun/crun.mk
> +++ b/package/crun/crun.mk
> @@ -17,6 +17,7 @@ CRUN_CONF_OPTS = --disable-embedded-yajl
>  
>  ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
>  CRUN_DEPENDENCIES += argp-standalone
> +CRUN_CONF_ENV += LDFLAGS=$(TARGET_NLS_LIBS)

This looks extremely strange. TARGET_NLS_LIBS is either empty, or
contains -lintl. How is that related to argp-standalone, and how can it
resolve the argp-standalone issue?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/crun: fix linking with libargp

[Bernd Kuhls]

Am Sun, 20 Aug 2023 23:42:04 +0200 schrieb Thomas Petazzoni via buildroot:

> This looks extremely strange. TARGET_NLS_LIBS is either empty, or
> contains -lintl. How is that related to argp-standalone, and how can it
> resolve the argp-standalone issue?

Hi Thomas,

argp-standalone has an optional dependency to libintl:
https://git.buildroot.net/buildroot/tree/package/argp-standalone/argp-
standalone.mk#n19

and installs only an .a file causing an error during configure in crun:

/home/autobuild/autobuild/instance-7/output-1/build/argp-standalone-1.4.1/
argp-parse.c:181: undefined reference to `libintl_dgettext'

Regards, Bernd

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot