From: Lee Jones <lee@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Herve Codina <herve.codina@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v4 23/28] mfd: core: Ensure disabled devices are skiped without aborting
Date: Mon, 21 Aug 2023 13:17:21 +0100 [thread overview]
Message-ID: <20230821121721.GH1380343@google.com> (raw)
In-Reply-To: <528425d6472176bb1d02d79596b51f8c28a551cc.1692376361.git.christophe.leroy@csgroup.eu>
On Fri, 18 Aug 2023, Christophe Leroy wrote:
> From: Herve Codina <herve.codina@bootlin.com>
>
> The loop searching for a matching device based on its compatible
> string is aborted when a matching disabled device is found.
> This abort prevents to add devices as soon as one disabled device
> is found.
>
> Continue searching for an other device instead of aborting on the
> first disabled one fixes the issue.
>
> Fixes: 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are ignored without error")
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> drivers/mfd/mfd-core.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
This is too big of a change to be added this late in the cycle.
Pushing review until after v6.5 is out.
--
Lee Jones [李琼斯]
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Andrew Lunn <andrew@lunn.ch>,
alsa-devel@alsa-project.org,
Herve Codina <herve.codina@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Fabio Estevam <festevam@gmail.com>,
Qiang Zhao <qiang.zhao@nxp.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Nicolin Chen <nicoleotsuka@gmail.com>,
linux-gpio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>,
Takashi Iwai <tiwai@suse.com>, Li Yang <leoyang.li@nxp.com>,
Mark Brown <broonie@kernel.org>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v4 23/28] mfd: core: Ensure disabled devices are skiped without aborting
Date: Mon, 21 Aug 2023 13:17:21 +0100 [thread overview]
Message-ID: <20230821121721.GH1380343@google.com> (raw)
In-Reply-To: <528425d6472176bb1d02d79596b51f8c28a551cc.1692376361.git.christophe.leroy@csgroup.eu>
On Fri, 18 Aug 2023, Christophe Leroy wrote:
> From: Herve Codina <herve.codina@bootlin.com>
>
> The loop searching for a matching device based on its compatible
> string is aborted when a matching disabled device is found.
> This abort prevents to add devices as soon as one disabled device
> is found.
>
> Continue searching for an other device instead of aborting on the
> first disabled one fixes the issue.
>
> Fixes: 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are ignored without error")
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> drivers/mfd/mfd-core.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
This is too big of a change to be added this late in the cycle.
Pushing review until after v6.5 is out.
--
Lee Jones [李琼斯]
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Herve Codina <herve.codina@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v4 23/28] mfd: core: Ensure disabled devices are skiped without aborting
Date: Mon, 21 Aug 2023 13:17:21 +0100 [thread overview]
Message-ID: <20230821121721.GH1380343@google.com> (raw)
In-Reply-To: <528425d6472176bb1d02d79596b51f8c28a551cc.1692376361.git.christophe.leroy@csgroup.eu>
On Fri, 18 Aug 2023, Christophe Leroy wrote:
> From: Herve Codina <herve.codina@bootlin.com>
>
> The loop searching for a matching device based on its compatible
> string is aborted when a matching disabled device is found.
> This abort prevents to add devices as soon as one disabled device
> is found.
>
> Continue searching for an other device instead of aborting on the
> first disabled one fixes the issue.
>
> Fixes: 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are ignored without error")
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> drivers/mfd/mfd-core.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
This is too big of a change to be added this late in the cycle.
Pushing review until after v6.5 is out.
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-21 12:18 UTC|newest]
Thread overview: 149+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 16:38 [PATCH v4 00/28] Add support for QMC HDLC, framer infrastruture and PEF2256 framer (v4) Christophe Leroy
2023-08-18 16:38 ` Christophe Leroy
2023-08-18 16:38 ` Christophe Leroy
2023-08-18 16:38 ` Christophe Leroy
2023-08-18 16:38 ` [PATCH v4 01/28] soc: fsl: cpm1: tsa: Fix __iomem addresses declaration Christophe Leroy
2023-08-18 16:38 ` Christophe Leroy
2023-08-18 16:38 ` Christophe Leroy
2023-08-18 16:38 ` [PATCH v4 02/28] soc: fsl: cpm1: qmc: " Christophe Leroy
2023-08-18 16:38 ` Christophe Leroy
2023-08-18 16:38 ` Christophe Leroy
2023-08-18 16:38 ` [PATCH v4 03/28] soc: fsl: cpm1: qmc: Fix rx channel reset Christophe Leroy
2023-08-18 16:38 ` Christophe Leroy
2023-08-18 16:38 ` Christophe Leroy
2023-08-18 16:38 ` [PATCH v4 04/28] soc: fsl: cpm1: qmc: Extend the API to provide Rx status Christophe Leroy
2023-08-18 16:38 ` Christophe Leroy
2023-08-18 16:38 ` Christophe Leroy
2023-08-18 16:38 ` [PATCH v4 05/28] soc: fsl: cpm1: qmc: Remove inline function specifiers Christophe Leroy
2023-08-18 16:38 ` Christophe Leroy
2023-08-18 16:38 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 06/28] dt-bindings: net: Add support for QMC HDLC Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-21 20:42 ` Rob Herring
2023-08-21 20:42 ` Rob Herring
2023-08-21 20:42 ` Rob Herring
2023-08-21 20:42 ` Rob Herring
2023-08-24 16:12 ` Herve Codina
2023-08-24 16:12 ` Herve Codina
2023-08-24 16:12 ` Herve Codina
2023-08-24 16:12 ` Herve Codina
2023-08-18 16:39 ` [PATCH v4 07/28] net: wan: " Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 08/28] MAINTAINERS: Add the Freescale QMC HDLC driver entry Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 09/28] soc: fsl: cpm1: qmc: Introduce available timeslots masks Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 10/28] soc: fsl: cpm1: qmc: Rename qmc_setup_tsa* to qmc_init_tsa* Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 11/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa* Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 12/28] soc: fsl: cpm1: qmc: Remove no more needed checks from qmc_check_chans() Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 13/28] soc: fsl: cpm1: qmc: Check available timeslots in qmc_check_chans() Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 14/28] soc: fsl: cpm1: qmc: Add support for disabling channel TSA entries Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 15/28] soc: fsl: cpm1: qmc: Split Tx and Rx TSA entries setup Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 16/28] soc: fsl: cpm1: qmc: Introduce is_tsa_64rxtx flag Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 17/28] soc: fsl: cpm1: qmc: Handle timeslot entries at channel start() and stop() Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 18/28] soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan() Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 19/28] soc: fsl: cpm1: qmc: Introduce functions to change timeslots at runtime Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 20/28] wan: qmc_hdlc: Add runtime timeslots changes support Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-21 5:40 ` Christophe JAILLET
2023-08-21 5:40 ` Christophe JAILLET
2023-08-21 5:40 ` Christophe JAILLET
2023-08-24 16:32 ` Herve Codina
2023-08-24 16:32 ` Herve Codina
2023-08-24 16:32 ` Herve Codina
2023-08-18 16:39 ` [PATCH v4 21/28] net: wan: Add framer framework support Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-19 2:46 ` Jakub Kicinski
2023-08-19 2:46 ` Jakub Kicinski
2023-08-19 2:46 ` Jakub Kicinski
2023-08-20 17:15 ` Simon Horman
2023-08-20 17:15 ` Simon Horman
2023-08-20 17:15 ` Simon Horman
2023-08-24 16:44 ` Herve Codina
2023-08-24 16:44 ` Herve Codina
2023-08-24 16:44 ` Herve Codina
2023-08-20 21:06 ` Linus Walleij
2023-08-20 21:06 ` Linus Walleij
2023-08-20 21:06 ` Linus Walleij
2023-08-21 5:19 ` Christophe Leroy
2023-08-21 5:19 ` Christophe Leroy
2023-08-21 5:19 ` Christophe Leroy
2023-08-21 7:21 ` Linus Walleij
2023-08-21 7:21 ` Linus Walleij
2023-08-21 7:21 ` Linus Walleij
2023-08-21 18:52 ` Jakub Kicinski
2023-08-21 18:52 ` Jakub Kicinski
2023-08-21 18:52 ` Jakub Kicinski
2023-08-21 6:02 ` Christophe JAILLET
2023-08-21 6:02 ` Christophe JAILLET
2023-08-21 6:02 ` Christophe JAILLET
2023-08-24 16:37 ` Herve Codina
2023-08-24 16:37 ` Herve Codina
2023-08-24 16:37 ` Herve Codina
2023-08-18 16:39 ` [PATCH v4 22/28] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-21 20:49 ` Rob Herring
2023-08-21 20:49 ` Rob Herring
2023-08-21 20:49 ` Rob Herring
2023-08-21 20:49 ` Rob Herring
2023-08-24 16:28 ` Herve Codina
2023-08-24 16:28 ` Herve Codina
2023-08-24 16:28 ` Herve Codina
2023-08-24 16:28 ` Herve Codina
2023-08-18 16:39 ` [PATCH v4 23/28] mfd: core: Ensure disabled devices are skiped without aborting Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-21 12:17 ` Lee Jones [this message]
2023-08-21 12:17 ` Lee Jones
2023-08-21 12:17 ` Lee Jones
2023-09-20 9:34 ` (subset) " Lee Jones
2023-09-20 9:34 ` Lee Jones
2023-09-20 9:34 ` Lee Jones
2023-08-18 16:39 ` [PATCH v4 24/28] net: wan: framer: Add support for the Lantiq PEF2256 framer Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 25/28] pinctrl: Add support for the Lantic PEF2256 pinmux Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 26/28] MAINTAINERS: Add the Lantiq PEF2256 driver entry Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 27/28] ASoC: codecs: Add support for the framer codec Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 23:18 ` Randy Dunlap
2023-08-18 23:18 ` Randy Dunlap
2023-08-18 23:18 ` Randy Dunlap
2023-08-19 8:57 ` Christophe Leroy
2023-08-19 8:57 ` Christophe Leroy
2023-08-19 8:57 ` Christophe Leroy
2023-08-18 16:39 ` [PATCH v4 28/28] net: wan: fsl_qmc_hdlc: Add framer support Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
2023-08-18 16:39 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230821121721.GH1380343@google.com \
--to=lee@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=pabeni@redhat.com \
--cc=perex@perex.cz \
--cc=qiang.zhao@nxp.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.