From: Lee Jones <lee@kernel.org>
To: lee@kernel.org
Cc: linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Jonathan Hunter <jonathanh@nvidia.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org
Subject: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored
Date: Thu, 24 Aug 2023 08:37:00 +0100 [thread overview]
Message-ID: <20230824073710.2677348-16-lee@kernel.org> (raw)
In-Reply-To: <20230824073710.2677348-1-lee@kernel.org>
When converting from int to string, we must allow for up to 10-chars (2147483647).
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-tegra@vger.kernel.org
---
drivers/gpu/drm/tegra/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c
index 1af5f8318d914..f21e57e8599ee 100644
--- a/drivers/gpu/drm/tegra/hub.c
+++ b/drivers/gpu/drm/tegra/hub.c
@@ -1101,7 +1101,7 @@ static int tegra_display_hub_probe(struct platform_device *pdev)
for (i = 0; i < hub->soc->num_wgrps; i++) {
struct tegra_windowgroup *wgrp = &hub->wgrps[i];
- char id[8];
+ char id[16];
snprintf(id, sizeof(id), "wgrp%u", i);
mutex_init(&wgrp->lock);
--
2.42.0.rc1.204.g551eb34607-goog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: lee@kernel.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Jonathan Hunter <jonathanh@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-tegra@vger.kernel.org,
Mikko Perttunen <mperttunen@nvidia.com>
Subject: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored
Date: Thu, 24 Aug 2023 08:37:00 +0100 [thread overview]
Message-ID: <20230824073710.2677348-16-lee@kernel.org> (raw)
In-Reply-To: <20230824073710.2677348-1-lee@kernel.org>
When converting from int to string, we must allow for up to 10-chars (2147483647).
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-tegra@vger.kernel.org
---
drivers/gpu/drm/tegra/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c
index 1af5f8318d914..f21e57e8599ee 100644
--- a/drivers/gpu/drm/tegra/hub.c
+++ b/drivers/gpu/drm/tegra/hub.c
@@ -1101,7 +1101,7 @@ static int tegra_display_hub_probe(struct platform_device *pdev)
for (i = 0; i < hub->soc->num_wgrps; i++) {
struct tegra_windowgroup *wgrp = &hub->wgrps[i];
- char id[8];
+ char id[16];
snprintf(id, sizeof(id), "wgrp%u", i);
mutex_init(&wgrp->lock);
--
2.42.0.rc1.204.g551eb34607-goog
next prev parent reply other threads:[~2023-08-24 7:38 UTC|newest]
Thread overview: 159+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 7:36 [PATCH (set 1) 00/20] Rid W=1 warnings from GPU Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` [Nouveau] " Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-28 16:39 ` Laurent Pinchart
2023-08-28 16:39 ` Laurent Pinchart
2023-08-28 16:39 ` Laurent Pinchart
2023-08-28 19:33 ` Randy Dunlap
2023-08-28 19:33 ` Randy Dunlap
2023-08-28 19:33 ` Randy Dunlap
2023-08-24 7:36 ` [Nouveau] [PATCH 02/20] drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc' Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` [Nouveau] [PATCH 03/20] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 8:41 ` [Nouveau] " Karol Herbst
2023-08-24 8:41 ` Karol Herbst
2023-08-24 8:41 ` Karol Herbst
2023-08-24 7:36 ` [Nouveau] [PATCH 04/20] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 8:41 ` [Nouveau] " Karol Herbst
2023-08-24 8:41 ` Karol Herbst
2023-08-24 8:41 ` Karol Herbst
2023-08-24 7:36 ` [Nouveau] [PATCH 05/20] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 8:41 ` [Nouveau] " Karol Herbst
2023-08-24 8:41 ` Karol Herbst
2023-08-24 8:41 ` Karol Herbst
2023-08-24 7:36 ` [Nouveau] [PATCH 06/20] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 8:42 ` [Nouveau] " Karol Herbst
2023-08-24 8:42 ` Karol Herbst
2023-08-24 8:42 ` Karol Herbst
2023-08-24 7:36 ` [PATCH 07/20] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move() Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 14:53 ` Alex Deucher
2023-08-24 14:53 ` Alex Deucher
2023-08-24 14:53 ` Alex Deucher
2023-08-24 7:36 ` [PATCH 08/20] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` [PATCH 09/20] drm/tests/drm_kunit_helpers: Place correct function name in the comment header Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` [PATCH 10/20] drm/scheduler/sched_main: Provide short description of missing param 'result' Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 9:42 ` [Linaro-mm-sig] " Christian König
2023-08-24 9:42 ` Christian König
2023-08-24 7:36 ` [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index' Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 8:25 ` Sharma, Shashank
2023-08-24 8:25 ` Sharma, Shashank
2023-08-24 8:25 ` Sharma, Shashank
2023-08-24 14:59 ` Alex Deucher
2023-08-24 14:59 ` Alex Deucher
2023-08-24 7:36 ` [PATCH 12/20] drm/amd/amdgpu/amdgpu_device: Provide suitable description for param 'xcc_id' Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 14:54 ` Alex Deucher
2023-08-24 14:54 ` Alex Deucher
2023-08-24 14:54 ` Alex Deucher
2023-08-24 7:36 ` [PATCH 13/20] drm/tests/drm_kunit_helpers: Correct possible double-entry typo in 'ddrm_kunit_helper_acquire_ctx_alloc' Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 8:53 ` Maxime Ripard
2023-08-24 8:53 ` Maxime Ripard
2023-08-24 12:11 ` Lee Jones
2023-08-24 12:11 ` Lee Jones
2023-08-24 7:36 ` [PATCH 14/20] drm/imx/ipuv3/imx-ldb: Increase buffer size to ensure all possible values can be stored Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:36 ` Lee Jones
2023-08-24 7:37 ` Lee Jones [this message]
2023-08-24 7:37 ` [PATCH 15/20] drm/tegra/hub: " Lee Jones
2023-08-24 9:25 ` Thierry Reding
2023-08-24 9:25 ` Thierry Reding
2023-08-24 9:33 ` Jani Nikula
2023-08-24 9:33 ` Jani Nikula
2023-08-24 12:01 ` Lee Jones
2023-08-24 12:01 ` Lee Jones
2023-08-24 13:45 ` Thierry Reding
2023-08-24 13:45 ` Thierry Reding
2023-08-24 7:37 ` [PATCH 16/20] drm/drm_connector: Provide short description of param 'supported_colorspaces' Lee Jones
2023-08-24 7:37 ` Lee Jones
2023-08-24 9:00 ` (subset) " Maxime Ripard
2023-08-24 9:00 ` Maxime Ripard
2023-08-24 7:37 ` [PATCH 17/20] drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all possible values Lee Jones
2023-08-24 7:37 ` Lee Jones
2023-08-24 7:37 ` Lee Jones
2023-08-24 14:55 ` Alex Deucher
2023-08-24 14:55 ` Alex Deucher
2023-08-24 14:55 ` Alex Deucher
2023-08-24 7:37 ` [PATCH 18/20] drm/drm_gpuva_mgr: Remove set but unused variable 'prev' Lee Jones
2023-08-24 7:37 ` Lee Jones
2023-08-24 12:53 ` Danilo Krummrich
2023-08-24 12:53 ` Danilo Krummrich
2023-08-24 7:37 ` [PATCH 19/20] drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all possible values Lee Jones
2023-08-24 7:37 ` Lee Jones
2023-08-24 7:37 ` Lee Jones
2023-08-24 14:56 ` Alex Deucher
2023-08-24 14:56 ` Alex Deucher
2023-08-24 14:56 ` Alex Deucher
2023-08-24 7:37 ` [PATCH 20/20] drm/amd/amdgpu/imu_v11_0: Increase buffer size to ensure all possible values can be stored Lee Jones
2023-08-24 7:37 ` Lee Jones
2023-08-24 7:37 ` Lee Jones
2023-08-24 14:57 ` Alex Deucher
2023-08-24 14:57 ` Alex Deucher
2023-08-24 14:57 ` Alex Deucher
2023-08-24 8:59 ` [PATCH (set 1) 00/20] Rid W=1 warnings from GPU Maxime Ripard
2023-08-24 8:59 ` Maxime Ripard
2023-08-24 8:59 ` Maxime Ripard
2023-08-24 8:59 ` [Nouveau] " Maxime Ripard
2023-08-24 8:59 ` Maxime Ripard
2023-08-24 9:03 ` Maxime Ripard
2023-08-24 9:03 ` Maxime Ripard
2023-08-24 9:03 ` Maxime Ripard
2023-08-24 9:03 ` [Nouveau] " Maxime Ripard
2023-08-24 9:03 ` Maxime Ripard
2023-08-24 12:10 ` Lee Jones
2023-08-24 12:10 ` Lee Jones
2023-08-24 12:10 ` Lee Jones
2023-08-24 12:10 ` [Nouveau] " Lee Jones
2023-08-24 12:10 ` Lee Jones
2023-08-24 9:03 ` Jani Nikula
2023-08-24 9:03 ` Jani Nikula
2023-08-24 9:03 ` [Nouveau] " Jani Nikula
2023-08-24 9:03 ` Jani Nikula
2023-08-24 9:16 ` Maxime Ripard
2023-08-24 9:16 ` Maxime Ripard
2023-08-24 9:16 ` [Nouveau] " Maxime Ripard
2023-08-24 9:16 ` Maxime Ripard
2023-08-24 12:07 ` Lee Jones
2023-08-24 12:07 ` Lee Jones
2023-08-24 12:07 ` [Nouveau] " Lee Jones
2023-08-24 12:07 ` Lee Jones
2023-08-24 12:08 ` Lee Jones
2023-08-24 12:08 ` Lee Jones
2023-08-24 12:08 ` [Nouveau] " Lee Jones
2023-08-24 12:08 ` Lee Jones
2023-08-24 12:14 ` Hamza Mahfooz
2023-08-24 12:14 ` Hamza Mahfooz
2023-08-24 12:14 ` [Nouveau] " Hamza Mahfooz
2023-08-24 12:14 ` Hamza Mahfooz
2023-08-24 12:24 ` Lee Jones
2023-08-24 12:24 ` Lee Jones
2023-08-24 12:24 ` Lee Jones
2023-08-24 12:24 ` [Nouveau] " Lee Jones
2023-08-24 12:24 ` Lee Jones
2023-08-28 16:11 ` Michel Dänzer
2023-08-28 16:11 ` Michel Dänzer
2023-08-28 16:11 ` [Nouveau] " Michel Dänzer
2023-08-28 16:11 ` Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824073710.2677348-16-lee@kernel.org \
--to=lee@kernel.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=p.zabel@pengutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.