All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Haller <thaller@redhat.com>
To: NetFilter <netfilter-devel@vger.kernel.org>
Cc: Thomas Haller <thaller@redhat.com>
Subject: [PATCH nft 4/6] configure: use AC_USE_SYSTEM_EXTENSIONS to get _GNU_SOURCE
Date: Thu, 24 Aug 2023 13:13:32 +0200	[thread overview]
Message-ID: <20230824111456.2005125-5-thaller@redhat.com> (raw)
In-Reply-To: <20230824111456.2005125-1-thaller@redhat.com>

Let "configure" detect which features are available. Also, nftables is a
Linux project, so portability beyond gcc/clang and glibc/musl is less
relevant. And even if it were, then feature detection by "configure"
would still be preferable.

Use AC_USE_SYSTEM_EXTENSIONS ([1]).

Apparently available since autoconf 2.60, from 2006 ([2]).

[1] https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Posix-Variants.html#index-AC_005fUSE_005fSYSTEM_005fEXTENSIONS-1046
[2] https://lists.gnu.org/archive/html/autoconf/2006-06/msg00111.html

Signed-off-by: Thomas Haller <thaller@redhat.com>
---
 configure.ac         | 3 +++
 include/nftdefault.h | 2 --
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 42f0dc4cf392..9d859307adaa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -45,6 +45,9 @@ fi
 AM_PROG_AR
 LT_INIT([disable-static])
 AM_PROG_CC_C_O
+
+AC_USE_SYSTEM_EXTENSIONS
+
 AC_EXEEXT
 CHECK_GCC_FVISIBILITY
 
diff --git a/include/nftdefault.h b/include/nftdefault.h
index b7ebad7fddc0..0912cd188850 100644
--- a/include/nftdefault.h
+++ b/include/nftdefault.h
@@ -2,8 +2,6 @@
 #ifndef NFTABLES_NFTDEFAULT_H
 #define NFTABLES_NFTDEFAULT_H
 
-#define _GNU_SOURCE
-
 #include <config.h>
 
 #endif /* NFTABLES_NFTDEFAULT_H */
-- 
2.41.0


  parent reply	other threads:[~2023-08-24 11:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24 11:13 [PATCH nft 0/6] cleanup base includes and add <nftdefault.h> header Thomas Haller
2023-08-24 11:13 ` [PATCH nft 1/6] meta: define _GNU_SOURCE to get strptime() from <time.h> Thomas Haller
2023-08-24 11:13 ` [PATCH nft 2/6] src: add <nftdefault.h> header and include it as first Thomas Haller
2023-08-24 11:13 ` [PATCH nft 3/6] include: don't define _GNU_SOURCE in public header Thomas Haller
2023-08-24 11:13 ` Thomas Haller [this message]
2023-08-24 11:46   ` [PATCH nft 4/6] configure: use AC_USE_SYSTEM_EXTENSIONS to get _GNU_SOURCE Thomas Haller
2023-08-24 11:13 ` [PATCH nft 5/6] include: include <std{bool,int}.h> via nftdefault.h Thomas Haller
2023-08-24 11:13 ` [PATCH nft 6/6] configure: drop AM_PROG_CC_C_O autoconf check Thomas Haller
2023-08-24 12:54 ` [PATCH nft 0/6] cleanup base includes and add <nftdefault.h> header Pablo Neira Ayuso
2023-08-24 13:18   ` Thomas Haller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230824111456.2005125-5-thaller@redhat.com \
    --to=thaller@redhat.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.