Re: [PATCH nft 0/6] cleanup base includes and add <nftdefault.h> header

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Thu, Aug 24, 2023 at 01:13:28PM +0200, Thomas Haller wrote:
> - cleanup _GNU_SOURCE/_XOPEN_SOURCE handling
> - ensure <config.h> is included as first (via <nftdefault.h> header)
> - add <nftdefault.h> to provide a base header that is included
>   everywhere.

Could you use include/nft.h instead?

> Thomas Haller (6):
>   meta: define _GNU_SOURCE to get strptime() from <time.h>
>   src: add <nftdefault.h> header and include it as first
>   include: don't define _GNU_SOURCE in public header
>   configure: use AC_USE_SYSTEM_EXTENSIONS to get _GNU_SOURCE
>   include: include <std{bool,int}.h> via nftdefault.h
>   configure: drop AM_PROG_CC_C_O autoconf check
> 
>  configure.ac                   |  4 +++-
>  include/Makefile.am            |  3 ++-
>  include/cli.h                  |  1 -
>  include/datatype.h             |  1 -
>  include/dccpopt.h              |  1 -
>  include/expression.h           |  1 -
>  include/gmputil.h              |  2 --
>  include/nftables.h             |  1 -
>  include/nftables/libnftables.h |  1 -
>  include/nftdefault.h           | 10 ++++++++++
>  include/rule.h                 |  1 -
>  include/utils.h                |  3 ---
>  src/cache.c                    |  2 ++
>  src/cli.c                      |  3 ++-
>  src/cmd.c                      |  2 ++
>  src/ct.c                       |  2 ++
>  src/datatype.c                 |  2 ++
>  src/dccpopt.c                  |  3 ++-
>  src/erec.c                     |  4 ++--
>  src/evaluate.c                 |  3 ++-
>  src/expression.c               |  3 ++-
>  src/exthdr.c                   |  3 ++-
>  src/fib.c                      |  2 ++
>  src/gmputil.c                  |  2 ++
>  src/hash.c                     |  2 ++
>  src/iface.c                    |  2 ++
>  src/intervals.c                |  2 ++
>  src/ipopt.c                    |  3 ++-
>  src/json.c                     |  3 ++-
>  src/libnftables.c              |  3 +++
>  src/main.c                     |  2 ++
>  src/mergesort.c                |  3 ++-
>  src/meta.c                     |  8 +++-----
>  src/mini-gmp.c                 |  2 ++
>  src/misspell.c                 |  2 ++
>  src/mnl.c                      |  2 ++
>  src/monitor.c                  |  2 ++
>  src/netlink.c                  |  2 ++
>  src/netlink_delinearize.c      |  3 ++-
>  src/netlink_linearize.c        |  2 ++
>  src/nfnl_osf.c                 |  2 ++
>  src/nftutils.c                 |  3 +--
>  src/nftutils.h                 |  1 -
>  src/numgen.c                   |  2 ++
>  src/optimize.c                 |  3 ++-
>  src/osf.c                      |  2 ++
>  src/owner.c                    |  2 ++
>  src/parser_json.c              |  4 ++--
>  src/payload.c                  |  3 ++-
>  src/print.c                    |  2 ++
>  src/proto.c                    |  3 ++-
>  src/rt.c                       |  3 ++-
>  src/rule.c                     |  3 ++-
>  src/scanner.l                  |  2 ++
>  src/sctp_chunk.c               |  2 ++
>  src/segtree.c                  |  2 ++
>  src/socket.c                   |  2 ++
>  src/statement.c                |  3 ++-
>  src/tcpopt.c                   |  3 ++-
>  src/utils.c                    |  2 ++
>  src/xfrm.c                     |  2 ++
>  src/xt.c                       |  2 ++
>  62 files changed, 114 insertions(+), 42 deletions(-)
>  create mode 100644 include/nftdefault.h
> 
> -- 
> 2.41.0
>