All of lore.kernel.org
 help / color / mirror / Atom feed
From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: <linux-phy@lists.infradead.org>, <linux-arm-msm@vger.kernel.org>,
	<andersson@kernel.org>, <vkoul@kernel.org>
Subject: Re: [PATCH -next] phy: qcom: phy-qcom-m31: fix wrong pointer pass to PTR_ERR()
Date: Thu, 24 Aug 2023 17:02:40 +0530	[thread overview]
Message-ID: <20230824113240.GB15057@varda-linux.qualcomm.com> (raw)
In-Reply-To: <20230824091345.1072650-1-yangyingliang@huawei.com>

On Thu, Aug 24, 2023 at 05:13:45PM +0800, Yang Yingliang wrote:
> It should be 'qphy->vreg' passed to PTR_ERR() when devm_regulator_get() fails.
> 
> Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/phy/qualcomm/phy-qcom-m31.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c
> index ed08072ca032..99d570f4142a 100644
> --- a/drivers/phy/qualcomm/phy-qcom-m31.c
> +++ b/drivers/phy/qualcomm/phy-qcom-m31.c
> @@ -256,7 +256,7 @@ static int m31usb_phy_probe(struct platform_device *pdev)
>  
>  	qphy->vreg = devm_regulator_get(dev, "vdda-phy");
>  	if (IS_ERR(qphy->vreg))
> -		return dev_err_probe(dev, PTR_ERR(qphy->phy),
> +		return dev_err_probe(dev, PTR_ERR(qphy->vreg),
>  						"failed to get vreg\n");

Reviewed-by: Varadarajan Narayanan <quic_varada@quicinc.com>

Thanks
Varada

>  
>  	phy_set_drvdata(qphy->phy, qphy);
> -- 
> 2.25.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: <linux-phy@lists.infradead.org>, <linux-arm-msm@vger.kernel.org>,
	<andersson@kernel.org>, <vkoul@kernel.org>
Subject: Re: [PATCH -next] phy: qcom: phy-qcom-m31: fix wrong pointer pass to PTR_ERR()
Date: Thu, 24 Aug 2023 17:02:40 +0530	[thread overview]
Message-ID: <20230824113240.GB15057@varda-linux.qualcomm.com> (raw)
In-Reply-To: <20230824091345.1072650-1-yangyingliang@huawei.com>

On Thu, Aug 24, 2023 at 05:13:45PM +0800, Yang Yingliang wrote:
> It should be 'qphy->vreg' passed to PTR_ERR() when devm_regulator_get() fails.
> 
> Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/phy/qualcomm/phy-qcom-m31.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c
> index ed08072ca032..99d570f4142a 100644
> --- a/drivers/phy/qualcomm/phy-qcom-m31.c
> +++ b/drivers/phy/qualcomm/phy-qcom-m31.c
> @@ -256,7 +256,7 @@ static int m31usb_phy_probe(struct platform_device *pdev)
>  
>  	qphy->vreg = devm_regulator_get(dev, "vdda-phy");
>  	if (IS_ERR(qphy->vreg))
> -		return dev_err_probe(dev, PTR_ERR(qphy->phy),
> +		return dev_err_probe(dev, PTR_ERR(qphy->vreg),
>  						"failed to get vreg\n");

Reviewed-by: Varadarajan Narayanan <quic_varada@quicinc.com>

Thanks
Varada

>  
>  	phy_set_drvdata(qphy->phy, qphy);
> -- 
> 2.25.1
> 

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2023-08-24 11:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24  9:13 [PATCH -next] phy: qcom: phy-qcom-m31: fix wrong pointer pass to PTR_ERR() Yang Yingliang
2023-08-24  9:13 ` Yang Yingliang
2023-08-24 11:32 ` Varadarajan Narayanan [this message]
2023-08-24 11:32   ` Varadarajan Narayanan
2023-09-21 14:26 ` Vinod Koul
2023-09-21 14:26   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230824113240.GB15057@varda-linux.qualcomm.com \
    --to=quic_varada@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=vkoul@kernel.org \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.