All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Lucas Tanure <tanure@linux.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2] Revert "tty: serial: meson: Add a earlycon for the T7 SoC"
Date: Mon, 28 Aug 2023 16:47:09 +0200	[thread overview]
Message-ID: <2023082803-alone-tingle-b639@gregkh> (raw)
In-Reply-To: <944f1370-c092-484e-a13d-b7f8211c4835@linaro.org>

On Mon, Aug 28, 2023 at 02:31:06PM +0200, Neil Armstrong wrote:
> Hi Greg,
> 
> On 27/08/2023 10:29, Lucas Tanure wrote:
> > This reverts commit 6a4197f9763325043abf7690a21124a9facbf52e.
> > New SoC will use ttyS0 instead of ttyAML, so T7 SoC doesn't need a OF_EARLYCON_DECLARE.
> > 
> > Signed-off-by: Lucas Tanure <tanure@linux.com>
> > ---
> > Since V1:
> > - add Signed-off-by:
> > 
> >   drivers/tty/serial/meson_uart.c | 2 --
> >   1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> > index c4f61d82fb727..790d910dafa5d 100644
> > --- a/drivers/tty/serial/meson_uart.c
> > +++ b/drivers/tty/serial/meson_uart.c
> > @@ -648,8 +648,6 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
> >   OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
> >   		    meson_serial_early_console_setup);
> > -OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart",
> > -		    meson_serial_early_console_setup);
> >   #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
> >   #else
> 
> After some clarifications, it's ok to merge the revert:
> 
> Acked-by: Neil Armstrong <neil.armstrong@linaro.org>

Already merged :)

thanks,

greg k-h

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Lucas Tanure <tanure@linux.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2] Revert "tty: serial: meson: Add a earlycon for the T7 SoC"
Date: Mon, 28 Aug 2023 16:47:09 +0200	[thread overview]
Message-ID: <2023082803-alone-tingle-b639@gregkh> (raw)
In-Reply-To: <944f1370-c092-484e-a13d-b7f8211c4835@linaro.org>

On Mon, Aug 28, 2023 at 02:31:06PM +0200, Neil Armstrong wrote:
> Hi Greg,
> 
> On 27/08/2023 10:29, Lucas Tanure wrote:
> > This reverts commit 6a4197f9763325043abf7690a21124a9facbf52e.
> > New SoC will use ttyS0 instead of ttyAML, so T7 SoC doesn't need a OF_EARLYCON_DECLARE.
> > 
> > Signed-off-by: Lucas Tanure <tanure@linux.com>
> > ---
> > Since V1:
> > - add Signed-off-by:
> > 
> >   drivers/tty/serial/meson_uart.c | 2 --
> >   1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> > index c4f61d82fb727..790d910dafa5d 100644
> > --- a/drivers/tty/serial/meson_uart.c
> > +++ b/drivers/tty/serial/meson_uart.c
> > @@ -648,8 +648,6 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
> >   OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
> >   		    meson_serial_early_console_setup);
> > -OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart",
> > -		    meson_serial_early_console_setup);
> >   #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
> >   #else
> 
> After some clarifications, it's ok to merge the revert:
> 
> Acked-by: Neil Armstrong <neil.armstrong@linaro.org>

Already merged :)

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Lucas Tanure <tanure@linux.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2] Revert "tty: serial: meson: Add a earlycon for the T7 SoC"
Date: Mon, 28 Aug 2023 16:47:09 +0200	[thread overview]
Message-ID: <2023082803-alone-tingle-b639@gregkh> (raw)
In-Reply-To: <944f1370-c092-484e-a13d-b7f8211c4835@linaro.org>

On Mon, Aug 28, 2023 at 02:31:06PM +0200, Neil Armstrong wrote:
> Hi Greg,
> 
> On 27/08/2023 10:29, Lucas Tanure wrote:
> > This reverts commit 6a4197f9763325043abf7690a21124a9facbf52e.
> > New SoC will use ttyS0 instead of ttyAML, so T7 SoC doesn't need a OF_EARLYCON_DECLARE.
> > 
> > Signed-off-by: Lucas Tanure <tanure@linux.com>
> > ---
> > Since V1:
> > - add Signed-off-by:
> > 
> >   drivers/tty/serial/meson_uart.c | 2 --
> >   1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> > index c4f61d82fb727..790d910dafa5d 100644
> > --- a/drivers/tty/serial/meson_uart.c
> > +++ b/drivers/tty/serial/meson_uart.c
> > @@ -648,8 +648,6 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
> >   OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
> >   		    meson_serial_early_console_setup);
> > -OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart",
> > -		    meson_serial_early_console_setup);
> >   #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
> >   #else
> 
> After some clarifications, it's ok to merge the revert:
> 
> Acked-by: Neil Armstrong <neil.armstrong@linaro.org>

Already merged :)

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-08-28 14:47 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-27  8:29 [PATCH v2] Revert "tty: serial: meson: Add a earlycon for the T7 SoC" Lucas Tanure
2023-08-27  8:29 ` Lucas Tanure
2023-08-27  8:29 ` Lucas Tanure
2023-08-27  9:48 ` Neil Armstrong
2023-08-27  9:48   ` Neil Armstrong
2023-08-27  9:48   ` Neil Armstrong
2023-08-27 10:04   ` Lucas Tanure
2023-08-27 10:04     ` Lucas Tanure
2023-08-27 10:04     ` Lucas Tanure
2023-08-27 10:23     ` Neil Armstrong
2023-08-27 10:23       ` Neil Armstrong
2023-08-27 10:23       ` Neil Armstrong
2023-08-27 10:31       ` Lucas Tanure
2023-08-27 10:31         ` Lucas Tanure
2023-08-27 10:31         ` Lucas Tanure
2023-08-28  7:58         ` Neil Armstrong
2023-08-28  7:58           ` Neil Armstrong
2023-08-28  7:58           ` Neil Armstrong
2023-08-28  8:20         ` Dmitry Rokosov
2023-08-28  8:20           ` Dmitry Rokosov
2023-08-28  8:20           ` Dmitry Rokosov
2023-08-28  8:23           ` Neil Armstrong
2023-08-28  8:23             ` Neil Armstrong
2023-08-28  8:23             ` Neil Armstrong
2023-08-28  8:46             ` Dmitry Rokosov
2023-08-28  8:46               ` Dmitry Rokosov
2023-08-28  8:46               ` Dmitry Rokosov
2023-08-28  8:47               ` Lucas Tanure
2023-08-28  8:47                 ` Lucas Tanure
2023-08-28  8:47                 ` Lucas Tanure
2023-08-28  8:50                 ` Neil Armstrong
2023-08-28  8:50                   ` Neil Armstrong
2023-08-28  8:50                   ` Neil Armstrong
2023-08-28 12:31 ` Neil Armstrong
2023-08-28 12:31   ` Neil Armstrong
2023-08-28 12:31   ` Neil Armstrong
2023-08-28 14:47   ` Greg Kroah-Hartman [this message]
2023-08-28 14:47     ` Greg Kroah-Hartman
2023-08-28 14:47     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023082803-alone-tingle-b639@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=tanure@linux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.