Re: [meta-ti][master][PATCH] ti-img-rogue-umlibs: Add DEPENDS on BASE_DEFAULT_DEPS

[Denys Dmytriyenko <denis@denix.org>]

On Mon, Aug 28, 2023 at 04:13:48PM -0500, Ryan Eatmon wrote:
> 
> 
> On 8/28/2023 3:45 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
> >
> >
> >On 8/28/2023 3:39 PM, Denys Dmytriyenko wrote:
> >>On Mon, Aug 28, 2023 at 03:22:11PM -0500, Ryan Eatmon via
> >>lists.yoctoproject.org wrote:
> >>>A recent change to oe-core [1], has caused a pile of QA errors during
> >>>packaging for this binary package.  The effect of the change in oe-core
> >>>was to remove the dependency on the compiler and other compiler adjacent
> >>>libraries.  But the binary packages need some of the compiler tools as
> >>>part of the packaging flow (ie. objdump).
> >>>
> >>>Until the above gets reverted, this patch will fix the issue and can be
> >>>reverted itself once oe-core is fixed.
> >>>
> >>>[1] https://git.openembedded.org/openembedded-core/commit/?h=master&id=d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727
> >>
> >>Why not simply reset INHIBIT_DEFAULT_DEPS in the recipe?
> >
> >Good question.  Let me try that.  It should work, but I want to be sure.
> 
> huh...  It didn't work...
> 
> 
> inherit bin_package
> 
> INHIBIT_DEFAULT_DEPS = "0"
> 
> 
> That gave the same build errors....
> 
> 
> Here is code that is using the variable:
> 
> def get_base_dep(d):
>     if d.getVar('INHIBIT_DEFAULT_DEPS', False):
>         return ""
>     return "${BASE_DEFAULT_DEPS}"

Ah, right, it doesn't check for the value, just the fact that the variable is 
defined. Could try unset or d.delVar()... But, revert in OE-Core does make 
perfect sense. Today is a holiday in the UK, so Richard is out until tomorrow.


> >>>Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> >>>---
> >>>  .../powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb          | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>>diff --git a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
> >>>index f748bd0f..73de93e5 100644
> >>>--- a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
> >>>+++ b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
> >>>@@ -37,6 +37,8 @@ PACKAGECONFIG[opengl] = ",,,,${GLES_PACKAGES}"
> >>>  PACKAGECONFIG[vulkan] = ",,,,${VULKAN_PACKAGES}"
> >>>  PACKAGECONFIG[opencl] = ",,,,${OPENCL_PACKAGES}"
> >>>+DEPENDS:prepend = "${BASE_DEFAULT_DEPS} "
> >>>+
> >>>  def get_file_list(package_list_var, d):
> >>>      file_list = []
> >>>      package_list = d.getVar(package_list_var)
> >>>-- 
> >>>2.17.1