All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-ti][master][PATCH] ti-img-rogue-umlibs: Add DEPENDS on BASE_DEFAULT_DEPS
@ 2023-08-28 20:22 Ryan Eatmon
  2023-08-28 20:39 ` Denys Dmytriyenko
  0 siblings, 1 reply; 6+ messages in thread
From: Ryan Eatmon @ 2023-08-28 20:22 UTC (permalink / raw)
  To: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti

A recent change to oe-core [1], has caused a pile of QA errors during
packaging for this binary package.  The effect of the change in oe-core
was to remove the dependency on the compiler and other compiler adjacent
libraries.  But the binary packages need some of the compiler tools as
part of the packaging flow (ie. objdump).

Until the above gets reverted, this patch will fix the issue and can be
reverted itself once oe-core is fixed.

[1] https://git.openembedded.org/openembedded-core/commit/?h=master&id=d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727

Signed-off-by: Ryan Eatmon <reatmon@ti.com>
---
 .../powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb          | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
index f748bd0f..73de93e5 100644
--- a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
+++ b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
@@ -37,6 +37,8 @@ PACKAGECONFIG[opengl] = ",,,,${GLES_PACKAGES}"
 PACKAGECONFIG[vulkan] = ",,,,${VULKAN_PACKAGES}"
 PACKAGECONFIG[opencl] = ",,,,${OPENCL_PACKAGES}"
 
+DEPENDS:prepend = "${BASE_DEFAULT_DEPS} "
+
 def get_file_list(package_list_var, d):
     file_list = []
     package_list = d.getVar(package_list_var)
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [meta-ti][master][PATCH] ti-img-rogue-umlibs: Add DEPENDS on BASE_DEFAULT_DEPS
  2023-08-28 20:22 [meta-ti][master][PATCH] ti-img-rogue-umlibs: Add DEPENDS on BASE_DEFAULT_DEPS Ryan Eatmon
@ 2023-08-28 20:39 ` Denys Dmytriyenko
  2023-08-28 20:45   ` Ryan Eatmon
       [not found]   ` <177FA6F1CCEC185E.29216@lists.yoctoproject.org>
  0 siblings, 2 replies; 6+ messages in thread
From: Denys Dmytriyenko @ 2023-08-28 20:39 UTC (permalink / raw)
  To: reatmon; +Cc: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti

On Mon, Aug 28, 2023 at 03:22:11PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
> A recent change to oe-core [1], has caused a pile of QA errors during
> packaging for this binary package.  The effect of the change in oe-core
> was to remove the dependency on the compiler and other compiler adjacent
> libraries.  But the binary packages need some of the compiler tools as
> part of the packaging flow (ie. objdump).
> 
> Until the above gets reverted, this patch will fix the issue and can be
> reverted itself once oe-core is fixed.
> 
> [1] https://git.openembedded.org/openembedded-core/commit/?h=master&id=d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727

Why not simply reset INHIBIT_DEFAULT_DEPS in the recipe?


> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> ---
>  .../powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb          | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
> index f748bd0f..73de93e5 100644
> --- a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
> +++ b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
> @@ -37,6 +37,8 @@ PACKAGECONFIG[opengl] = ",,,,${GLES_PACKAGES}"
>  PACKAGECONFIG[vulkan] = ",,,,${VULKAN_PACKAGES}"
>  PACKAGECONFIG[opencl] = ",,,,${OPENCL_PACKAGES}"
>  
> +DEPENDS:prepend = "${BASE_DEFAULT_DEPS} "
> +
>  def get_file_list(package_list_var, d):
>      file_list = []
>      package_list = d.getVar(package_list_var)
> -- 
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-ti][master][PATCH] ti-img-rogue-umlibs: Add DEPENDS on BASE_DEFAULT_DEPS
  2023-08-28 20:39 ` Denys Dmytriyenko
@ 2023-08-28 20:45   ` Ryan Eatmon
       [not found]   ` <177FA6F1CCEC185E.29216@lists.yoctoproject.org>
  1 sibling, 0 replies; 6+ messages in thread
From: Ryan Eatmon @ 2023-08-28 20:45 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti



On 8/28/2023 3:39 PM, Denys Dmytriyenko wrote:
> On Mon, Aug 28, 2023 at 03:22:11PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
>> A recent change to oe-core [1], has caused a pile of QA errors during
>> packaging for this binary package.  The effect of the change in oe-core
>> was to remove the dependency on the compiler and other compiler adjacent
>> libraries.  But the binary packages need some of the compiler tools as
>> part of the packaging flow (ie. objdump).
>>
>> Until the above gets reverted, this patch will fix the issue and can be
>> reverted itself once oe-core is fixed.
>>
>> [1] https://git.openembedded.org/openembedded-core/commit/?h=master&id=d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727
> 
> Why not simply reset INHIBIT_DEFAULT_DEPS in the recipe?

Good question.  Let me try that.  It should work, but I want to be sure.



> 
>> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
>> ---
>>   .../powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb          | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
>> index f748bd0f..73de93e5 100644
>> --- a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
>> +++ b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
>> @@ -37,6 +37,8 @@ PACKAGECONFIG[opengl] = ",,,,${GLES_PACKAGES}"
>>   PACKAGECONFIG[vulkan] = ",,,,${VULKAN_PACKAGES}"
>>   PACKAGECONFIG[opencl] = ",,,,${OPENCL_PACKAGES}"
>>   
>> +DEPENDS:prepend = "${BASE_DEFAULT_DEPS} "
>> +
>>   def get_file_list(package_list_var, d):
>>       file_list = []
>>       package_list = d.getVar(package_list_var)
>> -- 
>> 2.17.1

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-ti][master][PATCH] ti-img-rogue-umlibs: Add DEPENDS on BASE_DEFAULT_DEPS
       [not found]   ` <177FA6F1CCEC185E.29216@lists.yoctoproject.org>
@ 2023-08-28 21:13     ` Ryan Eatmon
  2023-08-28 21:49       ` Denys Dmytriyenko
       [not found]     ` <177FA87BB4E479BB.5772@lists.yoctoproject.org>
  1 sibling, 1 reply; 6+ messages in thread
From: Ryan Eatmon @ 2023-08-28 21:13 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti



On 8/28/2023 3:45 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
> 
> 
> On 8/28/2023 3:39 PM, Denys Dmytriyenko wrote:
>> On Mon, Aug 28, 2023 at 03:22:11PM -0500, Ryan Eatmon via 
>> lists.yoctoproject.org wrote:
>>> A recent change to oe-core [1], has caused a pile of QA errors during
>>> packaging for this binary package.  The effect of the change in oe-core
>>> was to remove the dependency on the compiler and other compiler adjacent
>>> libraries.  But the binary packages need some of the compiler tools as
>>> part of the packaging flow (ie. objdump).
>>>
>>> Until the above gets reverted, this patch will fix the issue and can be
>>> reverted itself once oe-core is fixed.
>>>
>>> [1] 
>>> https://git.openembedded.org/openembedded-core/commit/?h=master&id=d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727
>>
>> Why not simply reset INHIBIT_DEFAULT_DEPS in the recipe?
> 
> Good question.  Let me try that.  It should work, but I want to be sure.

huh...  It didn't work...


inherit bin_package

INHIBIT_DEFAULT_DEPS = "0"


That gave the same build errors....


Here is code that is using the variable:

def get_base_dep(d):
     if d.getVar('INHIBIT_DEFAULT_DEPS', False):
         return ""
     return "${BASE_DEFAULT_DEPS}"




> 
> 
>>
>>> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
>>> ---
>>>   .../powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb          | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git 
>>> a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
>>> index f748bd0f..73de93e5 100644
>>> --- 
>>> a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
>>> +++ 
>>> b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
>>> @@ -37,6 +37,8 @@ PACKAGECONFIG[opengl] = ",,,,${GLES_PACKAGES}"
>>>   PACKAGECONFIG[vulkan] = ",,,,${VULKAN_PACKAGES}"
>>>   PACKAGECONFIG[opencl] = ",,,,${OPENCL_PACKAGES}"
>>> +DEPENDS:prepend = "${BASE_DEFAULT_DEPS} "
>>> +
>>>   def get_file_list(package_list_var, d):
>>>       file_list = []
>>>       package_list = d.getVar(package_list_var)
>>> -- 
>>> 2.17.1
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#16897): https://lists.yoctoproject.org/g/meta-ti/message/16897
> Mute This Topic: https://lists.yoctoproject.org/mt/101018238/6551054
> Group Owner: meta-ti+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/leave/10828724/6551054/1815494134/xyzzy [reatmon@ti.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-ti][master][PATCH] ti-img-rogue-umlibs: Add DEPENDS on BASE_DEFAULT_DEPS
       [not found]     ` <177FA87BB4E479BB.5772@lists.yoctoproject.org>
@ 2023-08-28 21:33       ` Ryan Eatmon
  0 siblings, 0 replies; 6+ messages in thread
From: Ryan Eatmon @ 2023-08-28 21:33 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti



On 8/28/2023 4:13 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
> 
> 
> On 8/28/2023 3:45 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
>>
>>
>> On 8/28/2023 3:39 PM, Denys Dmytriyenko wrote:
>>> On Mon, Aug 28, 2023 at 03:22:11PM -0500, Ryan Eatmon via 
>>> lists.yoctoproject.org wrote:
>>>> A recent change to oe-core [1], has caused a pile of QA errors during
>>>> packaging for this binary package.  The effect of the change in oe-core
>>>> was to remove the dependency on the compiler and other compiler 
>>>> adjacent
>>>> libraries.  But the binary packages need some of the compiler tools as
>>>> part of the packaging flow (ie. objdump).
>>>>
>>>> Until the above gets reverted, this patch will fix the issue and can be
>>>> reverted itself once oe-core is fixed.
>>>>
>>>> [1] 
>>>> https://git.openembedded.org/openembedded-core/commit/?h=master&id=d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727
>>>
>>> Why not simply reset INHIBIT_DEFAULT_DEPS in the recipe?
>>
>> Good question.  Let me try that.  It should work, but I want to be sure.
> 
> huh...  It didn't work...
> 
> 
> inherit bin_package
> 
> INHIBIT_DEFAULT_DEPS = "0"

If I set it to "" then it works.  Let me test that further and post a v2 
tomorrow.

> 
> That gave the same build errors....
> 
> 
> Here is code that is using the variable:
> 
> def get_base_dep(d):
>      if d.getVar('INHIBIT_DEFAULT_DEPS', False):
>          return ""
>      return "${BASE_DEFAULT_DEPS}"
> 
> 
> 
> 
>>
>>
>>>
>>>> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
>>>> ---
>>>>   .../powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb          | 
>>>> 2 ++
>>>>   1 file changed, 2 insertions(+)
>>>>
>>>> diff --git 
>>>> a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
>>>> index f748bd0f..73de93e5 100644
>>>> --- 
>>>> a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
>>>> +++ 
>>>> b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
>>>> @@ -37,6 +37,8 @@ PACKAGECONFIG[opengl] = ",,,,${GLES_PACKAGES}"
>>>>   PACKAGECONFIG[vulkan] = ",,,,${VULKAN_PACKAGES}"
>>>>   PACKAGECONFIG[opencl] = ",,,,${OPENCL_PACKAGES}"
>>>> +DEPENDS:prepend = "${BASE_DEFAULT_DEPS} "
>>>> +
>>>>   def get_file_list(package_list_var, d):
>>>>       file_list = []
>>>>       package_list = d.getVar(package_list_var)
>>>> -- 
>>>> 2.17.1
>>
>>
>>
>>
>>
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#16898): https://lists.yoctoproject.org/g/meta-ti/message/16898
> Mute This Topic: https://lists.yoctoproject.org/mt/101018238/6551054
> Group Owner: meta-ti+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/leave/10828724/6551054/1815494134/xyzzy [reatmon@ti.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-ti][master][PATCH] ti-img-rogue-umlibs: Add DEPENDS on BASE_DEFAULT_DEPS
  2023-08-28 21:13     ` Ryan Eatmon
@ 2023-08-28 21:49       ` Denys Dmytriyenko
  0 siblings, 0 replies; 6+ messages in thread
From: Denys Dmytriyenko @ 2023-08-28 21:49 UTC (permalink / raw)
  To: Ryan Eatmon; +Cc: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti

On Mon, Aug 28, 2023 at 04:13:48PM -0500, Ryan Eatmon wrote:
> 
> 
> On 8/28/2023 3:45 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
> >
> >
> >On 8/28/2023 3:39 PM, Denys Dmytriyenko wrote:
> >>On Mon, Aug 28, 2023 at 03:22:11PM -0500, Ryan Eatmon via
> >>lists.yoctoproject.org wrote:
> >>>A recent change to oe-core [1], has caused a pile of QA errors during
> >>>packaging for this binary package.  The effect of the change in oe-core
> >>>was to remove the dependency on the compiler and other compiler adjacent
> >>>libraries.  But the binary packages need some of the compiler tools as
> >>>part of the packaging flow (ie. objdump).
> >>>
> >>>Until the above gets reverted, this patch will fix the issue and can be
> >>>reverted itself once oe-core is fixed.
> >>>
> >>>[1] https://git.openembedded.org/openembedded-core/commit/?h=master&id=d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727
> >>
> >>Why not simply reset INHIBIT_DEFAULT_DEPS in the recipe?
> >
> >Good question.  Let me try that.  It should work, but I want to be sure.
> 
> huh...  It didn't work...
> 
> 
> inherit bin_package
> 
> INHIBIT_DEFAULT_DEPS = "0"
> 
> 
> That gave the same build errors....
> 
> 
> Here is code that is using the variable:
> 
> def get_base_dep(d):
>     if d.getVar('INHIBIT_DEFAULT_DEPS', False):
>         return ""
>     return "${BASE_DEFAULT_DEPS}"

Ah, right, it doesn't check for the value, just the fact that the variable is 
defined. Could try unset or d.delVar()... But, revert in OE-Core does make 
perfect sense. Today is a holiday in the UK, so Richard is out until tomorrow.


> >>>Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> >>>---
> >>>  .../powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb          | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>>diff --git a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
> >>>index f748bd0f..73de93e5 100644
> >>>--- a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
> >>>+++ b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.1.6404501.bb
> >>>@@ -37,6 +37,8 @@ PACKAGECONFIG[opengl] = ",,,,${GLES_PACKAGES}"
> >>>  PACKAGECONFIG[vulkan] = ",,,,${VULKAN_PACKAGES}"
> >>>  PACKAGECONFIG[opencl] = ",,,,${OPENCL_PACKAGES}"
> >>>+DEPENDS:prepend = "${BASE_DEFAULT_DEPS} "
> >>>+
> >>>  def get_file_list(package_list_var, d):
> >>>      file_list = []
> >>>      package_list = d.getVar(package_list_var)
> >>>-- 
> >>>2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-08-28 21:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-28 20:22 [meta-ti][master][PATCH] ti-img-rogue-umlibs: Add DEPENDS on BASE_DEFAULT_DEPS Ryan Eatmon
2023-08-28 20:39 ` Denys Dmytriyenko
2023-08-28 20:45   ` Ryan Eatmon
     [not found]   ` <177FA6F1CCEC185E.29216@lists.yoctoproject.org>
2023-08-28 21:13     ` Ryan Eatmon
2023-08-28 21:49       ` Denys Dmytriyenko
     [not found]     ` <177FA87BB4E479BB.5772@lists.yoctoproject.org>
2023-08-28 21:33       ` Ryan Eatmon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.