* [jcmvbkbc-xtensa:xtensa-6.5-esp32 33/34] kernel/events/core.c:6583:15: warning: no previous prototype for 'perf_get_unmapped_area'
@ 2023-08-28 14:54 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-08-28 14:54 UTC (permalink / raw)
To: Max Filippov; +Cc: oe-kbuild-all
tree: https://github.com/jcmvbkbc/linux-xtensa xtensa-6.5-esp32
head: 13c28b8472d4f847e299f266a9f7ef9615205e93
commit: d3664362e60ef00123d4b7af9a34633a034e2e99 [33/34] WIP: perf: support mmapping event on noMMU
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230828/202308282256.sW65iIQJ-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230828/202308282256.sW65iIQJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308282256.sW65iIQJ-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/events/core.c:6583:15: warning: no previous prototype for 'perf_get_unmapped_area' [-Wmissing-prototypes]
6583 | unsigned long perf_get_unmapped_area(struct file *file,
| ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/events/core.c:6639:17: warning: 'perf_mmap_capabilities' defined but not used [-Wunused-function]
6639 | static unsigned perf_mmap_capabilities(struct file *file)
| ^~~~~~~~~~~~~~~~~~~~~~
vim +/perf_get_unmapped_area +6583 kernel/events/core.c
6582
> 6583 unsigned long perf_get_unmapped_area(struct file *file,
6584 unsigned long addr, unsigned long len,
6585 unsigned long pgoff, unsigned long flags)
6586 {
6587 unsigned long ret = -EINVAL;
6588 struct perf_event *event = file->private_data;
6589 unsigned long nr_pages = len / PAGE_SIZE;
6590
6591 pr_debug("%s: addr = 0x%lx, len = 0x%lx, pgoff = 0x%lx, flags = 0x%lx, event = %p, event->rb = %p\n",
6592 __func__, addr, len, pgoff, flags, event, event->rb);
6593
6594 if (!event->rb) {
6595 int flags = RING_BUFFER_WRITABLE;
6596 struct perf_buffer *rb = NULL;
6597
6598 if (pgoff != 0) {
6599 ret = -EINVAL;
6600 goto unlock;
6601 }
6602 --nr_pages;
6603 rb = rb_alloc(nr_pages,
6604 event->attr.watermark ? event->attr.wakeup_watermark : 0,
6605 event->cpu, flags);
6606
6607 if (!rb) {
6608 ret = -ENOMEM;
6609 goto unlock;
6610 }
6611 atomic_set(&rb->mmap_count, 1);
6612 rb->mmap_user = get_current_user();
6613 rb->mmap_locked = 0;
6614
6615 ring_buffer_attach(event, rb);
6616
6617 perf_event_update_time(event);
6618 perf_event_init_userpage(event);
6619 perf_event_update_userpage(event);
6620 }
6621 if (event->rb) {
6622 struct perf_buffer *rb = event->rb;
6623
6624 if (!pgoff) {
6625 ret = (unsigned long)rb->user_page;
6626 } else {
6627 ret = rb_alloc_aux(rb, event, pgoff, nr_pages,
6628 event->attr.aux_watermark, flags);
6629 if (ret < 0)
6630 goto unlock;
6631 ret = (unsigned long)rb->data_pages[pgoff - 1];
6632 }
6633 }
6634 unlock:
6635 pr_debug("%s: ret = 0x%lx\n", __func__, ret);
6636 return ret;
6637 }
6638
> 6639 static unsigned perf_mmap_capabilities(struct file *file)
6640 {
6641 return NOMMU_MAP_DIRECT | NOMMU_MAP_READ | NOMMU_MAP_WRITE;
6642 }
6643
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* [jcmvbkbc-xtensa:xtensa-6.5-esp32 33/34] kernel/events/core.c:6583:15: warning: no previous prototype for 'perf_get_unmapped_area'
@ 2023-08-29 1:10 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-08-29 1:10 UTC (permalink / raw)
To: Max Filippov; +Cc: oe-kbuild-all
tree: https://github.com/jcmvbkbc/linux-xtensa xtensa-6.5-esp32
head: edbe560c2ce9974f4b2e47ca13050e6a62d604b3
commit: aced503663eb363cb3da0475b133143e486e239f [33/34] WIP: perf: support mmapping event on noMMU
config: s390-randconfig-r012-20230829 (https://download.01.org/0day-ci/archive/20230829/202308290938.pwz1ilrP-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230829/202308290938.pwz1ilrP-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308290938.pwz1ilrP-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/events/core.c:6583:15: warning: no previous prototype for 'perf_get_unmapped_area' [-Wmissing-prototypes]
6583 | unsigned long perf_get_unmapped_area(struct file *file,
| ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/events/core.c:6639:17: warning: 'perf_mmap_capabilities' defined but not used [-Wunused-function]
6639 | static unsigned perf_mmap_capabilities(struct file *file)
| ^~~~~~~~~~~~~~~~~~~~~~
vim +/perf_get_unmapped_area +6583 kernel/events/core.c
6582
> 6583 unsigned long perf_get_unmapped_area(struct file *file,
6584 unsigned long addr, unsigned long len,
6585 unsigned long pgoff, unsigned long flags)
6586 {
6587 unsigned long ret = -EINVAL;
6588 struct perf_event *event = file->private_data;
6589 unsigned long nr_pages = len / PAGE_SIZE;
6590
6591 pr_debug("%s: addr = 0x%lx, len = 0x%lx, pgoff = 0x%lx, flags = 0x%lx, event = %p, event->rb = %p\n",
6592 __func__, addr, len, pgoff, flags, event, event->rb);
6593
6594 if (!event->rb) {
6595 int flags = RING_BUFFER_WRITABLE;
6596 struct perf_buffer *rb = NULL;
6597
6598 if (pgoff != 0) {
6599 ret = -EINVAL;
6600 goto unlock;
6601 }
6602 --nr_pages;
6603 rb = rb_alloc(nr_pages,
6604 event->attr.watermark ? event->attr.wakeup_watermark : 0,
6605 event->cpu, flags);
6606
6607 if (!rb) {
6608 ret = -ENOMEM;
6609 goto unlock;
6610 }
6611 atomic_set(&rb->mmap_count, 1);
6612 rb->mmap_user = get_current_user();
6613 rb->mmap_locked = 0;
6614
6615 ring_buffer_attach(event, rb);
6616
6617 perf_event_update_time(event);
6618 perf_event_init_userpage(event);
6619 perf_event_update_userpage(event);
6620 }
6621 if (event->rb) {
6622 struct perf_buffer *rb = event->rb;
6623
6624 if (!pgoff) {
6625 ret = (unsigned long)rb->user_page;
6626 } else {
6627 ret = rb_alloc_aux(rb, event, pgoff, nr_pages,
6628 event->attr.aux_watermark, flags);
6629 if (ret < 0)
6630 goto unlock;
6631 ret = (unsigned long)rb->data_pages[pgoff - 1];
6632 }
6633 }
6634 unlock:
6635 pr_debug("%s: ret = 0x%lx\n", __func__, ret);
6636 return ret;
6637 }
6638
> 6639 static unsigned perf_mmap_capabilities(struct file *file)
6640 {
6641 return NOMMU_MAP_DIRECT | NOMMU_MAP_READ | NOMMU_MAP_WRITE;
6642 }
6643
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-29 1:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-28 14:54 [jcmvbkbc-xtensa:xtensa-6.5-esp32 33/34] kernel/events/core.c:6583:15: warning: no previous prototype for 'perf_get_unmapped_area' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-08-29 1:10 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.