From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: ogabbay@kernel.org, ttayar@habana.ai, dri-devel@lists.freedesktop.org
Subject: [PATCH 1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2
Date: Tue, 29 Aug 2023 13:01:11 +0200 [thread overview]
Message-ID: <20230829110115.3442-2-christian.koenig@amd.com> (raw)
In-Reply-To: <20230829110115.3442-1-christian.koenig@amd.com>
We want to remove per minor debugfs directories. Start by stopping
drivers from adding anything inside of those in the mid layer callback.
v2: drop it for the accel node as well
Signed-off-by: Christian König <christian.koenig@amd.com>
Tested-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
---
drivers/accel/drm_accel.c | 3 ---
drivers/gpu/drm/drm_debugfs.c | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/accel/drm_accel.c b/drivers/accel/drm_accel.c
index 4a9baf02439e..01edf2c00b5a 100644
--- a/drivers/accel/drm_accel.c
+++ b/drivers/accel/drm_accel.c
@@ -99,9 +99,6 @@ void accel_debugfs_init(struct drm_minor *minor, int minor_id)
drm_debugfs_create_files(accel_debugfs_list, ACCEL_DEBUGFS_ENTRIES,
minor->debugfs_root, minor);
-
- if (dev->driver->debugfs_init)
- dev->driver->debugfs_init(minor);
}
/**
diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
index 2de43ff3ce0a..d90d0827bfad 100644
--- a/drivers/gpu/drm/drm_debugfs.c
+++ b/drivers/gpu/drm/drm_debugfs.c
@@ -284,7 +284,7 @@ int drm_debugfs_init(struct drm_minor *minor, int minor_id,
drm_client_debugfs_init(minor);
}
- if (dev->driver->debugfs_init)
+ if (dev->driver->debugfs_init && dev->render != minor)
dev->driver->debugfs_init(minor);
list_for_each_entry_safe(entry, tmp, &dev->debugfs_list, list) {
--
2.34.1
next prev parent reply other threads:[~2023-08-29 11:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 11:01 DRM debugfs cleanup take 6 Christian König
2023-08-29 11:01 ` Christian König [this message]
2023-08-30 8:19 ` [PATCH 1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2 Andi Shyti
2023-08-30 14:22 ` Christian König
2023-09-01 8:00 ` Tomer Tayar
2023-08-29 11:01 ` [PATCH 2/5] drm/debugfs: disallow debugfs access when device isn't registered Christian König
2023-08-29 11:31 ` Andi Shyti
2023-08-29 11:35 ` Christian König
2023-08-29 11:38 ` Andi Shyti
2023-08-29 12:31 ` Christian König
2023-08-30 7:57 ` Christian König
2023-08-30 8:48 ` Andi Shyti
2023-08-29 11:01 ` [PATCH 3/5] drm/debugfs: rework debugfs directory creation v5 Christian König
2023-08-31 21:49 ` Andi Shyti
2023-08-29 11:01 ` [PATCH 4/5] drm/debugfs: remove dev->debugfs_list and debugfs_mutex v2 Christian König
2023-08-31 21:56 ` Andi Shyti
2023-08-29 11:01 ` [PATCH 5/5] drm/debugfs: rework drm_debugfs_create_files implementation v2 Christian König
2023-08-31 22:06 ` Andi Shyti
-- strict thread matches above, loose matches on Subject: below --
2023-07-11 14:04 DRM debugfs cleanup take 5 (resend) Christian König
2023-07-11 14:04 ` [PATCH 1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2 Christian König
2023-04-24 12:30 Christian König
2023-05-16 10:59 ` Stanislaw Gruszka
2023-04-12 14:52 DRM debugfs cleanup take 4 Christian König
2023-04-12 14:52 ` [PATCH 1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2 Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230829110115.3442-2-christian.koenig@amd.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ogabbay@kernel.org \
--cc=ttayar@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.