From: Andi Shyti <andi.shyti@linux.intel.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>
Cc: ogabbay@kernel.org, ttayar@habana.ai, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/debugfs: remove dev->debugfs_list and debugfs_mutex v2
Date: Thu, 31 Aug 2023 23:56:06 +0200 [thread overview]
Message-ID: <ZPEMdoMvIjX/54Dd@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230829110115.3442-5-christian.koenig@amd.com>
Hi Christian,
On Tue, Aug 29, 2023 at 01:01:14PM +0200, Christian König wrote:
> The mutex was completely pointless in the first place since any
> parallel adding of files to this list would result in random
> behavior since the list is filled and consumed multiple times.
>
> Completely drop that approach and just create the files directly but
> return -ENODEV while opening the file when the minors are not
> registered yet.
>
> v2: rebase on debugfs directory rework, limit access before minors are
> registered.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
next prev parent reply other threads:[~2023-08-31 21:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 11:01 DRM debugfs cleanup take 6 Christian König
2023-08-29 11:01 ` [PATCH 1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2 Christian König
2023-08-30 8:19 ` Andi Shyti
2023-08-30 14:22 ` Christian König
2023-09-01 8:00 ` Tomer Tayar
2023-08-29 11:01 ` [PATCH 2/5] drm/debugfs: disallow debugfs access when device isn't registered Christian König
2023-08-29 11:31 ` Andi Shyti
2023-08-29 11:35 ` Christian König
2023-08-29 11:38 ` Andi Shyti
2023-08-29 12:31 ` Christian König
2023-08-30 7:57 ` Christian König
2023-08-30 8:48 ` Andi Shyti
2023-08-29 11:01 ` [PATCH 3/5] drm/debugfs: rework debugfs directory creation v5 Christian König
2023-08-31 21:49 ` Andi Shyti
2023-08-29 11:01 ` [PATCH 4/5] drm/debugfs: remove dev->debugfs_list and debugfs_mutex v2 Christian König
2023-08-31 21:56 ` Andi Shyti [this message]
2023-08-29 11:01 ` [PATCH 5/5] drm/debugfs: rework drm_debugfs_create_files implementation v2 Christian König
2023-08-31 22:06 ` Andi Shyti
-- strict thread matches above, loose matches on Subject: below --
2023-07-11 14:04 DRM debugfs cleanup take 5 (resend) Christian König
2023-07-11 14:04 ` [PATCH 4/5] drm/debugfs: remove dev->debugfs_list and debugfs_mutex v2 Christian König
2023-04-24 12:30 [PATCH 1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2 Christian König
2023-04-24 12:30 ` [PATCH 4/5] drm/debugfs: remove dev->debugfs_list and debugfs_mutex v2 Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPEMdoMvIjX/54Dd@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ogabbay@kernel.org \
--cc=ttayar@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.