Re: [PATCH v2 2/9] accel/ivpu: Remove duplicated error messages

[Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>]

On Mon, Aug 28, 2023 at 02:41:50PM -0600, Jeffrey Hugo wrote:
> >   	ivpu_pm_enable(vdev);
> > @@ -651,10 +625,8 @@ static int ivpu_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> >   	pci_set_drvdata(pdev, vdev);
> >   	ret = ivpu_dev_init(vdev);
> > -	if (ret) {
> > -		dev_err(&pdev->dev, "Failed to initialize VPU device: %d\n", ret);
> > +	if (ret)
> >   		return ret;
> > -	}
> 
> Commit text doesn't mention anything about this change.

Will add to commit message info about this.


> >   	ret = drm_dev_register(&vdev->drm, 0);
> >   	if (ret) {
> > diff --git a/drivers/accel/ivpu/ivpu_fw.c b/drivers/accel/ivpu/ivpu_fw.c
> > index 9827ea4d7b83..9b6ecd3e9537 100644
> > --- a/drivers/accel/ivpu/ivpu_fw.c
> > +++ b/drivers/accel/ivpu/ivpu_fw.c
> > @@ -78,7 +78,7 @@ static int ivpu_fw_request(struct ivpu_device *vdev)
> >   		}
> >   	}
> > -	ivpu_err(vdev, "Failed to request firmware: %d\n", ret);
> > +	ivpu_err(vdev, "Failed to load firmware: %d\n", ret);
> 
> Commit text doesn't mention anything about this.  Nor do I understand it as
> this function doesn't load the firmware.

I'll remove this change.

> Everything below this point seems to be not related to $SUBJECT and feels
> like should be a separate patch.

I'll add to commit massage that we also add missed prints 
in functions called from ivpu_dev_init().

And for remaining changes I'll prepare separate patches,
one for ivpu_mmu_context.c context and one for ivpu_pm_init().

Thanks
Stanislaw