From: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: Oded Gabbay <ogabbay@kernel.org>,
Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 5/9] accel/ivpu: Move ivpu_fw_load() to ivpu_fw_init()
Date: Tue, 29 Aug 2023 13:12:04 +0200 [thread overview]
Message-ID: <20230829111204.GB4086697@linux.intel.com> (raw)
In-Reply-To: <c1dcb25e-5a8a-9d25-deb5-81a81af16726@quicinc.com>
Hi
On Mon, Aug 28, 2023 at 02:49:34PM -0600, Jeffrey Hugo wrote:
> On 8/28/2023 3:47 AM, Stanislaw Gruszka wrote:
> > diff --git a/drivers/accel/ivpu/ivpu_fw.h b/drivers/accel/ivpu/ivpu_fw.h
> > index 8567fdf925fe..10ae2847f0ef 100644
> > --- a/drivers/accel/ivpu/ivpu_fw.h
> > +++ b/drivers/accel/ivpu/ivpu_fw.h
> > @@ -31,7 +31,7 @@ struct ivpu_fw_info {
> > int ivpu_fw_init(struct ivpu_device *vdev);
> > void ivpu_fw_fini(struct ivpu_device *vdev);
> > -int ivpu_fw_load(struct ivpu_device *vdev);
> > +void ivpu_fw_load(struct ivpu_device *vdev);
>
> If ivpu_fw_load() is defined in ivpu_fw.c and only used in ivpu_fw.c, do you
> need it in this header file anymore? Seems like you could remove this, and
> also make the function static.
The function is also used in ivpu_pm_prepare_cold_boot() from ivpu_pm.c
Regards
Stanislaw
next prev parent reply other threads:[~2023-08-29 11:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 9:47 [PATCH v2 0/9] accel/ivpu: Update for -next 2023.08.25 Stanislaw Gruszka
2023-08-28 9:47 ` [PATCH v2 1/9] accel/ivpu: Move set autosuspend delay to HW specific code Stanislaw Gruszka
2023-08-28 20:37 ` Jeffrey Hugo
2023-08-28 9:47 ` [PATCH v2 2/9] accel/ivpu: Remove duplicated error messages Stanislaw Gruszka
2023-08-28 20:41 ` Jeffrey Hugo
2023-08-29 11:09 ` Stanislaw Gruszka
2023-08-28 9:47 ` [PATCH v2 3/9] accel/ivpu: Print information about used workarounds Stanislaw Gruszka
2023-08-28 20:44 ` Jeffrey Hugo
2023-08-28 9:47 ` [PATCH v2 4/9] accel/ivpu: Initialize context with SSID = 1 Stanislaw Gruszka
2023-08-28 20:47 ` Jeffrey Hugo
2023-08-28 9:47 ` [PATCH v2 5/9] accel/ivpu: Move ivpu_fw_load() to ivpu_fw_init() Stanislaw Gruszka
2023-08-28 20:49 ` Jeffrey Hugo
2023-08-29 11:12 ` Stanislaw Gruszka [this message]
2023-08-29 15:10 ` Jeffrey Hugo
2023-08-28 9:47 ` [PATCH v2 6/9] accel/ivpu: Add ivpu_bo_vaddr() and ivpu_bo_size() Stanislaw Gruszka
2023-08-28 20:50 ` Jeffrey Hugo
2023-08-28 9:47 ` [PATCH v2 7/9] accel/ivpu/37xx: Change register rename leftovers Stanislaw Gruszka
2023-08-28 20:51 ` Jeffrey Hugo
2023-08-28 9:47 ` [PATCH v2 8/9] accel/ivpu/37xx: White space cleanup Stanislaw Gruszka
2023-08-28 20:55 ` Jeffrey Hugo
2023-08-29 11:14 ` Stanislaw Gruszka
2023-08-28 9:47 ` [PATCH v2 9/9] accel/ivpu: Move MMU register definitions to ivpu_mmu.c Stanislaw Gruszka
2023-08-28 21:01 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230829111204.GB4086697@linux.intel.com \
--to=stanislaw.gruszka@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.