All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Yann Sionneau <yann@sionneau.net>
Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] i2c: at91: Use dev_err_probe() instead of dev_err()
Date: Tue, 29 Aug 2023 14:57:20 +0200	[thread overview]
Message-ID: <20230829125720.jqk52g3lsbfvodk4@intel.intel> (raw)
In-Reply-To: <20230825143234.38336-1-yann@sionneau.net>

Hi Yann,

On Fri, Aug 25, 2023 at 04:32:34PM +0200, Yann Sionneau wrote:
> Change
> if (IS_ERR(x)) { dev_err(...); return PTR_ERR(x); }
> into
> return dev_err_probe()
> 
> Also, return the correct error instead of hardcoding -ENODEV
> This change has also the advantage of handling the -EPROBE_DEFER situation.
> 
> Signed-off-by: Yann Sionneau <yann@sionneau.net>

Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

Thanks,
Andi

WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@kernel.org>
To: Yann Sionneau <yann@sionneau.net>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-kernel@vger.kernel.org,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	linux-i2c@vger.kernel.org,
	Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND] i2c: at91: Use dev_err_probe() instead of dev_err()
Date: Tue, 29 Aug 2023 14:57:20 +0200	[thread overview]
Message-ID: <20230829125720.jqk52g3lsbfvodk4@intel.intel> (raw)
In-Reply-To: <20230825143234.38336-1-yann@sionneau.net>

Hi Yann,

On Fri, Aug 25, 2023 at 04:32:34PM +0200, Yann Sionneau wrote:
> Change
> if (IS_ERR(x)) { dev_err(...); return PTR_ERR(x); }
> into
> return dev_err_probe()
> 
> Also, return the correct error instead of hardcoding -ENODEV
> This change has also the advantage of handling the -EPROBE_DEFER situation.
> 
> Signed-off-by: Yann Sionneau <yann@sionneau.net>

Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

Thanks,
Andi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-08-29 12:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25 14:32 [PATCH RESEND] i2c: at91: Use dev_err_probe() instead of dev_err() Yann Sionneau
2023-08-25 14:32 ` Yann Sionneau
2023-08-28  8:03 ` Nicolas Ferre
2023-08-28  8:03   ` Nicolas Ferre
2023-08-28 10:29   ` Yann Sionneau
2023-08-28 10:29     ` Yann Sionneau
2023-08-29 12:57 ` Andi Shyti [this message]
2023-08-29 12:57   ` Andi Shyti
2023-08-29 13:00   ` Andi Shyti
2023-08-29 13:00     ` Andi Shyti
2023-08-30 19:20 ` Wolfram Sang
2023-08-30 19:20   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230829125720.jqk52g3lsbfvodk4@intel.intel \
    --to=andi.shyti@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=codrin.ciubotariu@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=yann@sionneau.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.