From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Minying Lin <mimi05633@gmail.com>
Cc: "avifishman70@gmail.com" <avifishman70@gmail.com>,
"tmaimon77@gmail.com" <tmaimon77@gmail.com>,
"tali.perry1@gmail.com" <tali.perry1@gmail.com>,
"venture@google.com" <venture@google.com>,
"yuenn@google.com" <yuenn@google.com>,
"benjaminfair@google.com" <benjaminfair@google.com>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"KWLIU@nuvoton.com" <KWLIU@nuvoton.com>,
"JJLIU0@nuvoton.com" <JJLIU0@nuvoton.com>,
"KFLIN@nuvoton.com" <KFLIN@nuvoton.com>,
"mylin1@nuvoton.com" <mylin1@nuvoton.com>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/1] rtc: nuvoton: Compatible with NCT3015Y-R and NCT3018Y-R
Date: Tue, 29 Aug 2023 16:22:10 +0200 [thread overview]
Message-ID: <2023082914221048e46085@mail.local> (raw)
In-Reply-To: <CAL3ZnpxEuOQtpaqA7KLBr285JvTDJrcT+ZGYyjy7Bi-sVs5yVA@mail.gmail.com>
On 29/08/2023 21:35:36+0800, Minying Lin wrote:
> > Do you really have to check the part number every time you set the time?
> > I don't expect it to change once read in probe.
> >
> [Mia] Due to the 3018Y's topology, we need to set the TWO bit first to
> obtain the write time capability, but the 3015Y does not have this problem.
> Therefore, we use part number & TWO bit to determine whether we need to set
> the TWO bit first before set time.
>
Sure but why don't you store the info somewhere instead of reading it
from the RTC every time?
> >
> > > + if (part_num < 0) {
> > > + dev_dbg(&client->dev, "%s: Failed to read part info
> > reg.\n", __func__);
> > > + return part_num;
> > > + }
> > > +
> >
> > --
> > Alexandre Belloni, co-owner and COO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
> >
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Minying Lin <mimi05633@gmail.com>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"mylin1@nuvoton.com" <mylin1@nuvoton.com>,
"benjaminfair@google.com" <benjaminfair@google.com>,
"KWLIU@nuvoton.com" <KWLIU@nuvoton.com>,
"avifishman70@gmail.com" <avifishman70@gmail.com>,
"venture@google.com" <venture@google.com>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"JJLIU0@nuvoton.com" <JJLIU0@nuvoton.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tali.perry1@gmail.com" <tali.perry1@gmail.com>,
"KFLIN@nuvoton.com" <KFLIN@nuvoton.com>,
"tmaimon77@gmail.com" <tmaimon77@gmail.com>
Subject: Re: [PATCH v4 1/1] rtc: nuvoton: Compatible with NCT3015Y-R and NCT3018Y-R
Date: Tue, 29 Aug 2023 16:22:10 +0200 [thread overview]
Message-ID: <2023082914221048e46085@mail.local> (raw)
In-Reply-To: <CAL3ZnpxEuOQtpaqA7KLBr285JvTDJrcT+ZGYyjy7Bi-sVs5yVA@mail.gmail.com>
On 29/08/2023 21:35:36+0800, Minying Lin wrote:
> > Do you really have to check the part number every time you set the time?
> > I don't expect it to change once read in probe.
> >
> [Mia] Due to the 3018Y's topology, we need to set the TWO bit first to
> obtain the write time capability, but the 3015Y does not have this problem.
> Therefore, we use part number & TWO bit to determine whether we need to set
> the TWO bit first before set time.
>
Sure but why don't you store the info somewhere instead of reading it
from the RTC every time?
> >
> > > + if (part_num < 0) {
> > > + dev_dbg(&client->dev, "%s: Failed to read part info
> > reg.\n", __func__);
> > > + return part_num;
> > > + }
> > > +
> >
> > --
> > Alexandre Belloni, co-owner and COO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
> >
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-08-29 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 1:25 [PATCH v4 0/1] Compatible with NCT3015Y-R and NCT3018Y-R Mia Lin
2023-08-16 1:25 ` Mia Lin
2023-08-16 1:25 ` [PATCH v4 1/1] rtc: nuvoton: " Mia Lin
2023-08-16 1:25 ` Mia Lin
2023-08-23 22:12 ` Alexandre Belloni
2023-08-23 22:12 ` Alexandre Belloni
2023-08-29 13:35 ` Minying Lin
2023-08-29 14:22 ` Alexandre Belloni [this message]
2023-08-29 14:22 ` Alexandre Belloni
2023-08-31 0:57 ` Mining Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023082914221048e46085@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=JJLIU0@nuvoton.com \
--cc=KFLIN@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=a.zummo@towertech.it \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mimi05633@gmail.com \
--cc=mylin1@nuvoton.com \
--cc=openbmc@lists.ozlabs.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.