All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Adrián Larumbe" <adrian.larumbe@collabora.com>
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch,
	robdclark@gmail.com, quic_abhinavk@quicinc.com,
	dmitry.baryshkov@linaro.org, sean@poorly.run,
	marijn.suijten@somainline.org, robh@kernel.org,
	steven.price@arm.com, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	healych@amazon.com, kernel@collabora.com,
	freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2 1/6] drm/panfrost: Add cycle count GPU register definitions
Date: Wed, 30 Aug 2023 12:35:14 +0200	[thread overview]
Message-ID: <20230830123514.28c0180f@collabora.com> (raw)
In-Reply-To: <20230824013604.466224-2-adrian.larumbe@collabora.com>

On Thu, 24 Aug 2023 02:34:44 +0100
Adrián Larumbe <adrian.larumbe@collabora.com> wrote:

> These GPU registers will be used when programming the cycle counter, which
> we need for providing accurate fdinfo drm-cycles values to user space.
> 
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  drivers/gpu/drm/panfrost/panfrost_regs.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_regs.h b/drivers/gpu/drm/panfrost/panfrost_regs.h
> index 919f44ac853d..55ec807550b3 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_regs.h
> +++ b/drivers/gpu/drm/panfrost/panfrost_regs.h
> @@ -46,6 +46,8 @@
>  #define   GPU_CMD_SOFT_RESET		0x01
>  #define   GPU_CMD_PERFCNT_CLEAR		0x03
>  #define   GPU_CMD_PERFCNT_SAMPLE	0x04
> +#define   GPU_CMD_CYCLE_COUNT_START	0x05
> +#define   GPU_CMD_CYCLE_COUNT_STOP	0x06
>  #define   GPU_CMD_CLEAN_CACHES		0x07
>  #define   GPU_CMD_CLEAN_INV_CACHES	0x08
>  #define GPU_STATUS			0x34
> @@ -73,6 +75,9 @@
>  #define GPU_PRFCNT_TILER_EN		0x74
>  #define GPU_PRFCNT_MMU_L2_EN		0x7c
>  
> +#define GPU_CYCLE_COUNT_LO		0x90
> +#define GPU_CYCLE_COUNT_HI		0x94
> +
>  #define GPU_THREAD_MAX_THREADS		0x0A0	/* (RO) Maximum number of threads per core */
>  #define GPU_THREAD_MAX_WORKGROUP_SIZE	0x0A4	/* (RO) Maximum workgroup size */
>  #define GPU_THREAD_MAX_BARRIER_SIZE	0x0A8	/* (RO) Maximum threads waiting at a barrier */


WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Adrián Larumbe" <adrian.larumbe@collabora.com>
Cc: tzimmermann@suse.de, sean@poorly.run, quic_abhinavk@quicinc.com,
	mripard@kernel.org, steven.price@arm.com,
	freedreno@lists.freedesktop.org, healych@amazon.com,
	dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	dmitry.baryshkov@linaro.org, marijn.suijten@somainline.org,
	kernel@collabora.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] drm/panfrost: Add cycle count GPU register definitions
Date: Wed, 30 Aug 2023 12:35:14 +0200	[thread overview]
Message-ID: <20230830123514.28c0180f@collabora.com> (raw)
In-Reply-To: <20230824013604.466224-2-adrian.larumbe@collabora.com>

On Thu, 24 Aug 2023 02:34:44 +0100
Adrián Larumbe <adrian.larumbe@collabora.com> wrote:

> These GPU registers will be used when programming the cycle counter, which
> we need for providing accurate fdinfo drm-cycles values to user space.
> 
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  drivers/gpu/drm/panfrost/panfrost_regs.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_regs.h b/drivers/gpu/drm/panfrost/panfrost_regs.h
> index 919f44ac853d..55ec807550b3 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_regs.h
> +++ b/drivers/gpu/drm/panfrost/panfrost_regs.h
> @@ -46,6 +46,8 @@
>  #define   GPU_CMD_SOFT_RESET		0x01
>  #define   GPU_CMD_PERFCNT_CLEAR		0x03
>  #define   GPU_CMD_PERFCNT_SAMPLE	0x04
> +#define   GPU_CMD_CYCLE_COUNT_START	0x05
> +#define   GPU_CMD_CYCLE_COUNT_STOP	0x06
>  #define   GPU_CMD_CLEAN_CACHES		0x07
>  #define   GPU_CMD_CLEAN_INV_CACHES	0x08
>  #define GPU_STATUS			0x34
> @@ -73,6 +75,9 @@
>  #define GPU_PRFCNT_TILER_EN		0x74
>  #define GPU_PRFCNT_MMU_L2_EN		0x7c
>  
> +#define GPU_CYCLE_COUNT_LO		0x90
> +#define GPU_CYCLE_COUNT_HI		0x94
> +
>  #define GPU_THREAD_MAX_THREADS		0x0A0	/* (RO) Maximum number of threads per core */
>  #define GPU_THREAD_MAX_WORKGROUP_SIZE	0x0A4	/* (RO) Maximum workgroup size */
>  #define GPU_THREAD_MAX_BARRIER_SIZE	0x0A8	/* (RO) Maximum threads waiting at a barrier */


  reply	other threads:[~2023-08-30 18:32 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24  1:34 [PATCH v2 0/6] Add fdinfo support to Panfrost Adrián Larumbe
2023-08-24  1:34 ` Adrián Larumbe
2023-08-24  1:34 ` [PATCH v2 1/6] drm/panfrost: Add cycle count GPU register definitions Adrián Larumbe
2023-08-24  1:34   ` Adrián Larumbe
2023-08-30 10:35   ` Boris Brezillon [this message]
2023-08-30 10:35     ` Boris Brezillon
2023-08-31 15:54   ` Steven Price
2023-08-31 15:54     ` Steven Price
2023-08-24  1:34 ` [PATCH v2 2/6] drm/panfrost: Add fdinfo support GPU load metrics Adrián Larumbe
2023-08-24  1:34   ` Adrián Larumbe
2023-08-24  4:12   ` kernel test robot
2023-08-24  4:12     ` kernel test robot
2023-08-30 10:17   ` Boris Brezillon
2023-08-30 10:17     ` Boris Brezillon
2023-08-31 23:23     ` Adrián Larumbe
2023-08-31 23:23       ` Adrián Larumbe
2023-08-31 15:54   ` Steven Price
2023-08-31 15:54     ` Steven Price
2023-08-31 21:34     ` Adrián Larumbe
2023-08-31 21:34       ` Adrián Larumbe
2023-09-04  8:22       ` Steven Price
2023-09-04  8:22         ` Steven Price
2023-09-02  3:20   ` kernel test robot
2023-09-02  3:20     ` kernel test robot
2023-08-24  1:34 ` [PATCH v2 3/6] drm/panfrost: Add fdinfo support for memory stats Adrián Larumbe
2023-08-24  1:34   ` Adrián Larumbe
2023-08-30 10:31   ` Boris Brezillon
2023-08-30 10:31     ` Boris Brezillon
2023-08-31 23:07     ` Adrián Larumbe
2023-08-31 23:07       ` Adrián Larumbe
2023-08-24  1:34 ` [PATCH v2 4/6] drm/drm_file: Add DRM obj's RSS reporting function for fdinfo Adrián Larumbe
2023-08-24  1:34   ` Adrián Larumbe
2023-08-30 10:34   ` Boris Brezillon
2023-08-30 10:34     ` Boris Brezillon
2023-08-24  1:34 ` [PATCH v2 5/6] drm/panfrost: Implement generic DRM object RSS reporting function Adrián Larumbe
2023-08-24  1:34   ` Adrián Larumbe
2023-08-24 11:13   ` kernel test robot
2023-08-24 11:13     ` kernel test robot
2023-08-30 10:52   ` Boris Brezillon
2023-08-30 10:52     ` Boris Brezillon
2023-09-01  0:03     ` Adrián Larumbe
2023-09-01  0:03       ` Adrián Larumbe
2023-09-01  6:44       ` Boris Brezillon
2023-09-01  6:44         ` Boris Brezillon
2023-08-24  1:34 ` [PATCH v2 6/6] drm/drm-file: Allow size unit selection in drm_show_memory_stats Adrián Larumbe
2023-08-24  1:34   ` Adrián Larumbe
2023-08-24  6:49   ` kernel test robot
2023-08-24  6:49     ` kernel test robot
2023-08-28 15:00   ` Rob Clark
2023-08-28 15:00     ` Rob Clark
2023-08-30 15:51     ` Adrián Larumbe
2023-08-30 15:51       ` Adrián Larumbe
2023-09-05 22:23       ` Rob Clark
2023-09-05 22:23         ` Rob Clark
2023-09-01 22:18   ` kernel test robot
2023-09-01 22:18     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230830123514.28c0180f@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=adrian.larumbe@collabora.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=healych@amazon.com \
    --cc=kernel@collabora.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh@kernel.org \
    --cc=sean@poorly.run \
    --cc=steven.price@arm.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.