[sj:damon/next 33/46] mm/damon/core.c:1612: warning: Function parameter or member 'r' not described in 'damon_update_region_access_rate'

[sj:damon/next 33/46] mm/damon/core.c:1612: warning: Function parameter or member 'r' not described in 'damon_update_region_access_rate'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
head:   15d82784a3f9e2e8a4c635de097a86ddc744845d
commit: 2ca3eed468aa3862415dc3fee90bba1b46f7cc2b [33/46] mm/damon/core: define and use dedicated function for region access rate update
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230830/202308301305.GdlrAUWM-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230830/202308301305.GdlrAUWM-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308301305.GdlrAUWM-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> mm/damon/core.c:1612: warning: Function parameter or member 'r' not described in 'damon_update_region_access_rate'
>> mm/damon/core.c:1612: warning: Excess function parameter 'region' description in 'damon_update_region_access_rate'


vim +1612 mm/damon/core.c

  1600	
  1601	/**
  1602	 * damon_update_region_access_rate() - Update the access rate of a region.
  1603	 * @region:    The DAMON region to update for its access check result.
  1604	 * @accessed:  Whether the region has accessed during last sampling interval.
  1605	 *
  1606	 * Update the access rate of a region with the region's last sampling interval
  1607	 * access check result.
  1608	 *
  1609	 * Usually this will be called by &damon_operations->check_accesses callback.
  1610	 */
  1611	void damon_update_region_access_rate(struct damon_region *r, bool accessed)
> 1612	{
  1613		if (accessed)
  1614			r->nr_accesses++;
  1615	}
  1616	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [sj:damon/next 33/46] mm/damon/core.c:1612: warning: Function parameter or member 'r' not described in 'damon_update_region_access_rate'

[SeongJae Park]

Hi Robot,

On Wed, 30 Aug 2023 13:31:54 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
> head:   15d82784a3f9e2e8a4c635de097a86ddc744845d
> commit: 2ca3eed468aa3862415dc3fee90bba1b46f7cc2b [33/46] mm/damon/core: define and use dedicated function for region access rate update
> config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230830/202308301305.GdlrAUWM-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230830/202308301305.GdlrAUWM-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202308301305.GdlrAUWM-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> mm/damon/core.c:1612: warning: Function parameter or member 'r' not described in 'damon_update_region_access_rate'
> >> mm/damon/core.c:1612: warning: Excess function parameter 'region' description in 'damon_update_region_access_rate'

Thank you for finding this!  I will commit-amend the fix and push.


Thanks,
SJ

[...]