All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com,
	imx@lists.linux.dev, linux-i3c@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] i3c: master: fixes i3c bus driver probe failure if no i3c device attached
Date: Wed, 30 Aug 2023 17:53:55 +0200	[thread overview]
Message-ID: <20230830175355.4bc2b8d2@xps-13> (raw)
In-Reply-To: <20230830141727.3794152-1-Frank.Li@nxp.com>

Hi Frank,

Frank.Li@nxp.com wrote on Wed, 30 Aug 2023 10:17:26 -0400:

> In i3c_master_bus_init()
> {	...
> 	ret = i3c_master_rstdaa_locked(master, I3C_BROADCAST_ADDR);
> 	if (ret && ret != I3C_ERROR_M2)
> 			  ^^^ // it is enum i3c_error_code
> 	...
> }
> 
> In dw-i3c-master.c implementation:
> dw_i3c_ccc_set()
> {	...
> 	ret = xfer->ret;
> 	if (xfer->cmds[0].error == RESPONSE_ERROR_IBA_NACK)
> 		ccc->err = I3C_ERROR_M2;
> 
> 	dw_i3c_master_free_xfer(xfer);
> 
> 	return ret;
> }
> 
> Return enum i3c_error_code when error happen in i3c_master_rstdaa_locked().

I am sorry but the commit log needs to be worked on.

> 
> Cc: stable@vger.kernel.org
> Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> 
> Notes:
>     Change from v1 to v2:
>     - cc stable
> 
>  drivers/i3c/master.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 08aeb69a78003..00a82f3ab9ac0 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -783,6 +783,9 @@ static int i3c_master_rstdaa_locked(struct i3c_master_controller *master,
>  	ret = i3c_master_send_ccc_cmd_locked(master, &cmd);
>  	i3c_ccc_cmd_dest_cleanup(&dest);
>  
> +	if (ret)
> +		ret = cmd.err;

Shouldn't this happen in i3c_master_send_ccc_cmd_locked()?

> +
>  	return ret;
>  }
>  


Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com,
	imx@lists.linux.dev, linux-i3c@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] i3c: master: fixes i3c bus driver probe failure if no i3c device attached
Date: Wed, 30 Aug 2023 17:53:55 +0200	[thread overview]
Message-ID: <20230830175355.4bc2b8d2@xps-13> (raw)
In-Reply-To: <20230830141727.3794152-1-Frank.Li@nxp.com>

Hi Frank,

Frank.Li@nxp.com wrote on Wed, 30 Aug 2023 10:17:26 -0400:

> In i3c_master_bus_init()
> {	...
> 	ret = i3c_master_rstdaa_locked(master, I3C_BROADCAST_ADDR);
> 	if (ret && ret != I3C_ERROR_M2)
> 			  ^^^ // it is enum i3c_error_code
> 	...
> }
> 
> In dw-i3c-master.c implementation:
> dw_i3c_ccc_set()
> {	...
> 	ret = xfer->ret;
> 	if (xfer->cmds[0].error == RESPONSE_ERROR_IBA_NACK)
> 		ccc->err = I3C_ERROR_M2;
> 
> 	dw_i3c_master_free_xfer(xfer);
> 
> 	return ret;
> }
> 
> Return enum i3c_error_code when error happen in i3c_master_rstdaa_locked().

I am sorry but the commit log needs to be worked on.

> 
> Cc: stable@vger.kernel.org
> Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> 
> Notes:
>     Change from v1 to v2:
>     - cc stable
> 
>  drivers/i3c/master.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 08aeb69a78003..00a82f3ab9ac0 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -783,6 +783,9 @@ static int i3c_master_rstdaa_locked(struct i3c_master_controller *master,
>  	ret = i3c_master_send_ccc_cmd_locked(master, &cmd);
>  	i3c_ccc_cmd_dest_cleanup(&dest);
>  
> +	if (ret)
> +		ret = cmd.err;

Shouldn't this happen in i3c_master_send_ccc_cmd_locked()?

> +
>  	return ret;
>  }
>  


Thanks,
Miquèl

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

  parent reply	other threads:[~2023-08-30 16:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30 14:17 [PATCH v2 1/2] i3c: master: fixes i3c bus driver probe failure if no i3c device attached Frank Li
2023-08-30 14:17 ` Frank Li
2023-08-30 14:17 ` [PATCH v2 2/2] i3c: master: svc: fix probe failure when no i3c device exist Frank Li
2023-08-30 14:17   ` Frank Li
2023-08-30 15:53 ` Miquel Raynal [this message]
2023-08-30 15:53   ` [PATCH v2 1/2] i3c: master: fixes i3c bus driver probe failure if no i3c device attached Miquel Raynal
2023-08-30 16:32   ` Frank Li
2023-08-30 16:32     ` Frank Li
2023-08-31  6:57     ` Miquel Raynal
2023-08-31  6:57       ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230830175355.4bc2b8d2@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor.culhane@silvaco.com \
    --cc=imx@lists.linux.dev \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.