From: Conor Dooley <conor@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Andy Chiu <andy.chiu@sifive.com>,
linux-riscv@lists.infradead.org, palmer@dabbelt.com,
greentime.hu@sifive.com, guoren@linux.alibaba.com,
20230816155450.26200-4-andy.chiu@sifive.com, bjorn@kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Oleg Nesterov <oleg@redhat.com>,
Eric Biederman <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>,
Vincent Chen <vincent.chen@sifive.com>,
Heiko Stuebner <heiko@sntech.de>,
Conor Dooley <conor.dooley@microchip.com>,
Benjamin Gray <bgray@linux.ibm.com>,
Qing Zhang <zhangqing@loongson.cn>,
Baruch Siach <baruch@tkos.co.il>, Rolf Eike Beer <eb@emlix.com>,
llvm@lists.linux.dev, nathan@kernel.org,
regressions@leemhuis.info
Subject: Re: [v2] RISC-V: Add ptrace support for vectors
Date: Thu, 31 Aug 2023 18:17:01 +0100 [thread overview]
Message-ID: <20230831-resize-spherical-4f46639097b8@spud> (raw)
In-Reply-To: <ZPDIQEVaEJHXR5IW@google.com>
[-- Attachment #1.1: Type: text/plain, Size: 1317 bytes --]
On Thu, Aug 31, 2023 at 10:05:04AM -0700, Nick Desaulniers wrote:
> On Fri, Aug 25, 2023 at 05:02:46AM +0000, Andy Chiu wrote:
> > This patch add back the ptrace support with the following fix:
> > - Define NT_RISCV_CSR and re-number NT_RISCV_VECTOR to prevent
> > conflicting with gdb's NT_RISCV_CSR.
> > - Use struct __riscv_v_regset_state to handle ptrace requests
> >
> > Since gdb does not directly include the note description header in
> > Linux and has already defined NT_RISCV_CSR as 0x900, we decide to
> > sync with gdb and renumber NT_RISCV_VECTOR to solve and prevent future
> > conflicts.
> >
> > Fixes: 0c59922c769a ("riscv: Add ptrace vector support")
> > Signed-off-by: Andy Chiu <andy.chiu@sifive.com>
>
> Hi Andy, this is causing an instance of -Wunused-variable. PTAL.
>
> Please use the following tags on the fix:
>
> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Closes: https://lore.kernel.org/linux-next/64f03ea1.170a0220.d3dbf.11fd@mx.google.com/
>
> Let's see if I can get the regzbot tag correct; first time trying it.
>
> #regzbot introduced dbe46b094026
See <20230830203754.24940-1-palmer@rivosinc.com> for the fix.
That has you gave regzbot prob won't be stable though, branch needs a
rebase to add missing SoB tags from its committer.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Andy Chiu <andy.chiu@sifive.com>,
linux-riscv@lists.infradead.org, palmer@dabbelt.com,
greentime.hu@sifive.com, guoren@linux.alibaba.com,
20230816155450.26200-4-andy.chiu@sifive.com, bjorn@kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Oleg Nesterov <oleg@redhat.com>,
Eric Biederman <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>,
Vincent Chen <vincent.chen@sifive.com>,
Heiko Stuebner <heiko@sntech.de>,
Conor Dooley <conor.dooley@microchip.com>,
Benjamin Gray <bgray@linux.ibm.com>,
Qing Zhang <zhangqing@loongson.cn>,
Baruch Siach <baruch@tkos.co.il>, Rolf Eike Beer <eb@emlix.com>,
llvm@lists.linux.dev, nathan@kernel.org,
regressions@leemhuis.info
Subject: Re: [v2] RISC-V: Add ptrace support for vectors
Date: Thu, 31 Aug 2023 18:17:01 +0100 [thread overview]
Message-ID: <20230831-resize-spherical-4f46639097b8@spud> (raw)
In-Reply-To: <ZPDIQEVaEJHXR5IW@google.com>
[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]
On Thu, Aug 31, 2023 at 10:05:04AM -0700, Nick Desaulniers wrote:
> On Fri, Aug 25, 2023 at 05:02:46AM +0000, Andy Chiu wrote:
> > This patch add back the ptrace support with the following fix:
> > - Define NT_RISCV_CSR and re-number NT_RISCV_VECTOR to prevent
> > conflicting with gdb's NT_RISCV_CSR.
> > - Use struct __riscv_v_regset_state to handle ptrace requests
> >
> > Since gdb does not directly include the note description header in
> > Linux and has already defined NT_RISCV_CSR as 0x900, we decide to
> > sync with gdb and renumber NT_RISCV_VECTOR to solve and prevent future
> > conflicts.
> >
> > Fixes: 0c59922c769a ("riscv: Add ptrace vector support")
> > Signed-off-by: Andy Chiu <andy.chiu@sifive.com>
>
> Hi Andy, this is causing an instance of -Wunused-variable. PTAL.
>
> Please use the following tags on the fix:
>
> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Closes: https://lore.kernel.org/linux-next/64f03ea1.170a0220.d3dbf.11fd@mx.google.com/
>
> Let's see if I can get the regzbot tag correct; first time trying it.
>
> #regzbot introduced dbe46b094026
See <20230830203754.24940-1-palmer@rivosinc.com> for the fix.
That has you gave regzbot prob won't be stable though, branch needs a
rebase to add missing SoB tags from its committer.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-08-31 17:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 5:02 [v2] RISC-V: Add ptrace support for vectors Andy Chiu
2023-08-30 20:30 ` patchwork-bot+linux-riscv
2023-08-31 17:05 ` Nick Desaulniers
2023-08-31 17:05 ` Nick Desaulniers
2023-08-31 17:17 ` Conor Dooley [this message]
2023-08-31 17:17 ` Conor Dooley
2023-08-31 17:50 ` Thorsten Leemhuis
2023-08-31 17:50 ` Thorsten Leemhuis
2023-08-31 17:59 ` Nick Desaulniers
2023-08-31 17:59 ` Nick Desaulniers
2023-08-31 18:24 ` Thorsten Leemhuis
2023-08-31 18:24 ` Thorsten Leemhuis
2023-09-05 13:22 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-09-05 13:22 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-08-31 21:58 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831-resize-spherical-4f46639097b8@spud \
--to=conor@kernel.org \
--cc=20230816155450.26200-4-andy.chiu@sifive.com \
--cc=andy.chiu@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=baruch@tkos.co.il \
--cc=bgray@linux.ibm.com \
--cc=bjorn@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=eb@emlix.com \
--cc=ebiederm@xmission.com \
--cc=greentime.hu@sifive.com \
--cc=guoren@linux.alibaba.com \
--cc=heiko@sntech.de \
--cc=keescook@chromium.org \
--cc=linux-riscv@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oleg@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=regressions@leemhuis.info \
--cc=vincent.chen@sifive.com \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.