All of lore.kernel.org
 help / color / mirror / Atom feed
* [freescale-fslc:5.15-2.2.x-imx 160/24604] sound/soc/codecs/pcm512x.c:1595:7: warning: unused variable 'clk_name'
@ 2023-08-31  5:29 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-08-31  5:29 UTC (permalink / raw)
  To: Otavio Salvador; +Cc: oe-kbuild-all

Hi Adrian,

FYI, the error/warning still remains.

tree:   https://github.com/Freescale/linux-fslc 5.15-2.2.x-imx
head:   7c13adcd3af7dcd541144655102e1cdb941ad538
commit: c7981269740967250226190f3236434d1f060084 [160/24604] MLK-25015: sound: soc: codecs: pcm512x: set input sclk
config: hexagon-randconfig-r013-20230831 (https://download.01.org/0day-ci/archive/20230831/202308311308.77SwqqDO-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230831/202308311308.77SwqqDO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308311308.77SwqqDO-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> sound/soc/codecs/pcm512x.c:1595:7: warning: unused variable 'clk_name' [-Wunused-variable]
           char clk_name[8];
                ^
   1 warning generated.


vim +/clk_name +1595 sound/soc/codecs/pcm512x.c

  1591	
  1592	int pcm512x_probe(struct device *dev, struct regmap *regmap)
  1593	{
  1594		struct pcm512x_priv *pcm512x;
> 1595		char clk_name[8];
  1596		int i, ret;
  1597	
  1598		pcm512x = devm_kzalloc(dev, sizeof(struct pcm512x_priv), GFP_KERNEL);
  1599		if (!pcm512x)
  1600			return -ENOMEM;
  1601	
  1602		mutex_init(&pcm512x->mutex);
  1603	
  1604		dev_set_drvdata(dev, pcm512x);
  1605		pcm512x->regmap = regmap;
  1606	
  1607		for (i = 0; i < ARRAY_SIZE(pcm512x->supplies); i++)
  1608			pcm512x->supplies[i].supply = pcm512x_supply_names[i];
  1609	
  1610		ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(pcm512x->supplies),
  1611					      pcm512x->supplies);
  1612		if (ret != 0) {
  1613			dev_err(dev, "Failed to get supplies: %d\n", ret);
  1614			return ret;
  1615		}
  1616	
  1617		pcm512x->supply_nb[0].notifier_call = pcm512x_regulator_event_0;
  1618		pcm512x->supply_nb[1].notifier_call = pcm512x_regulator_event_1;
  1619		pcm512x->supply_nb[2].notifier_call = pcm512x_regulator_event_2;
  1620	
  1621		for (i = 0; i < ARRAY_SIZE(pcm512x->supplies); i++) {
  1622			ret = devm_regulator_register_notifier(
  1623							pcm512x->supplies[i].consumer,
  1624							&pcm512x->supply_nb[i]);
  1625			if (ret != 0) {
  1626				dev_err(dev,
  1627					"Failed to register regulator notifier: %d\n",
  1628					ret);
  1629			}
  1630		}
  1631	
  1632		ret = regulator_bulk_enable(ARRAY_SIZE(pcm512x->supplies),
  1633					    pcm512x->supplies);
  1634		if (ret != 0) {
  1635			dev_err(dev, "Failed to enable supplies: %d\n", ret);
  1636			return ret;
  1637		}
  1638	
  1639		/* Reset the device, verifying I/O in the process for I2C */
  1640		ret = regmap_write(regmap, PCM512x_RESET,
  1641				   PCM512x_RSTM | PCM512x_RSTR);
  1642		if (ret != 0) {
  1643			dev_err(dev, "Failed to reset device: %d\n", ret);
  1644			goto err;
  1645		}
  1646	
  1647		ret = regmap_write(regmap, PCM512x_RESET, 0);
  1648		if (ret != 0) {
  1649			dev_err(dev, "Failed to reset device: %d\n", ret);
  1650			goto err;
  1651		}
  1652	
  1653		/* default to first sclk */
  1654		pcm512x->num_clocks = 1;
  1655		pcm512x->sclk_src = PCM512x_SYSCLK_MCLK1;
  1656	
  1657		pcm512x->sclk[0] = devm_clk_get(dev, NULL);
  1658		if (PTR_ERR(pcm512x->sclk[0]) == -EPROBE_DEFER) {
  1659			ret = -EPROBE_DEFER;
  1660			goto err;
  1661		}
  1662	
  1663		if (!IS_ERR(pcm512x->sclk[0])) {
  1664			ret = clk_prepare_enable(pcm512x->sclk[0]);
  1665			if (ret != 0) {
  1666				dev_err(dev, "Failed to enable SCLK: %d\n", ret);
  1667				goto err;
  1668			}
  1669		}
  1670	
  1671		/* Default to standby mode */
  1672		ret = regmap_update_bits(pcm512x->regmap, PCM512x_POWER,
  1673					 PCM512x_RQST, PCM512x_RQST);
  1674		if (ret != 0) {
  1675			dev_err(dev, "Failed to request standby: %d\n",
  1676				ret);
  1677			goto err_clk;
  1678		}
  1679	
  1680		pm_runtime_set_active(dev);
  1681		pm_runtime_enable(dev);
  1682		pm_runtime_idle(dev);
  1683	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-08-31  5:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-31  5:29 [freescale-fslc:5.15-2.2.x-imx 160/24604] sound/soc/codecs/pcm512x.c:1595:7: warning: unused variable 'clk_name' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.