All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com,
	imx@lists.linux.dev, linux-i3c@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] i3c: master: svc: fix probe failure when no i3c device exist
Date: Thu, 31 Aug 2023 16:21:34 +0200	[thread overview]
Message-ID: <20230831162134.6ccbaf23@xps-13> (raw)
In-Reply-To: <20230831141324.2841525-1-Frank.Li@nxp.com>

Hi Frank,

Frank.Li@nxp.com wrote on Thu, 31 Aug 2023 10:13:24 -0400:

> I3C masters are expected to support hot-join. This means at initialization
> time we might not yet discover any device and this should not be treated
> as a fatal error.
> 
> During the DAA procedure which happens at probe time, if no device has
> joined, all CCC will be NACKed (from a bus perspective). This leads to an
> early return with an error code which fails the probe of the master.
> 
> Let's avoid this by just telling the core through an I3C_ERROR_M2
> return command code that no device was discovered, which is a valid
> situation. This way the master will no longer bail out and fail to probe
> for a wrong reason.
> 
> Cc: stable@vger.kernel.org
> Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com,
	imx@lists.linux.dev, linux-i3c@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] i3c: master: svc: fix probe failure when no i3c device exist
Date: Thu, 31 Aug 2023 16:21:34 +0200	[thread overview]
Message-ID: <20230831162134.6ccbaf23@xps-13> (raw)
In-Reply-To: <20230831141324.2841525-1-Frank.Li@nxp.com>

Hi Frank,

Frank.Li@nxp.com wrote on Thu, 31 Aug 2023 10:13:24 -0400:

> I3C masters are expected to support hot-join. This means at initialization
> time we might not yet discover any device and this should not be treated
> as a fatal error.
> 
> During the DAA procedure which happens at probe time, if no device has
> joined, all CCC will be NACKed (from a bus perspective). This leads to an
> early return with an error code which fails the probe of the master.
> 
> Let's avoid this by just telling the core through an I3C_ERROR_M2
> return command code that no device was discovered, which is a valid
> situation. This way the master will no longer bail out and fail to probe
> for a wrong reason.
> 
> Cc: stable@vger.kernel.org
> Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

  reply	other threads:[~2023-08-31 14:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31 14:13 [PATCH v3 1/1] i3c: master: svc: fix probe failure when no i3c device exist Frank Li
2023-08-31 14:13 ` Frank Li
2023-08-31 14:21 ` Miquel Raynal [this message]
2023-08-31 14:21   ` Miquel Raynal
2023-09-05 23:22 ` Alexandre Belloni
2023-09-05 23:22   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230831162134.6ccbaf23@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor.culhane@silvaco.com \
    --cc=imx@lists.linux.dev \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.