From: "Michael Büsch" <m@bues.ch>
To: "Ранд Дееб" <deeb.rand@confident.ru>
Cc: "Larry Finger" <Larry.Finger@lwfinger.net>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org,
"Воскресенский Станислав Игоревич"
<voskresenski.stanislav@confident.ru>
Subject: Re: [PATCH] ssb-main: Fix division by zero in ssb_calc_clock_rate()
Date: Thu, 31 Aug 2023 18:05:06 +0200 [thread overview]
Message-ID: <20230831180506.30466e8a@barney> (raw)
In-Reply-To: <531722477.1139813.1693465653233.JavaMail.zimbra@confident.ru>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Thu, 31 Aug 2023 10:07:33 +0300 (MSK)
Ранд Дееб <deeb.rand@confident.ru> wrote:
> 1- Yes, I agree that your solution is simpler, and I thought about
> it, but I thought that the one who set the value zero put it for some
> reason, so I did not want to change it.
Yes, I understand your reasoning and I had the same thought initially.
But I looked into the code and I am pretty sure that there is no reason
for the default case returning 0.
In fact, I think returning a 1 as default makes much more sense as the
default value for a factor.
Changing this from 0 to 1 will get my ack.
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-08-31 16:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 8:27 [PATCH] ssb-main: Fix division by zero in ssb_calc_clock_rate() Rand Deeb
2023-08-30 19:50 ` Larry Finger
2023-08-30 20:37 ` Michael Büsch
2023-08-31 7:07 ` Ранд Дееб
2023-08-31 13:46 ` Krzysztof Kozlowski
2023-08-31 15:35 ` Ранд Дееб
2023-08-31 16:05 ` Michael Büsch [this message]
2023-08-31 17:59 ` Larry Finger
2023-08-31 13:47 ` Krzysztof Kozlowski
2023-08-31 13:45 ` Krzysztof Kozlowski
2023-08-31 14:25 ` Ранд Дееб
2023-08-31 14:53 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2023-08-29 11:12 Rand Deeb
2023-08-29 17:35 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831180506.30466e8a@barney \
--to=m@bues.ch \
--cc=Larry.Finger@lwfinger.net \
--cc=deeb.rand@confident.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=voskresenski.stanislav@confident.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.