From: Krzysztof Kozlowski <krzk@kernel.org>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Rand Deeb <deeb.rand@confident.ru>, Michael Buesch <m@bues.ch>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: lvc-project@linuxtesting.org, voskresenski.stanislav@confident.ru
Subject: Re: [PATCH] ssb-main: Fix division by zero in ssb_calc_clock_rate()
Date: Thu, 31 Aug 2023 15:47:39 +0200 [thread overview]
Message-ID: <6dad0aa6-b1bd-96ff-4c88-89a59783331b@kernel.org> (raw)
In-Reply-To: <4c6d01bf-1a0f-27de-54e1-4afdcf4bc8d5@lwfinger.net>
On 30/08/2023 21:50, Larry Finger wrote:
>
> /* Calculate the speed the backplane would run at a given set of clockcontrol
> values */
>
> Your patch has some technical problems as well. The subject should be "ssb: Fix
> division ..." In addition, note that all your if statements have an extraneous
> "3D" as in "(m1 !=3D 0)". To me, that indicates that your mailer is not sending
> plain text.
It's sending everything as quoted-printable. Nothing improved here from
their previous version.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-31 13:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 8:27 [PATCH] ssb-main: Fix division by zero in ssb_calc_clock_rate() Rand Deeb
2023-08-30 19:50 ` Larry Finger
2023-08-30 20:37 ` Michael Büsch
2023-08-31 7:07 ` Ранд Дееб
2023-08-31 13:46 ` Krzysztof Kozlowski
2023-08-31 15:35 ` Ранд Дееб
2023-08-31 16:05 ` Michael Büsch
2023-08-31 17:59 ` Larry Finger
2023-08-31 13:47 ` Krzysztof Kozlowski [this message]
2023-08-31 13:45 ` Krzysztof Kozlowski
2023-08-31 14:25 ` Ранд Дееб
2023-08-31 14:53 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2023-08-29 11:12 Rand Deeb
2023-08-29 17:35 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dad0aa6-b1bd-96ff-4c88-89a59783331b@kernel.org \
--to=krzk@kernel.org \
--cc=Larry.Finger@lwfinger.net \
--cc=deeb.rand@confident.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=m@bues.ch \
--cc=voskresenski.stanislav@confident.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.