* [freescale-fslc:pr/639 6178/24603] drivers/pci/controller/dwc/pci-imx6.c:2882:11: warning: variable 'ret' set but not used
@ 2023-08-31 10:18 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-08-31 10:18 UTC (permalink / raw)
To: Otavio Salvador; +Cc: oe-kbuild-all
Hi Dong,
FYI, the error/warning still remains.
tree: https://github.com/Freescale/linux-fslc pr/639
head: 857fbf7cebaba3b1ffccc558deee1d13ac0e11d7
commit: 57c0f9fc3024aa4d28f39a99a56cffd31c845c58 [6178/24603] Merge branch 'pcie/next' into next
config: i386-randconfig-013-20230831 (https://download.01.org/0day-ci/archive/20230831/202308311813.CRAaZ5us-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230831/202308311813.CRAaZ5us-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308311813.CRAaZ5us-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/pci/controller/dwc/pci-imx6.c:905:2: warning: variable 'ret' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/pci/controller/dwc/pci-imx6.c:908:6: note: uninitialized use occurs here
if (ret)
^~~
drivers/pci/controller/dwc/pci-imx6.c:874:7: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (cond >= 2000)
^~~~~~~~~~~~
drivers/pci/controller/dwc/pci-imx6.c:908:6: note: uninitialized use occurs here
if (ret)
^~~
drivers/pci/controller/dwc/pci-imx6.c:874:3: note: remove the 'if' if its condition is always true
if (cond >= 2000)
^~~~~~~~~~~~~~~~~
drivers/pci/controller/dwc/pci-imx6.c:863:7: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (cond >= 2000)
^~~~~~~~~~~~
drivers/pci/controller/dwc/pci-imx6.c:908:6: note: uninitialized use occurs here
if (ret)
^~~
drivers/pci/controller/dwc/pci-imx6.c:863:3: note: remove the 'if' if its condition is always true
if (cond >= 2000)
^~~~~~~~~~~~~~~~~
drivers/pci/controller/dwc/pci-imx6.c:847:9: note: initialize the variable 'ret' to silence this warning
int ret;
^
= 0
drivers/pci/controller/dwc/pci-imx6.c:2922:29: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
if ((rc_l1sub && ep_l1sub) && PCI_L1SS_CAP_L1_PM_SS) {
^ ~~~~~~~~~~~~~~~~~~~~~
drivers/pci/controller/dwc/pci-imx6.c:2922:29: note: use '&' for a bitwise operation
if ((rc_l1sub && ep_l1sub) && PCI_L1SS_CAP_L1_PM_SS) {
^~
&
drivers/pci/controller/dwc/pci-imx6.c:2922:29: note: remove constant to silence this warning
if ((rc_l1sub && ep_l1sub) && PCI_L1SS_CAP_L1_PM_SS) {
~^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/pci/controller/dwc/pci-imx6.c:2882:11: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
int ttl, ret;
^
5 warnings generated.
vim +/ret +2882 drivers/pci/controller/dwc/pci-imx6.c
bb38919ec56e07 drivers/pci/host/pci-imx6.c Sean Cross 2013-09-26 2847
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2848 static void imx6_pcie_quirk(struct pci_dev *dev)
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2849 {
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2850 struct pci_bus *bus = dev->bus;
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2851 struct pcie_port *pp = bus->sysdata;
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2852
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2853 /* Bus parent is the PCI bridge, its parent is this platform driver */
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2854 if (!bus->dev.parent || !bus->dev.parent->parent)
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2855 return;
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2856
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2857 /* Make sure we only quirk devices associated with this driver */
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2858 if (bus->dev.parent->parent->driver != &imx6_pcie_driver.driver)
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2859 return;
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2860
55254938662458 drivers/pci/controller/dwc/pci-imx6.c Rob Herring 2020-07-21 2861 if (pci_is_root_bus(bus)) {
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2862 struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2863 struct imx6_pcie *imx6_pcie = to_imx6_pcie(pci);
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2864
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2865 /*
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2866 * Limit config length to avoid the kernel reading beyond
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2867 * the register set and causing an abort on i.MX 6Quad
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2868 */
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2869 if (imx6_pcie->drvdata->dbi_length) {
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2870 dev->cfg_size = imx6_pcie->drvdata->dbi_length;
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2871 dev_info(&dev->dev, "Limiting cfg_size to %d\n",
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2872 dev->cfg_size);
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2873 }
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2874 }
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2875 }
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2876 DECLARE_PCI_FIXUP_CLASS_HEADER(PCI_VENDOR_ID_SYNOPSYS, 0xabcd,
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2877 PCI_CLASS_BRIDGE_PCI, 8, imx6_pcie_quirk);
075af61c19cdc3 drivers/pci/controller/dwc/pci-imx6.c Stefan Agner 2019-07-26 2878
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2879 static void imx6_pcie_l1ss_quirk(struct pci_dev *dev)
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2880 {
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2881 u32 reg, rc_l1sub, ep_l1sub, header;
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 @2882 int ttl, ret;
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2883 int pos = PCI_CFG_SPACE_SIZE;
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2884 struct pci_bus *bus = dev->bus;
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2885 struct pcie_port *pp = bus->sysdata;
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2886 struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2887 struct imx6_pcie *imx6_pcie = to_imx6_pcie(pci);
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2888
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2889 /* Return directly, if the L1SS is not supported by RC */
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2890 if (!(imx6_pcie->drvdata->flags & IMX6_PCIE_FLAG_SUPPORTS_L1SS))
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2891 return;
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2892
68db96f391f94b drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-03-08 2893 /* Make sure the L1SS is not force disabled. */
68db96f391f94b drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-03-08 2894 if (imx6_pcie->l1ss_clkreq == 0)
68db96f391f94b drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-03-08 2895 return;
68db96f391f94b drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-03-08 2896
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2897 reg = dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_L1SS);
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2898 rc_l1sub = dw_pcie_readl_dbi(pci, reg + PCI_L1SS_CAP);
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2899
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2900 /* minimum 8 bytes per capability */
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2901 ttl = (PCI_CFG_SPACE_EXP_SIZE - PCI_CFG_SPACE_SIZE) / 8;
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2902 ret = dw_pcie_read(pp->va_cfg0_base + pos, 4, &header);
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2903 /*
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2904 * If we have no capabilities, this is indicated by cap ID,
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2905 * cap version and next pointer all being 0.
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2906 */
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2907 if (header == 0)
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2908 return;
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2909
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2910 while (ttl-- > 0) {
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2911 if (PCI_EXT_CAP_ID(header) == PCI_EXT_CAP_ID_L1SS && pos != 0)
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2912 break;
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2913
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2914 pos = PCI_EXT_CAP_NEXT(header);
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2915 if (pos < PCI_CFG_SPACE_SIZE)
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2916 break;
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2917
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2918 ret = dw_pcie_read(pp->va_cfg0_base + pos, 4, &header);
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2919 }
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2920 ret = dw_pcie_read(pp->va_cfg0_base + pos + PCI_L1SS_CAP, 4, &ep_l1sub);
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2921
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2922 if ((rc_l1sub && ep_l1sub) && PCI_L1SS_CAP_L1_PM_SS) {
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2923 imx6_pcie->l1ss_clkreq = 1;
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2924 imx6_pcie_clkreq_enable(imx6_pcie);
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2925 } else {
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2926 imx6_pcie->l1ss_clkreq = 0;
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2927 }
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2928 }
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2929 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SYNOPSYS, 0xabcd, imx6_pcie_l1ss_quirk);
a12a943c1ab066 drivers/pci/controller/dwc/pci-imx6.c Richard Zhu 2021-02-09 2930
:::::: The code at line 2882 was first introduced by commit
:::::: a12a943c1ab0665ee6d5c3249e1363a4cfabc7d4 MLK-25283-4 PCI: imx: adjust the l1ss support to proper place
:::::: TO: Richard Zhu <hongxing.zhu@nxp.com>
:::::: CC: Dong Aisheng <aisheng.dong@nxp.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-08-31 10:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-31 10:18 [freescale-fslc:pr/639 6178/24603] drivers/pci/controller/dwc/pci-imx6.c:2882:11: warning: variable 'ret' set but not used kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.