Re: [PATCH 2/3] regulator: userspace-consumer: Add regulator event support

Re: [PATCH 2/3] regulator: userspace-consumer: Add regulator event support

[kernel test robot]

Hi Naresh,

kernel test robot noticed the following build errors:

[auto build test ERROR on 35d0d2350d774fecf596cfb2fb050559fe5e1850]

url:    https://github.com/intel-lab-lkp/linux/commits/Naresh-Solanki/regulator-userspace-consumer-Add-regulator-event-support/20230831-201619
base:   35d0d2350d774fecf596cfb2fb050559fe5e1850
patch link:    https://lore.kernel.org/r/20230831121412.2359239-2-Naresh.Solanki%409elements.com
patch subject: [PATCH 2/3] regulator: userspace-consumer: Add regulator event support
config: openrisc-randconfig-r016-20230901 (https://download.01.org/0day-ci/archive/20230901/202309011007.XMgtARDc-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230901/202309011007.XMgtARDc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309011007.XMgtARDc-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/regulator/userspace-consumer.c: In function 'regulator_userspace_notify':
>> drivers/regulator/userspace-consumer.c:146:47: error: initialization of 'const char * const*' from incompatible pointer type 'char *' [-Werror=incompatible-pointer-types]
     146 |         static const char * const *envp[] = { "NAME=events", NULL };
         |                                               ^~~~~~~~~~~~~
   drivers/regulator/userspace-consumer.c:146:47: note: (near initialization for 'envp[0]')
>> drivers/regulator/userspace-consumer.c:153:53: error: passing argument 3 of 'kobject_uevent_env' from incompatible pointer type [-Werror=incompatible-pointer-types]
     153 |         kobject_uevent_env(data->kobj, KOBJ_CHANGE, envp);
         |                                                     ^~~~
         |                                                     |
         |                                                     const char * const**
   In file included from include/linux/module.h:21,
                    from drivers/regulator/userspace-consumer.c:16:
   include/linux/kobject.h:214:31: note: expected 'char **' but argument is of type 'const char * const**'
     214 |                         char *envp[]);
         |                         ~~~~~~^~~~~~
   cc1: some warnings being treated as errors


vim +146 drivers/regulator/userspace-consumer.c

   139	
   140	static int regulator_userspace_notify(struct notifier_block *nb,
   141					      unsigned long event,
   142					      void *ignored)
   143	{
   144		struct userspace_consumer_data *data =
   145			container_of(nb, struct userspace_consumer_data, nb);
 > 146		static const char * const *envp[] = { "NAME=events", NULL };
   147	
   148		spin_lock(&events_lock);
   149		data->events |= event;
   150		spin_unlock(&events_lock);
   151	
   152		sysfs_notify(data->kobj, NULL, dev_attr_events.attr.name);
 > 153		kobject_uevent_env(data->kobj, KOBJ_CHANGE, envp);
   154	
   155		return NOTIFY_OK;
   156	}
   157	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki