+ selftests-mm-gup_longterm-fix-a-resource-leak.patch added to mm-unstable branch

+ selftests-mm-gup_longterm-fix-a-resource-leak.patch added to mm-unstable branch

[Andrew Morton]

The patch titled
     Subject: selftests/mm: gup_longterm: fix a resource leak
has been added to the -mm mm-unstable branch.  Its filename is
     selftests-mm-gup_longterm-fix-a-resource-leak.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/selftests-mm-gup_longterm-fix-a-resource-leak.patch

This patch will later appear in the mm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Ding Xiang <dingxiang@cmss.chinamobile.com>
Subject: selftests/mm: gup_longterm: fix a resource leak
Date: Thu, 31 Aug 2023 17:31:44 +0800

The opened file should be closed in run_with_tmpfile(), otherwise resource
leak will occur

Link: https://lkml.kernel.org/r/20230831093144.7520-1-dingxiang@cmss.chinamobile.com
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 tools/testing/selftests/mm/gup_longterm.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/tools/testing/selftests/mm/gup_longterm.c~selftests-mm-gup_longterm-fix-a-resource-leak
+++ a/tools/testing/selftests/mm/gup_longterm.c
@@ -265,10 +265,11 @@ static void run_with_tmpfile(test_fn fn,
 	fd = fileno(file);
 	if (fd < 0) {
 		ksft_test_result_fail("fileno() failed\n");
-		return;
+		goto close;
 	}
 
 	fn(fd, pagesize);
+close:
 	fclose(file);
 }
 
_

Patches currently in -mm which might be from dingxiang@cmss.chinamobile.com are

selftests-mm-gup_longterm-fix-a-resource-leak.patch