From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Nixdorf <jnixdorf-oss@avm.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
bridge@lists.linux-foundation.org,
Ido Schimmel <idosch@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Roopa Prabhu <roopa@nvidia.com>,
linux-kernel@vger.kernel.org,
Oleksij Rempel <linux@rempel-privat.de>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
David Ahern <dsahern@gmail.com>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net-next v3 1/6] net: bridge: Set BR_FDB_ADDED_BY_USER early in fdb_add_entry
Date: Tue, 5 Sep 2023 13:53:24 -0700 [thread overview]
Message-ID: <20230905135324.1b9f7be4@kernel.org> (raw)
In-Reply-To: <20230905-fdb_limit-v3-1-7597cd500a82@avm.de>
On Tue, 05 Sep 2023 13:47:18 +0200 Johannes Nixdorf wrote:
> --- a/net/bridge/br_fdb.c
> +++ b/net/bridge/br_fdb.c
> @@ -1056,7 +1056,7 @@ static int fdb_add_entry(struct net_bridge *br, struct net_bridge_port *source,
> if (!(flags & NLM_F_CREATE))
> return -ENOENT;
>
> - fdb = fdb_create(br, source, addr, vid, 0);
> + fdb = fdb_create(br, source, addr, vid, BIT(BR_FDB_ADDED_BY_USER));
Please try to wrap your code at 80 chars. Also:
## Form letter - net-next-closed
The merge window for v6.6 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.
Please repost when net-next reopens after Sept 11th.
RFC patches sent for review only are obviously welcome at any time.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
--
pw-bot: defer
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Nixdorf <jnixdorf-oss@avm.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, David Ahern <dsahern@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ido Schimmel <idosch@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Oleksij Rempel <linux@rempel-privat.de>,
Paolo Abeni <pabeni@redhat.com>, Roopa Prabhu <roopa@nvidia.com>,
Shuah Khan <shuah@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/6] net: bridge: Set BR_FDB_ADDED_BY_USER early in fdb_add_entry
Date: Tue, 5 Sep 2023 13:53:24 -0700 [thread overview]
Message-ID: <20230905135324.1b9f7be4@kernel.org> (raw)
In-Reply-To: <20230905-fdb_limit-v3-1-7597cd500a82@avm.de>
On Tue, 05 Sep 2023 13:47:18 +0200 Johannes Nixdorf wrote:
> --- a/net/bridge/br_fdb.c
> +++ b/net/bridge/br_fdb.c
> @@ -1056,7 +1056,7 @@ static int fdb_add_entry(struct net_bridge *br, struct net_bridge_port *source,
> if (!(flags & NLM_F_CREATE))
> return -ENOENT;
>
> - fdb = fdb_create(br, source, addr, vid, 0);
> + fdb = fdb_create(br, source, addr, vid, BIT(BR_FDB_ADDED_BY_USER));
Please try to wrap your code at 80 chars. Also:
## Form letter - net-next-closed
The merge window for v6.6 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.
Please repost when net-next reopens after Sept 11th.
RFC patches sent for review only are obviously welcome at any time.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
--
pw-bot: defer
next prev parent reply other threads:[~2023-09-05 20:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 11:47 [Bridge] [PATCH net-next v3 0/6] bridge: Add a limit on learned FDB entries Johannes Nixdorf
2023-09-05 11:47 ` Johannes Nixdorf
2023-09-05 11:47 ` [Bridge] [PATCH net-next v3 1/6] net: bridge: Set BR_FDB_ADDED_BY_USER early in fdb_add_entry Johannes Nixdorf
2023-09-05 11:47 ` Johannes Nixdorf
2023-09-05 20:53 ` Jakub Kicinski [this message]
2023-09-05 20:53 ` Jakub Kicinski
2023-09-05 11:47 ` [Bridge] [PATCH net-next v3 2/6] net: bridge: Set strict_start_type for br_policy Johannes Nixdorf
2023-09-05 11:47 ` Johannes Nixdorf
2023-09-05 11:47 ` [Bridge] [PATCH net-next v3 3/6] net: bridge: Track and limit dynamically learned FDB entries Johannes Nixdorf
2023-09-05 11:47 ` Johannes Nixdorf
2023-09-14 15:15 ` [Bridge] " Nikolay Aleksandrov
2023-09-14 15:15 ` Nikolay Aleksandrov
2023-09-05 11:47 ` [Bridge] [PATCH net-next v3 4/6] net: bridge: Add netlink knobs for number / max " Johannes Nixdorf
2023-09-05 11:47 ` Johannes Nixdorf
2023-09-05 11:47 ` [Bridge] [PATCH net-next v3 5/6] net: bridge: Add a configurable default FDB learning limit Johannes Nixdorf
2023-09-05 11:47 ` Johannes Nixdorf
2023-09-05 11:47 ` [Bridge] [PATCH net-next v3 6/6] selftests: forwarding: bridge_fdb_learning_limit: Add a new selftest Johannes Nixdorf
2023-09-05 11:47 ` Johannes Nixdorf
2023-09-05 20:53 ` [Bridge] " Jakub Kicinski
2023-09-05 20:53 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905135324.1b9f7be4@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=jnixdorf-oss@avm.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=shuah@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.