From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Mining Lin <mimi05633@gmail.com>
Cc: avifishman70@gmail.com, tmaimon77@gmail.com,
tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
benjaminfair@google.com, a.zummo@towertech.it, KWLIU@nuvoton.com,
JJLIU0@nuvoton.com, KFLIN@nuvoton.com, mylin1@nuvoton.com,
openbmc@lists.ozlabs.org, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/1] rtc: nuvoton: Compatible with NCT3015Y-R and NCT3018Y-R
Date: Wed, 6 Sep 2023 16:01:23 +0200 [thread overview]
Message-ID: <20230906140123dd8ffac4@mail.local> (raw)
In-Reply-To: <D6734DA5-839E-40A6-9085-F25BB8D70022@gmail.com>
On 06/09/2023 09:19:29+0800, Mining Lin wrote:
> >> static int nct3018y_set_alarm_mode(struct i2c_client *client, bool on)
> >> {
> >> int err, flags;
> >> @@ -55,7 +59,7 @@ static int nct3018y_set_alarm_mode(struct i2c_client *client, bool on)
> >> flags = i2c_smbus_read_byte_data(client, NCT3018Y_REG_CTRL);
> >> if (flags < 0) {
> >> dev_dbg(&client->dev,
> >> - "Failed to read NCT3018Y_REG_CTRL\n");
> >> + "%s: Failed to read ctrl reg.\n", __func__);
> >
> > If you really insist on this change, what about:
> >
> > #define pr_fmt(fmt) "%s: " fmt, __func__
> [Mia] Do you mean to replace dev_dbg with pr_debug? If yes, for consistency, I'm going to refine all messages via pr_debug. Thank you for your suggestion.
No, I mean that instead of adding __func__ to all the messages just
define pr_fmt, this should achieve what you want.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Mining Lin <mimi05633@gmail.com>
Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it,
mylin1@nuvoton.com, benjaminfair@google.com, KWLIU@nuvoton.com,
avifishman70@gmail.com, venture@google.com,
openbmc@lists.ozlabs.org, JJLIU0@nuvoton.com,
linux-kernel@vger.kernel.org, tali.perry1@gmail.com,
KFLIN@nuvoton.com, tmaimon77@gmail.com
Subject: Re: [PATCH v5 1/1] rtc: nuvoton: Compatible with NCT3015Y-R and NCT3018Y-R
Date: Wed, 6 Sep 2023 16:01:23 +0200 [thread overview]
Message-ID: <20230906140123dd8ffac4@mail.local> (raw)
In-Reply-To: <D6734DA5-839E-40A6-9085-F25BB8D70022@gmail.com>
On 06/09/2023 09:19:29+0800, Mining Lin wrote:
> >> static int nct3018y_set_alarm_mode(struct i2c_client *client, bool on)
> >> {
> >> int err, flags;
> >> @@ -55,7 +59,7 @@ static int nct3018y_set_alarm_mode(struct i2c_client *client, bool on)
> >> flags = i2c_smbus_read_byte_data(client, NCT3018Y_REG_CTRL);
> >> if (flags < 0) {
> >> dev_dbg(&client->dev,
> >> - "Failed to read NCT3018Y_REG_CTRL\n");
> >> + "%s: Failed to read ctrl reg.\n", __func__);
> >
> > If you really insist on this change, what about:
> >
> > #define pr_fmt(fmt) "%s: " fmt, __func__
> [Mia] Do you mean to replace dev_dbg with pr_debug? If yes, for consistency, I'm going to refine all messages via pr_debug. Thank you for your suggestion.
No, I mean that instead of adding __func__ to all the messages just
define pr_fmt, this should achieve what you want.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-09-06 14:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 6:03 [PATCH v5 0/1] Compatible with NCT3015Y-R and NCT3018Y-R Mia Lin
2023-09-05 6:03 ` Mia Lin
2023-09-05 6:03 ` [PATCH v5 1/1] rtc: nuvoton: " Mia Lin
2023-09-05 6:03 ` Mia Lin
2023-09-05 6:35 ` Alexandre Belloni
2023-09-05 6:35 ` Alexandre Belloni
2023-09-06 1:19 ` Mining Lin
2023-09-06 1:19 ` Mining Lin
2023-09-06 14:01 ` Alexandre Belloni [this message]
2023-09-06 14:01 ` Alexandre Belloni
2023-09-07 12:35 ` Mining Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230906140123dd8ffac4@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=JJLIU0@nuvoton.com \
--cc=KFLIN@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=a.zummo@towertech.it \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mimi05633@gmail.com \
--cc=mylin1@nuvoton.com \
--cc=openbmc@lists.ozlabs.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.