From: Greg KH <gregkh@linuxfoundation.org>
To: Will Deacon <will@kernel.org>
Cc: stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Joey Gouly <joey.gouly@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
John Hsu <John.Hsu@mediatek.com>
Subject: Re: [STABLE PATCH 5.15.y] arm64: lib: Import latest version of Arm Optimized Routines' strncmp
Date: Thu, 7 Sep 2023 12:23:23 +0100 [thread overview]
Message-ID: <2023090716-extenuate-jittery-25bd@gregkh> (raw)
In-Reply-To: <20230906180336.4973-1-will@kernel.org>
On Wed, Sep 06, 2023 at 07:03:36PM +0100, Will Deacon wrote:
> From: Joey Gouly <joey.gouly@arm.com>
>
> commit 387d828adffcf1eb949f3141079c479793c59aac upstream.
>
> Import the latest version of the Arm Optimized Routines strncmp function based
> on the upstream code of string/aarch64/strncmp.S at commit 189dfefe37d5 from:
> https://github.com/ARM-software/optimized-routines
>
> This latest version includes MTE support.
>
> Note that for simplicity Arm have chosen to contribute this code to Linux under
> GPLv2 rather than the original MIT OR Apache-2.0 WITH LLVM-exception license.
> Arm is the sole copyright holder for this code.
>
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> Link: https://lore.kernel.org/r/20220301101435.19327-3-joey.gouly@arm.com
> (cherry picked from commit 387d828adffcf1eb949f3141079c479793c59aac)
> Cc: <stable@vger.kernel.org> # 5.15.y only
> Fixes: 020b199bc70d ("arm64: Import latest version of Cortex Strings' strncmp")
> Reported-by: John Hsu <John.Hsu@mediatek.com>
> Link: https://lore.kernel.org/all/e9f30f7d5b7d72a3521da31ab2002b49a26f542e.camel@mediatek.com/
> Signed-off-by: Will Deacon <will@kernel.org>
> ---
>
> This is a clean cherry-pick of the latest MTE-safe strncmp()
> implementation for arm64 which landed in v5.18 and somewhat accidentally
> fixed an out-of-bounds read introduced in v5.14.
> An alternative would be to disable the optimised code altogether, but
> given that this is self-contained and applies cleanly, I'd favour being
> consistent with more recent kernels.
>
> arch/arm64/lib/strncmp.S | 244 +++++++++++++++++++++++----------------
> 1 file changed, 146 insertions(+), 98 deletions(-)
Now queued up, thanks.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Will Deacon <will@kernel.org>
Cc: stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Joey Gouly <joey.gouly@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
John Hsu <John.Hsu@mediatek.com>
Subject: Re: [STABLE PATCH 5.15.y] arm64: lib: Import latest version of Arm Optimized Routines' strncmp
Date: Thu, 7 Sep 2023 12:23:23 +0100 [thread overview]
Message-ID: <2023090716-extenuate-jittery-25bd@gregkh> (raw)
In-Reply-To: <20230906180336.4973-1-will@kernel.org>
On Wed, Sep 06, 2023 at 07:03:36PM +0100, Will Deacon wrote:
> From: Joey Gouly <joey.gouly@arm.com>
>
> commit 387d828adffcf1eb949f3141079c479793c59aac upstream.
>
> Import the latest version of the Arm Optimized Routines strncmp function based
> on the upstream code of string/aarch64/strncmp.S at commit 189dfefe37d5 from:
> https://github.com/ARM-software/optimized-routines
>
> This latest version includes MTE support.
>
> Note that for simplicity Arm have chosen to contribute this code to Linux under
> GPLv2 rather than the original MIT OR Apache-2.0 WITH LLVM-exception license.
> Arm is the sole copyright holder for this code.
>
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> Link: https://lore.kernel.org/r/20220301101435.19327-3-joey.gouly@arm.com
> (cherry picked from commit 387d828adffcf1eb949f3141079c479793c59aac)
> Cc: <stable@vger.kernel.org> # 5.15.y only
> Fixes: 020b199bc70d ("arm64: Import latest version of Cortex Strings' strncmp")
> Reported-by: John Hsu <John.Hsu@mediatek.com>
> Link: https://lore.kernel.org/all/e9f30f7d5b7d72a3521da31ab2002b49a26f542e.camel@mediatek.com/
> Signed-off-by: Will Deacon <will@kernel.org>
> ---
>
> This is a clean cherry-pick of the latest MTE-safe strncmp()
> implementation for arm64 which landed in v5.18 and somewhat accidentally
> fixed an out-of-bounds read introduced in v5.14.
> An alternative would be to disable the optimised code altogether, but
> given that this is self-contained and applies cleanly, I'd favour being
> consistent with more recent kernels.
>
> arch/arm64/lib/strncmp.S | 244 +++++++++++++++++++++++----------------
> 1 file changed, 146 insertions(+), 98 deletions(-)
Now queued up, thanks.
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-07 16:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 18:03 [STABLE PATCH 5.15.y] arm64: lib: Import latest version of Arm Optimized Routines' strncmp Will Deacon
2023-09-06 18:03 ` Will Deacon
2023-09-06 20:47 ` Robin Murphy
2023-09-06 20:47 ` Robin Murphy
2023-09-07 11:23 ` Greg KH [this message]
2023-09-07 11:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023090716-extenuate-jittery-25bd@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=John.Hsu@mediatek.com \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.